All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [MPTCP] Re: general protection fault in selinux_socket_recvmsg
@ 2020-05-24 18:12 syzbot
  0 siblings, 0 replies; 3+ messages in thread
From: syzbot @ 2020-05-24 18:12 UTC (permalink / raw
  To: mptcp 

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

syzbot has bisected this bug to:

commit 263e1201a2c324b60b15ecda5de9ebf1e7293e31
Author: Paolo Abeni <pabeni(a)redhat.com>
Date:   Thu Apr 30 13:01:51 2020 +0000

    mptcp: consolidate synack processing.

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=12a5254a100000
start commit:   051143e1 Merge tag 'apparmor-pr-2020-05-21' of git://git.k..
git tree:       upstream
final crash:    https://syzkaller.appspot.com/x/report.txt?x=11a5254a100000
console output: https://syzkaller.appspot.com/x/log.txt?x=16a5254a100000
kernel config:  https://syzkaller.appspot.com/x/.config?x=b3368ce0cc5f5ace
dashboard link: https://syzkaller.appspot.com/bug?extid=c6bfc3db991edc918432
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=13eeacba100000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=167163e6100000

Reported-by: syzbot+c6bfc3db991edc918432(a)syzkaller.appspotmail.com
Fixes: 263e1201a2c3 ("mptcp: consolidate synack processing.")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [MPTCP] Re: general protection fault in selinux_socket_recvmsg
@ 2020-05-25  8:58 Paolo Abeni
  0 siblings, 0 replies; 3+ messages in thread
From: Paolo Abeni @ 2020-05-25  8:58 UTC (permalink / raw
  To: mptcp 

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master

---
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index 1f52a0fa31ed..69b66423305b 100644
--- a/net/mptcp/protocol.c
+++ b/net/mptcp/protocol.c
@@ -954,7 +954,8 @@ static int mptcp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len,
 
 		pr_debug("block timeout %ld", timeo);
 		mptcp_wait_data(sk, &timeo);
-		if (unlikely(__mptcp_tcp_fallback(msk)))
+		ssock = __mptcp_tcp_fallback(msk);
+		if (unlikely(ssock))
 			goto fallback;
 	}
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [MPTCP] Re: general protection fault in selinux_socket_recvmsg
@ 2020-05-25 10:38 syzbot
  0 siblings, 0 replies; 3+ messages in thread
From: syzbot @ 2020-05-25 10:38 UTC (permalink / raw
  To: mptcp 

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger crash:

Reported-and-tested-by: syzbot+c6bfc3db991edc918432(a)syzkaller.appspotmail.com

Tested on:

commit:         98790bba Merge tag 'efi-urgent-2020-05-24' of git://git.ke..
git tree:       net
kernel config:  https://syzkaller.appspot.com/x/.config?x=b3368ce0cc5f5ace
dashboard link: https://syzkaller.appspot.com/bug?extid=c6bfc3db991edc918432
compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
patch:          https://syzkaller.appspot.com/x/patch.diff?x=127e6016100000

Note: testing is done by a robot and is best-effort only.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-25 10:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-25  8:58 [MPTCP] Re: general protection fault in selinux_socket_recvmsg Paolo Abeni
  -- strict thread matches above, loose matches on Subject: below --
2020-05-25 10:38 syzbot
2020-05-24 18:12 syzbot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.