From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE2A1C19F28 for ; Wed, 3 Aug 2022 16:46:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233814AbiHCQqb (ORCPT ); Wed, 3 Aug 2022 12:46:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230163AbiHCQqa (ORCPT ); Wed, 3 Aug 2022 12:46:30 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F2EA1ADB6 for ; Wed, 3 Aug 2022 09:46:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1659545189; x=1691081189; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=2CpcfPd6rZVfCp1P9345LXN2BlJerSj9Z9tpZLGLDOM=; b=VNUNnT0cn6C82gMD+5HxbsvSuV+uAMW/jfTvPnBWPneV7hj/oLGfWGOS Hrz0t+i11bHdA7psiCkLbk6NbtM/Xiw0CkWR+2UxhCNq+JVNysMDJY5/C pgcMLnSGaH/Z4xmPcvqyvJBZyVY+spaGqNZyLeUoUkDQ9bWXvRqNn03p7 I=; Received: from ironmsg09-lv.qualcomm.com ([10.47.202.153]) by alexa-out.qualcomm.com with ESMTP; 03 Aug 2022 09:46:29 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg09-lv.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2022 09:46:29 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 3 Aug 2022 09:46:28 -0700 Received: from [10.50.19.88] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 3 Aug 2022 09:46:25 -0700 Message-ID: <733b6f1a-8b07-4b23-2b10-af1ce68b6227@quicinc.com> Date: Wed, 3 Aug 2022 22:16:19 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [RFC 1/2] wifi: mac80211: add a new field in ieee80211_rx_status for link id Content-Language: en-CA To: Jeff Johnson , CC: References: <20220802065019.20791-1-quic_vthiagar@quicinc.com> <20220802065019.20791-2-quic_vthiagar@quicinc.com> <29694008-63ef-4cd3-a6c6-f82fc8377be6@quicinc.com> From: Vasanthakumar Thiagarajan In-Reply-To: <29694008-63ef-4cd3-a6c6-f82fc8377be6@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 8/2/2022 8:58 PM, Jeff Johnson wrote: > On 8/1/2022 11:50 PM, Vasanthakumar Thiagarajan wrote: >> In MLO, when the address translation from link to MLD is done >> in fw/hw, it is necessary to be able to have some information >> on the link on which the frame has been received. Extend the >> rx API to include link_id in ieee80211_rx_status. >> >> Signed-off-by: Vasanthakumar Thiagarajan >> --- >>   include/net/mac80211.h | 4 ++++ >>   1 file changed, 4 insertions(+) >> >> diff --git a/include/net/mac80211.h b/include/net/mac80211.h >> index f198af600b5e..23bc34657b16 100644 >> --- a/include/net/mac80211.h >> +++ b/include/net/mac80211.h >> @@ -1480,6 +1480,9 @@ enum mac80211_rx_encoding { >>    *    each A-MPDU but the same for each subframe within one A-MPDU >>    * @ampdu_delimiter_crc: A-MPDU delimiter CRC >>    * @zero_length_psdu_type: radiotap type of the 0-length PSDU >> + * @link_id: id of the link used to receive the packet. Applicable >> only with >> + *    MLO connection, valid link ids are in 0-14, link_id 15 means >> either the >> + *    link id is not known or it is a non-MLO connection. >>    */ >>   struct ieee80211_rx_status { >>       u64 mactime; >> @@ -1504,6 +1507,7 @@ struct ieee80211_rx_status { >>       s8 chain_signal[IEEE80211_MAX_CHAINS]; >>       u8 ampdu_delimiter_crc; >>       u8 zero_length_psdu_type; >> +    u8 link_id; >>   }; >>   static inline u32 > > in other parts of the MLO code the link_id is defined as int and a value > of -1 is used for a non-MLO link. but I don't know if that is currently > universally true. > > if that is curently universally true, do we want to now have divergent > definitions of a link_id? Good point, i see link_id is used both as unsigned and int based on their usage. The reason I preferred unsigned is that we can make use of the remaining 4-bits for some other purpose in future, ieee80211_rx_status has size limitation. Vasanth