All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/18] ARM/lpc32xx/timer: Migrate to new 'set-state' interface
Date: Mon,  6 Jul 2015 16:24:16 +0530	[thread overview]
Message-ID: <79792dd6257c2dbdde4f90a4abbdc742490843b7.1436178990.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1436178990.git.viresh.kumar@linaro.org>

Migrate lpc32xx driver to the new 'set-state' interface provided by
clockevents core, the earlier 'set-mode' interface is marked obsolete
now.

This also enables us to implement callbacks for new states of clockevent
devices, for example: ONESHOT_STOPPED.

Cc: Roland Stigge <stigge@antcom.de>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 arch/arm/mach-lpc32xx/timer.c | 40 ++++++++++++++--------------------------
 1 file changed, 14 insertions(+), 26 deletions(-)

diff --git a/arch/arm/mach-lpc32xx/timer.c b/arch/arm/mach-lpc32xx/timer.c
index 4e5837299c04..ff3499d1fb1a 100644
--- a/arch/arm/mach-lpc32xx/timer.c
+++ b/arch/arm/mach-lpc32xx/timer.c
@@ -43,36 +43,24 @@ static int lpc32xx_clkevt_next_event(unsigned long delta,
 	return 0;
 }
 
-static void lpc32xx_clkevt_mode(enum clock_event_mode mode,
-    struct clock_event_device *dev)
+static int lpc32xx_shutdown(struct clock_event_device *evt)
 {
-	switch (mode) {
-	case CLOCK_EVT_MODE_PERIODIC:
-		WARN_ON(1);
-		break;
-
-	case CLOCK_EVT_MODE_ONESHOT:
-	case CLOCK_EVT_MODE_SHUTDOWN:
-		/*
-		 * Disable the timer. When using oneshot, we must also
-		 * disable the timer to wait for the first call to
-		 * set_next_event().
-		 */
-		__raw_writel(0, LPC32XX_TIMER_TCR(LPC32XX_TIMER0_BASE));
-		break;
-
-	case CLOCK_EVT_MODE_UNUSED:
-	case CLOCK_EVT_MODE_RESUME:
-		break;
-	}
+	/*
+	 * Disable the timer. When using oneshot, we must also
+	 * disable the timer to wait for the first call to
+	 * set_next_event().
+	 */
+	__raw_writel(0, LPC32XX_TIMER_TCR(LPC32XX_TIMER0_BASE));
+	return 0;
 }
 
 static struct clock_event_device lpc32xx_clkevt = {
-	.name		= "lpc32xx_clkevt",
-	.features	= CLOCK_EVT_FEAT_ONESHOT,
-	.rating		= 300,
-	.set_next_event	= lpc32xx_clkevt_next_event,
-	.set_mode	= lpc32xx_clkevt_mode,
+	.name			= "lpc32xx_clkevt",
+	.features		= CLOCK_EVT_FEAT_ONESHOT,
+	.rating			= 300,
+	.set_next_event		= lpc32xx_clkevt_next_event,
+	.set_state_shutdown	= lpc32xx_shutdown,
+	.set_state_oneshot	= lpc32xx_shutdown,
 };
 
 static irqreturn_t lpc32xx_timer_interrupt(int irq, void *dev_id)
-- 
2.4.0

  parent reply	other threads:[~2015-07-06 10:54 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 10:54 [PATCH 00/18] ARM: Migrate clockevent drivers to 'set-state' Viresh Kumar
2015-07-06 10:54 ` [PATCH 01/18] ARM/smp_twd: Migrate to new 'set-state' interface Viresh Kumar
2015-07-06 10:54 ` [PATCH 02/18] ARM/cns3xxx/timer: " Viresh Kumar
2015-07-14  6:03   ` Krzysztof Hałasa
2015-07-06 10:54 ` [PATCH 03/18] ARM/davinci/time: " Viresh Kumar
2015-07-06 10:54 ` [PATCH 04/18] ARM/dc21285-timer: " Viresh Kumar
2015-07-06 10:54 ` [PATCH 05/18] ARM/gemini/time: " Viresh Kumar
2015-07-06 19:36   ` Hans Ulli Kroll
2015-07-06 10:54 ` [PATCH 06/18] ARM/imx/epit: " Viresh Kumar
2015-07-06 10:54 ` [PATCH 07/18] ARM/ixp4xx/timer: " Viresh Kumar
2015-07-14  6:04   ` Krzysztof Hałasa
2015-07-06 10:54 ` [PATCH 08/18] ARM/ks8695/time: " Viresh Kumar
2015-07-07 12:22   ` Greg Ungerer
2015-07-06 10:54 ` Viresh Kumar [this message]
2015-07-06 10:54 ` [PATCH 10/18] ARM/mmp/time: " Viresh Kumar
2015-07-06 10:54 ` [PATCH 11/18] ARM/netx/time: " Viresh Kumar
2015-07-06 10:54 ` [PATCH 12/18] ARM/omap1/time: " Viresh Kumar
2015-07-06 15:20   ` santosh shilimkar
2015-07-09  9:48     ` Tony Lindgren
2015-07-06 10:54 ` [PATCH 13/18] ARM/omap1/timer32: " Viresh Kumar
2015-07-06 15:21   ` santosh shilimkar
2015-07-09  9:49     ` Tony Lindgren
2015-07-06 10:54 ` [PATCH 14/18] ARM/omap2/timer: " Viresh Kumar
2015-07-06 15:20   ` santosh shilimkar
2015-07-09  9:50     ` Tony Lindgren
2015-07-06 10:54 ` [PATCH 15/18] ARM/SPEAr/time: " Viresh Kumar
2015-07-06 10:54 ` [PATCH 16/18] ARM/w90x900/time: " Viresh Kumar
2015-07-06 10:54 ` [PATCH 17/18] ARM/iop/time: " Viresh Kumar
2015-07-06 10:54 ` [PATCH 18/18] ARM/orion/time: " Viresh Kumar
2015-07-06 17:26 ` [PATCH 00/18] ARM: Migrate clockevent drivers to 'set-state' Thomas Gleixner
2015-07-07  8:11   ` [PULL] clockevents: last minute patch for 4.2-rc2 Daniel Lezcano
2015-07-07  8:14     ` [PATCH] clockevents: Allow set-state callbacks to be optional Daniel Lezcano
2015-07-07  8:49       ` [tip:timers/urgent] " tip-bot for Viresh Kumar
2015-07-13  2:52 ` [PATCH 00/18] ARM: Migrate clockevent drivers to 'set-state' Viresh Kumar
  -- strict thread matches above, loose matches on Subject: below --
2015-07-17  5:10 [PULL] ARM: clockevents: Migrate to 'set-state' callbacks Viresh Kumar
2015-07-17  5:11 ` [PATCH 09/18] ARM/lpc32xx/timer: Migrate to new 'set-state' interface Viresh Kumar
2015-07-17  5:11   ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79792dd6257c2dbdde4f90a4abbdc742490843b7.1436178990.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.