From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Willian Rampazzo <willianr@redhat.com>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH] tests/acceptance: Add a 'virt_kvm' test using the GICv3
Date: Tue, 6 Apr 2021 17:22:05 +0200 [thread overview]
Message-ID: <7a720701-a34f-ccf4-d116-a0f0703b5f83@redhat.com> (raw)
In-Reply-To: <87eefvnx3s.fsf@linaro.org>
On 3/31/21 5:45 PM, Alex Bennée wrote:
>
> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>
>> The current 'virt_kvm' test is restricted to GICv2, but can also
>> work with a GICv3. Duplicate it but add a GICv3 test which can be
>> tested on some hardware.
>>
>> Noticed while running:
>>
>> $ avocado --show=app run -t machine:virt tests/acceptance/
>> ...
>> (2/6) tests/acceptance/boot_linux.py:BootLinuxAarch64.test_virt_kvm: ERROR: Unexpected empty reply from server (1.82 s)
>>
>> The job.log content is:
>>
>> L0351 DEBUG| Output: 'qemu-system-aarch64: host does not support in-kernel GICv2 emulation\n'
>>
>> With this patch:
>>
>> $ avocado --show=app run -t device:gicv3 tests/acceptance/
>> (1/1)
>> tests/acceptance/boot_linux.py:BootLinuxAarch64.test_virt_kvm_gicv3:
>> PASS (55.10 s)
>
> On the new aarch64 machine which is GICv3 I get the following:
>
> (006/142) tests/acceptance/boot_linux.py:BootLinuxAarch64.test_virt_kvm_gicv2: ERROR: Unexpected empty reply from server (0.47 s)
>
> which it shouldn't have run. However:
>
> ./tests/venv/bin/avocado --show=app run -t device:gic3 tests/acceptance/
> Test Suite could not be create. No test references provided nor any other arguments resolved into tests
>
> Is this something that has regressed or am I doing it wrong?
Typo in the tag: "device:gic3" -> "device:gicv3"
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> tests/acceptance/boot_linux.py | 17 ++++++++++++++++-
>> 1 file changed, 16 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/acceptance/boot_linux.py b/tests/acceptance/boot_linux.py
>> index 0055dc7cee..c743e231f4 100644
>> --- a/tests/acceptance/boot_linux.py
>> +++ b/tests/acceptance/boot_linux.py
>> @@ -182,10 +182,11 @@ def test_virt_tcg(self):
>> self.add_common_args()
>> self.launch_and_wait()
>>
>> - def test_virt_kvm(self):
>> + def test_virt_kvm_gicv2(self):
>> """
>> :avocado: tags=accel:kvm
>> :avocado: tags=cpu:host
>> + :avocado: tags=device:gicv2
>> """
>> if not kvm_available(self.arch, self.qemu_bin):
>> self.cancel(KVM_NOT_AVAILABLE)
>> @@ -195,6 +196,20 @@ def test_virt_kvm(self):
>> self.add_common_args()
>> self.launch_and_wait()
>>
>> + def test_virt_kvm_gicv3(self):
>> + """
>> + :avocado: tags=accel:kvm
>> + :avocado: tags=cpu:host
>> + :avocado: tags=device:gicv3
>> + """
>> + if not kvm_available(self.arch, self.qemu_bin):
>> + self.cancel(KVM_NOT_AVAILABLE)
>> + self.vm.add_args("-accel", "kvm")
>> + self.vm.add_args("-cpu", "host")
>> + self.vm.add_args("-machine", "virt,gic-version=3")
>> + self.add_common_args()
>> + self.launch_and_wait()
>> +
>>
>> class BootLinuxPPC64(BootLinux):
>> """
>
>
next prev parent reply other threads:[~2021-04-06 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 22:48 [PATCH] tests/acceptance: Add a 'virt_kvm' test using the GICv3 Philippe Mathieu-Daudé
2020-09-30 13:24 ` Willian Rampazzo
2020-10-05 8:08 ` Philippe Mathieu-Daudé
2021-03-31 15:45 ` Alex Bennée
2021-04-06 15:22 ` Philippe Mathieu-Daudé [this message]
2021-04-06 17:12 ` Alex Bennée
2021-04-12 17:55 ` Philippe Mathieu-Daudé
2021-04-13 16:25 ` Philippe Mathieu-Daudé
2021-04-13 16:32 ` Alex Bennée
2021-05-26 18:04 ` Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a720701-a34f-ccf4-d116-a0f0703b5f83@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.