All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64/sysreg: Update ID_AA64MMFR2_EL1 register
@ 2024-04-19  2:13 ` Anshuman Khandual
  0 siblings, 0 replies; 12+ messages in thread
From: Anshuman Khandual @ 2024-04-19  2:13 UTC (permalink / raw
  To: linux-arm-kernel, catalin.marinas
  Cc: Anshuman Khandual, Will Deacon, Mark Brown, linux-kernel

This updates ID_AA64MMFR2_EL1.VARange register fields as per the definition
based on DDI0601 2024-03.

Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
This applies on v6.9-rc4

 arch/arm64/tools/sysreg | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index a4c1dd4741a4..6d7213dcbeb5 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -1739,6 +1739,7 @@ EndEnum
 UnsignedEnum	19:16	VARange
 	0b0000	48
 	0b0001	52
+	0b0010	56
 EndEnum
 UnsignedEnum	15:12	IESB
 	0b0000	NI
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH] arm64/sysreg: Update ID_AA64MMFR2_EL1 register
@ 2024-04-19  2:13 ` Anshuman Khandual
  0 siblings, 0 replies; 12+ messages in thread
From: Anshuman Khandual @ 2024-04-19  2:13 UTC (permalink / raw
  To: linux-arm-kernel, catalin.marinas
  Cc: Anshuman Khandual, Will Deacon, Mark Brown, linux-kernel

This updates ID_AA64MMFR2_EL1.VARange register fields as per the definition
based on DDI0601 2024-03.

Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
This applies on v6.9-rc4

 arch/arm64/tools/sysreg | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index a4c1dd4741a4..6d7213dcbeb5 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -1739,6 +1739,7 @@ EndEnum
 UnsignedEnum	19:16	VARange
 	0b0000	48
 	0b0001	52
+	0b0010	56
 EndEnum
 UnsignedEnum	15:12	IESB
 	0b0000	NI
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64/sysreg: Update ID_AA64MMFR2_EL1 register
  2024-04-19  2:13 ` Anshuman Khandual
@ 2024-04-19 13:46   ` Will Deacon
  -1 siblings, 0 replies; 12+ messages in thread
From: Will Deacon @ 2024-04-19 13:46 UTC (permalink / raw
  To: Anshuman Khandual
  Cc: linux-arm-kernel, catalin.marinas, Mark Brown, linux-kernel

On Fri, Apr 19, 2024 at 07:43:25AM +0530, Anshuman Khandual wrote:
> This updates ID_AA64MMFR2_EL1.VARange register fields as per the definition
> based on DDI0601 2024-03.
> 
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> This applies on v6.9-rc4
> 
>  arch/arm64/tools/sysreg | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index a4c1dd4741a4..6d7213dcbeb5 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -1739,6 +1739,7 @@ EndEnum
>  UnsignedEnum	19:16	VARange
>  	0b0000	48
>  	0b0001	52
> +	0b0010	56

Is anybody using this? I'm not sure there's a lot of value in adding
these fields one-by-one for the sake of completeness.

Will

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64/sysreg: Update ID_AA64MMFR2_EL1 register
@ 2024-04-19 13:46   ` Will Deacon
  0 siblings, 0 replies; 12+ messages in thread
From: Will Deacon @ 2024-04-19 13:46 UTC (permalink / raw
  To: Anshuman Khandual
  Cc: linux-arm-kernel, catalin.marinas, Mark Brown, linux-kernel

On Fri, Apr 19, 2024 at 07:43:25AM +0530, Anshuman Khandual wrote:
> This updates ID_AA64MMFR2_EL1.VARange register fields as per the definition
> based on DDI0601 2024-03.
> 
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> This applies on v6.9-rc4
> 
>  arch/arm64/tools/sysreg | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index a4c1dd4741a4..6d7213dcbeb5 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -1739,6 +1739,7 @@ EndEnum
>  UnsignedEnum	19:16	VARange
>  	0b0000	48
>  	0b0001	52
> +	0b0010	56

Is anybody using this? I'm not sure there's a lot of value in adding
these fields one-by-one for the sake of completeness.

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64/sysreg: Update ID_AA64MMFR2_EL1 register
  2024-04-19 13:46   ` Will Deacon
@ 2024-04-22  3:08     ` Anshuman Khandual
  -1 siblings, 0 replies; 12+ messages in thread
From: Anshuman Khandual @ 2024-04-22  3:08 UTC (permalink / raw
  To: Will Deacon; +Cc: linux-arm-kernel, catalin.marinas, Mark Brown, linux-kernel



On 4/19/24 19:16, Will Deacon wrote:
> On Fri, Apr 19, 2024 at 07:43:25AM +0530, Anshuman Khandual wrote:
>> This updates ID_AA64MMFR2_EL1.VARange register fields as per the definition
>> based on DDI0601 2024-03.
>>
>> Cc: Catalin Marinas <catalin.marinas@arm.com>
>> Cc: Will Deacon <will@kernel.org>
>> Cc: Mark Brown <broonie@kernel.org>
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
>> ---
>> This applies on v6.9-rc4
>>
>>  arch/arm64/tools/sysreg | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
>> index a4c1dd4741a4..6d7213dcbeb5 100644
>> --- a/arch/arm64/tools/sysreg
>> +++ b/arch/arm64/tools/sysreg
>> @@ -1739,6 +1739,7 @@ EndEnum
>>  UnsignedEnum	19:16	VARange
>>  	0b0000	48
>>  	0b0001	52
>> +	0b0010	56
> 
> Is anybody using this? I'm not sure there's a lot of value in adding
> these fields one-by-one for the sake of completeness.

This is not being used currently but will be required for upcoming
features. I was under the impression that register fields (atleast
for the ID registers) should be kept updated, with latest released
spec ? Besides lately arch/arm64/tools/sysreg serves as very good
reference for all necessary register fields.

https://developer.arm.com/documentation/ddi0601/2024-03/AArch64-Registers/ID-AA64MMFR2-EL1--AArch64-Memory-Model-Feature-Register-2

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64/sysreg: Update ID_AA64MMFR2_EL1 register
@ 2024-04-22  3:08     ` Anshuman Khandual
  0 siblings, 0 replies; 12+ messages in thread
From: Anshuman Khandual @ 2024-04-22  3:08 UTC (permalink / raw
  To: Will Deacon; +Cc: linux-arm-kernel, catalin.marinas, Mark Brown, linux-kernel



On 4/19/24 19:16, Will Deacon wrote:
> On Fri, Apr 19, 2024 at 07:43:25AM +0530, Anshuman Khandual wrote:
>> This updates ID_AA64MMFR2_EL1.VARange register fields as per the definition
>> based on DDI0601 2024-03.
>>
>> Cc: Catalin Marinas <catalin.marinas@arm.com>
>> Cc: Will Deacon <will@kernel.org>
>> Cc: Mark Brown <broonie@kernel.org>
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
>> ---
>> This applies on v6.9-rc4
>>
>>  arch/arm64/tools/sysreg | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
>> index a4c1dd4741a4..6d7213dcbeb5 100644
>> --- a/arch/arm64/tools/sysreg
>> +++ b/arch/arm64/tools/sysreg
>> @@ -1739,6 +1739,7 @@ EndEnum
>>  UnsignedEnum	19:16	VARange
>>  	0b0000	48
>>  	0b0001	52
>> +	0b0010	56
> 
> Is anybody using this? I'm not sure there's a lot of value in adding
> these fields one-by-one for the sake of completeness.

This is not being used currently but will be required for upcoming
features. I was under the impression that register fields (atleast
for the ID registers) should be kept updated, with latest released
spec ? Besides lately arch/arm64/tools/sysreg serves as very good
reference for all necessary register fields.

https://developer.arm.com/documentation/ddi0601/2024-03/AArch64-Registers/ID-AA64MMFR2-EL1--AArch64-Memory-Model-Feature-Register-2

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64/sysreg: Update ID_AA64MMFR2_EL1 register
  2024-04-22  3:08     ` Anshuman Khandual
@ 2024-04-22 17:16       ` Will Deacon
  -1 siblings, 0 replies; 12+ messages in thread
From: Will Deacon @ 2024-04-22 17:16 UTC (permalink / raw
  To: Anshuman Khandual
  Cc: linux-arm-kernel, catalin.marinas, Mark Brown, linux-kernel

On Mon, Apr 22, 2024 at 08:38:40AM +0530, Anshuman Khandual wrote:
> 
> 
> On 4/19/24 19:16, Will Deacon wrote:
> > On Fri, Apr 19, 2024 at 07:43:25AM +0530, Anshuman Khandual wrote:
> >> This updates ID_AA64MMFR2_EL1.VARange register fields as per the definition
> >> based on DDI0601 2024-03.
> >>
> >> Cc: Catalin Marinas <catalin.marinas@arm.com>
> >> Cc: Will Deacon <will@kernel.org>
> >> Cc: Mark Brown <broonie@kernel.org>
> >> Cc: linux-arm-kernel@lists.infradead.org
> >> Cc: linux-kernel@vger.kernel.org
> >> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> >> ---
> >> This applies on v6.9-rc4
> >>
> >>  arch/arm64/tools/sysreg | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> >> index a4c1dd4741a4..6d7213dcbeb5 100644
> >> --- a/arch/arm64/tools/sysreg
> >> +++ b/arch/arm64/tools/sysreg
> >> @@ -1739,6 +1739,7 @@ EndEnum
> >>  UnsignedEnum	19:16	VARange
> >>  	0b0000	48
> >>  	0b0001	52
> >> +	0b0010	56
> > 
> > Is anybody using this? I'm not sure there's a lot of value in adding
> > these fields one-by-one for the sake of completeness.
> 
> This is not being used currently but will be required for upcoming
> features. I was under the impression that register fields (atleast
> for the ID registers) should be kept updated, with latest released
> spec ? Besides lately arch/arm64/tools/sysreg serves as very good
> reference for all necessary register fields.

Why? The linux headers aren't documenting the architecture.

Will

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64/sysreg: Update ID_AA64MMFR2_EL1 register
@ 2024-04-22 17:16       ` Will Deacon
  0 siblings, 0 replies; 12+ messages in thread
From: Will Deacon @ 2024-04-22 17:16 UTC (permalink / raw
  To: Anshuman Khandual
  Cc: linux-arm-kernel, catalin.marinas, Mark Brown, linux-kernel

On Mon, Apr 22, 2024 at 08:38:40AM +0530, Anshuman Khandual wrote:
> 
> 
> On 4/19/24 19:16, Will Deacon wrote:
> > On Fri, Apr 19, 2024 at 07:43:25AM +0530, Anshuman Khandual wrote:
> >> This updates ID_AA64MMFR2_EL1.VARange register fields as per the definition
> >> based on DDI0601 2024-03.
> >>
> >> Cc: Catalin Marinas <catalin.marinas@arm.com>
> >> Cc: Will Deacon <will@kernel.org>
> >> Cc: Mark Brown <broonie@kernel.org>
> >> Cc: linux-arm-kernel@lists.infradead.org
> >> Cc: linux-kernel@vger.kernel.org
> >> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> >> ---
> >> This applies on v6.9-rc4
> >>
> >>  arch/arm64/tools/sysreg | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> >> index a4c1dd4741a4..6d7213dcbeb5 100644
> >> --- a/arch/arm64/tools/sysreg
> >> +++ b/arch/arm64/tools/sysreg
> >> @@ -1739,6 +1739,7 @@ EndEnum
> >>  UnsignedEnum	19:16	VARange
> >>  	0b0000	48
> >>  	0b0001	52
> >> +	0b0010	56
> > 
> > Is anybody using this? I'm not sure there's a lot of value in adding
> > these fields one-by-one for the sake of completeness.
> 
> This is not being used currently but will be required for upcoming
> features. I was under the impression that register fields (atleast
> for the ID registers) should be kept updated, with latest released
> spec ? Besides lately arch/arm64/tools/sysreg serves as very good
> reference for all necessary register fields.

Why? The linux headers aren't documenting the architecture.

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64/sysreg: Update ID_AA64MMFR2_EL1 register
  2024-04-22 17:16       ` Will Deacon
@ 2024-04-23  5:17         ` Mark Brown
  -1 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2024-04-23  5:17 UTC (permalink / raw
  To: Will Deacon
  Cc: Anshuman Khandual, linux-arm-kernel, catalin.marinas,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

On Mon, Apr 22, 2024 at 06:16:13PM +0100, Will Deacon wrote:
> On Mon, Apr 22, 2024 at 08:38:40AM +0530, Anshuman Khandual wrote:

> > This is not being used currently but will be required for upcoming
> > features. I was under the impression that register fields (atleast
> > for the ID registers) should be kept updated, with latest released
> > spec ? Besides lately arch/arm64/tools/sysreg serves as very good
> > reference for all necessary register fields.

> Why? The linux headers aren't documenting the architecture.

I don't know that it's something that we should be doing apropos of
nothing but if people have done updates and they're not unreasonbly
complicated to review it does seem useful to integrate them to avoid
duplicated work.  There have been some issues with that around the ID
registers (which are going to be on the places most prone to this I
guess).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64/sysreg: Update ID_AA64MMFR2_EL1 register
@ 2024-04-23  5:17         ` Mark Brown
  0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2024-04-23  5:17 UTC (permalink / raw
  To: Will Deacon
  Cc: Anshuman Khandual, linux-arm-kernel, catalin.marinas,
	linux-kernel


[-- Attachment #1.1: Type: text/plain, Size: 878 bytes --]

On Mon, Apr 22, 2024 at 06:16:13PM +0100, Will Deacon wrote:
> On Mon, Apr 22, 2024 at 08:38:40AM +0530, Anshuman Khandual wrote:

> > This is not being used currently but will be required for upcoming
> > features. I was under the impression that register fields (atleast
> > for the ID registers) should be kept updated, with latest released
> > spec ? Besides lately arch/arm64/tools/sysreg serves as very good
> > reference for all necessary register fields.

> Why? The linux headers aren't documenting the architecture.

I don't know that it's something that we should be doing apropos of
nothing but if people have done updates and they're not unreasonbly
complicated to review it does seem useful to integrate them to avoid
duplicated work.  There have been some issues with that around the ID
registers (which are going to be on the places most prone to this I
guess).

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64/sysreg: Update ID_AA64MMFR2_EL1 register
  2024-04-23  5:17         ` Mark Brown
@ 2024-04-29  2:04           ` Anshuman Khandual
  -1 siblings, 0 replies; 12+ messages in thread
From: Anshuman Khandual @ 2024-04-29  2:04 UTC (permalink / raw
  To: Mark Brown, Will Deacon; +Cc: linux-arm-kernel, catalin.marinas, linux-kernel



On 4/23/24 10:47, Mark Brown wrote:
> On Mon, Apr 22, 2024 at 06:16:13PM +0100, Will Deacon wrote:
>> On Mon, Apr 22, 2024 at 08:38:40AM +0530, Anshuman Khandual wrote:
> 
>>> This is not being used currently but will be required for upcoming
>>> features. I was under the impression that register fields (atleast
>>> for the ID registers) should be kept updated, with latest released
>>> spec ? Besides lately arch/arm64/tools/sysreg serves as very good
>>> reference for all necessary register fields.
> 
>> Why? The linux headers aren't documenting the architecture.
> 
> I don't know that it's something that we should be doing apropos of
> nothing but if people have done updates and they're not unreasonbly
> complicated to review it does seem useful to integrate them to avoid
> duplicated work.  There have been some issues with that around the ID
> registers (which are going to be on the places most prone to this I
> guess).

The other problem is by not updating the individual register fields with
the latest spec, it also gives an wrong impression about that field, and
also might create confusion.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64/sysreg: Update ID_AA64MMFR2_EL1 register
@ 2024-04-29  2:04           ` Anshuman Khandual
  0 siblings, 0 replies; 12+ messages in thread
From: Anshuman Khandual @ 2024-04-29  2:04 UTC (permalink / raw
  To: Mark Brown, Will Deacon; +Cc: linux-arm-kernel, catalin.marinas, linux-kernel



On 4/23/24 10:47, Mark Brown wrote:
> On Mon, Apr 22, 2024 at 06:16:13PM +0100, Will Deacon wrote:
>> On Mon, Apr 22, 2024 at 08:38:40AM +0530, Anshuman Khandual wrote:
> 
>>> This is not being used currently but will be required for upcoming
>>> features. I was under the impression that register fields (atleast
>>> for the ID registers) should be kept updated, with latest released
>>> spec ? Besides lately arch/arm64/tools/sysreg serves as very good
>>> reference for all necessary register fields.
> 
>> Why? The linux headers aren't documenting the architecture.
> 
> I don't know that it's something that we should be doing apropos of
> nothing but if people have done updates and they're not unreasonbly
> complicated to review it does seem useful to integrate them to avoid
> duplicated work.  There have been some issues with that around the ID
> registers (which are going to be on the places most prone to this I
> guess).

The other problem is by not updating the individual register fields with
the latest spec, it also gives an wrong impression about that field, and
also might create confusion.

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-04-29  2:12 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-19  2:13 [PATCH] arm64/sysreg: Update ID_AA64MMFR2_EL1 register Anshuman Khandual
2024-04-19  2:13 ` Anshuman Khandual
2024-04-19 13:46 ` Will Deacon
2024-04-19 13:46   ` Will Deacon
2024-04-22  3:08   ` Anshuman Khandual
2024-04-22  3:08     ` Anshuman Khandual
2024-04-22 17:16     ` Will Deacon
2024-04-22 17:16       ` Will Deacon
2024-04-23  5:17       ` Mark Brown
2024-04-23  5:17         ` Mark Brown
2024-04-29  2:04         ` Anshuman Khandual
2024-04-29  2:04           ` Anshuman Khandual

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.