* [PATCH] sound: tegra20-spdif: remove "default m"
@ 2017-09-17 15:15 Michał Mirosław
[not found] ` <c765842d4cc6af91ae0d6977922e6ae6f6e1dfa8.1505661134.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Michał Mirosław @ 2017-09-17 15:15 UTC (permalink / raw
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Thierry Reding, Jonathan Hunter
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
Default != n for drivers is frowned upon. This is the only one among
tegra sound drivers that was different.
Signed-off-by: Michał Mirosław <mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
---
sound/soc/tegra/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kconfig
index 6875fc39a575..6c893c677110 100644
--- a/sound/soc/tegra/Kconfig
+++ b/sound/soc/tegra/Kconfig
@@ -38,7 +38,6 @@ config SND_SOC_TEGRA20_I2S
config SND_SOC_TEGRA20_SPDIF
tristate "Tegra20 SPDIF interface"
depends on SND_SOC_TEGRA
- default m
help
Say Y or M if you want to add support for the Tegra20 SPDIF interface.
You will also need to select the individual machine drivers to support
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sound: tegra20-spdif: remove "default m"
[not found] ` <c765842d4cc6af91ae0d6977922e6ae6f6e1dfa8.1505661134.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
@ 2017-09-25 20:37 ` Dmitry Osipenko
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Osipenko @ 2017-09-25 20:37 UTC (permalink / raw
To: Michał Mirosław, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Thierry Reding, Jonathan Hunter
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
On 17.09.2017 18:15, Michał Mirosław wrote:
> Default != n for drivers is frowned upon. This is the only one among
> tegra sound drivers that was different.
>
> Signed-off-by: Michał Mirosław <mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
> ---
> sound/soc/tegra/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kconfig
> index 6875fc39a575..6c893c677110 100644
> --- a/sound/soc/tegra/Kconfig
> +++ b/sound/soc/tegra/Kconfig
> @@ -38,7 +38,6 @@ config SND_SOC_TEGRA20_I2S
> config SND_SOC_TEGRA20_SPDIF
> tristate "Tegra20 SPDIF interface"
> depends on SND_SOC_TEGRA
> - default m
> help
> Say Y or M if you want to add support for the Tegra20 SPDIF interface.
> You will also need to select the individual machine drivers to support
>
IIUC this driver should be integrated with the Tegra DRM to be useful. Making it
built-in by default would just increase kernels size.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-25 20:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-17 15:15 [PATCH] sound: tegra20-spdif: remove "default m" Michał Mirosław
[not found] ` <c765842d4cc6af91ae0d6977922e6ae6f6e1dfa8.1505661134.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2017-09-25 20:37 ` Dmitry Osipenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.