From: Gavin Shan <gshan@redhat.com>
To: David Hildenbrand <david@redhat.com>, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, osalvador@suse.de,
gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH 1/2] drivers/base/memory: Simplify add_boot_memory_block()
Date: Sat, 15 Feb 2025 09:48:31 +1000 [thread overview]
Message-ID: <7d9d0ba9-a503-4009-8dd9-ded51c620128@redhat.com> (raw)
In-Reply-To: <bfad9746-689e-4275-9d68-f8d062526412@redhat.com>
On 2/14/25 5:53 PM, David Hildenbrand wrote:
> On 14.02.25 07:35, Gavin Shan wrote:
>> It's unnecessary to keep the variable @section_count in the function
>> because the device for the specific memory block will be added if
>> any of its memory section is present. The variable @section_count
>> records the number of present memory sections in the specific memory
>> block, which isn't needed.
>>
>> Simplify the function by dropping the variable @section_count. No
>> functional change intended.
>>
>> Signed-off-by: Gavin Shan <gshan@redhat.com>
>> ---
>> drivers/base/memory.c | 15 +++++++--------
>> 1 file changed, 7 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
>> index 348c5dbbfa68..208b9b544012 100644
>> --- a/drivers/base/memory.c
>> +++ b/drivers/base/memory.c
>> @@ -822,18 +822,17 @@ static int add_memory_block(unsigned long block_id, unsigned long state,
>> static int __init add_boot_memory_block(unsigned long base_section_nr)
>> {
>> - int section_count = 0;
>> unsigned long nr;
>> for (nr = base_section_nr; nr < base_section_nr + sections_per_block;
>> - nr++)
>> - if (present_section_nr(nr))
>> - section_count++;
>> + nr++) {
>> + if (present_section_nr(nr)) {
>> + return add_memory_block(memory_block_id(base_section_nr),
>> + MEM_ONLINE, NULL, NULL);
>> + }
>
> Superfluous set of braces for the if statement.
>
> Not sure I count this while thing here as a "simplifcation" -- the code is IMHO easier to read without the nested return in the loop body.
>
> No strong opinion, though.
>
Indeed. I will use for_each_present_section_nr() as Andrew suggested. With it,
one level of the nested if statement can be avoided. The point was to avoid
counting the number of present sections in the specified block since the block
will be added if any section is present.
Thanks,
Gavin
next prev parent reply other threads:[~2025-02-14 23:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 6:35 [PATCH 0/2] drivers/base/memory: Two cleanups Gavin Shan
2025-02-14 6:35 ` [PATCH 1/2] drivers/base/memory: Simplify add_boot_memory_block() Gavin Shan
2025-02-14 7:53 ` David Hildenbrand
2025-02-14 23:48 ` Gavin Shan [this message]
2025-02-14 22:57 ` Andrew Morton
2025-02-14 23:45 ` Gavin Shan
2025-02-14 6:35 ` [PATCH 2/2] drivers/base/memory: Correct the field name in the header Gavin Shan
2025-02-14 7:54 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d9d0ba9-a503-4009-8dd9-ded51c620128@redhat.com \
--to=gshan@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dakr@kernel.org \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.