From: "Slark Xiao" <slark_xiao@163.com>
To: "Loic Poulain" <loic.poulain@linaro.org>
Cc: ryazanov.s.a@gmail.com, johannes@sipsolutions.net,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Hariprasad Kelam" <hkelam@marvell.com>
Subject: Re:Re: [PATCH net v2] net: wwan: Fix missing net device name for error message print
Date: Sat, 27 Apr 2024 13:57:36 +0800 (CST) [thread overview]
Message-ID: <7f434e77.2191.18f1e216533.Coremail.slark_xiao@163.com> (raw)
In-Reply-To: <CAMZdPi-VNEUJK+AUcyCXii5in6OLfKjxrNM1KHwQf=9QV_cqJA@mail.gmail.com>
At 2024-04-26 20:04:39, "Loic Poulain" <loic.poulain@linaro.org> wrote:
>Hello,
>
>On Fri, 26 Apr 2024 at 11:25, Slark Xiao <slark_xiao@163.com> wrote:
>>
>> In my local, I got an error print in dmesg like below:
>> "sequence number glitch prev=487 curr=0"
>> After checking, it belongs to mhi_wwan_mbim.c. Refer to the usage
>> of this net_err_ratelimited() API in other files, I think we
>> should add net device name print before message context.
>>
>> Fixes: aa730a9905b7 ("net: wwan: Add MHI MBIM network driver")
>
>This is more a cosmetic change than a bugfix, you should target net-next IMO.
>Also as said in another feedback, the commit message does not match the change,
>since you're not printing the device name.
Agree. But in some functions, we can't call the net device name directory from the
parameters of this function, such as mbim_rx_verify_ndp16(). There is no *mbim or
*ndev or *mhi_dev.
prev parent reply other threads:[~2024-04-27 5:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 9:24 [PATCH net v2] net: wwan: Fix missing net device name for error message print Slark Xiao
2024-04-26 11:33 ` Jiri Pirko
2024-04-26 12:04 ` Loic Poulain
2024-04-27 5:57 ` Slark Xiao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f434e77.2191.18f1e216533.Coremail.slark_xiao@163.com \
--to=slark_xiao@163.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkelam@marvell.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.