From: Denis Kenzior <denkenz@gmail.com>
To: Ram Subramanian <ram.subramanian@getcruise.com>, ell@lists.linux.dev
Subject: Re: [PATCH 2/2] unit: add testing for dbus-over-tcp
Date: Thu, 16 May 2024 14:36:32 -0500 [thread overview]
Message-ID: <80fb1b89-e093-455a-b607-8b0d7400e03c@gmail.com> (raw)
In-Reply-To: <20240513175826.2363352-2-ram.subramanian@getcruise.com>
On 5/13/24 12:58 PM, Ram Subramanian wrote:
> Co-authored-by: Ramon Ribeiro <rhpr@cesar.org.br>
Since the unit test was all yours, I removed this line.
> ---
> unit/dbus.conf | 2 +
> unit/test-dbus.c | 118 +++++++++++++++++++++++++++++++++--------------
> 2 files changed, 85 insertions(+), 35 deletions(-)
>
<snip>
> @@ -135,18 +154,19 @@ static void request_name_callback(struct l_dbus_message *message,
> const char *error, *text;
> uint32_t result;
>
> + req_name_cb_called = true;
> +
> if (l_dbus_message_get_error(message, &error, &text)) {
> l_error("error=%s", error);
> l_error("message=%s", text);
> - goto done;
> + test_assert(false);
> }
>
> - if (!l_dbus_message_get_arguments(message, "u", &result))
> - goto done;
> + test_assert(l_dbus_message_get_arguments(message, "u", &result));
>
> l_info("request name result=%d", result);
>
> -done:
> + tests_completed ++;
I moved this to test_dbus() and fixed up the style (no spaces before ++).
Applied, thanks.
Regards,
-Denis
next prev parent reply other threads:[~2024-05-16 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 17:58 [PATCH 1/2] dbus: add dbus-over-tcp support Ram Subramanian
2024-05-13 17:58 ` [PATCH 2/2] unit: add testing for dbus-over-tcp Ram Subramanian
2024-05-16 19:36 ` Denis Kenzior [this message]
2024-05-16 19:33 ` [PATCH 1/2] dbus: add dbus-over-tcp support Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80fb1b89-e093-455a-b607-8b0d7400e03c@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.linux.dev \
--cc=ram.subramanian@getcruise.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.