* [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_probe()
@ 2017-12-15 18:00 ` SF Markus Elfring
0 siblings, 0 replies; 13+ messages in thread
From: SF Markus Elfring @ 2017-12-15 18:00 UTC (permalink / raw
To: linux-pwm, linux-arm-kernel@lists.infradead.org,
Alexandre Belloni, Nicolas Ferre, Thierry Reding
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 15 Dec 2017 18:55:11 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pwm/pwm-atmel-tcb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c
index acd3ce8ecf3f..4fb1be246c44 100644
--- a/drivers/pwm/pwm-atmel-tcb.c
+++ b/drivers/pwm/pwm-atmel-tcb.c
@@ -401,7 +401,6 @@ static int atmel_tcb_pwm_probe(struct platform_device *pdev)
tcbpwm = devm_kzalloc(&pdev->dev, sizeof(*tcbpwm), GFP_KERNEL);
if (tcbpwm == NULL) {
err = -ENOMEM;
- dev_err(&pdev->dev, "failed to allocate memory\n");
goto err_free_tc;
}
--
2.15.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_probe()
@ 2017-12-15 18:00 ` SF Markus Elfring
0 siblings, 0 replies; 13+ messages in thread
From: SF Markus Elfring @ 2017-12-15 18:00 UTC (permalink / raw
To: linux-arm-kernel
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 15 Dec 2017 18:55:11 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pwm/pwm-atmel-tcb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c
index acd3ce8ecf3f..4fb1be246c44 100644
--- a/drivers/pwm/pwm-atmel-tcb.c
+++ b/drivers/pwm/pwm-atmel-tcb.c
@@ -401,7 +401,6 @@ static int atmel_tcb_pwm_probe(struct platform_device *pdev)
tcbpwm = devm_kzalloc(&pdev->dev, sizeof(*tcbpwm), GFP_KERNEL);
if (tcbpwm == NULL) {
err = -ENOMEM;
- dev_err(&pdev->dev, "failed to allocate memory\n");
goto err_free_tc;
}
--
2.15.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_prob
@ 2017-12-15 18:00 ` SF Markus Elfring
0 siblings, 0 replies; 13+ messages in thread
From: SF Markus Elfring @ 2017-12-15 18:00 UTC (permalink / raw
To: linux-arm-kernel
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 15 Dec 2017 18:55:11 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pwm/pwm-atmel-tcb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c
index acd3ce8ecf3f..4fb1be246c44 100644
--- a/drivers/pwm/pwm-atmel-tcb.c
+++ b/drivers/pwm/pwm-atmel-tcb.c
@@ -401,7 +401,6 @@ static int atmel_tcb_pwm_probe(struct platform_device *pdev)
tcbpwm = devm_kzalloc(&pdev->dev, sizeof(*tcbpwm), GFP_KERNEL);
if (tcbpwm = NULL) {
err = -ENOMEM;
- dev_err(&pdev->dev, "failed to allocate memory\n");
goto err_free_tc;
}
--
2.15.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_probe()
2017-12-15 18:00 ` [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_probe() SF Markus Elfring
(?)
(?)
@ 2017-12-19 14:53 ` Nicolas Ferre
-1 siblings, 0 replies; 13+ messages in thread
From: Nicolas Ferre @ 2017-12-19 14:53 UTC (permalink / raw
To: SF Markus Elfring, linux-pwm,
linux-arm-kernel@lists.infradead.org, Alexandre Belloni,
Thierry Reding
Cc: LKML, kernel-janitors
Hi,
On 15/12/2017 at 19:00, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 15 Dec 2017 18:55:11 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
Can you point which coccinelle script highlited this issue?
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/pwm/pwm-atmel-tcb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c
> index acd3ce8ecf3f..4fb1be246c44 100644
> --- a/drivers/pwm/pwm-atmel-tcb.c
> +++ b/drivers/pwm/pwm-atmel-tcb.c
> @@ -401,7 +401,6 @@ static int atmel_tcb_pwm_probe(struct platform_device *pdev)
> tcbpwm = devm_kzalloc(&pdev->dev, sizeof(*tcbpwm), GFP_KERNEL);
> if (tcbpwm == NULL) {
> err = -ENOMEM;
> - dev_err(&pdev->dev, "failed to allocate memory\n");
We have this in case of error:
atmel-tcb-pwm pwm: failed to allocate memory
atmel-tcb-pwm: probe of pwm failed with error -12
Which is somehow redundant I admit...
> goto err_free_tc;
> }
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_probe()
@ 2017-12-19 14:53 ` Nicolas Ferre
0 siblings, 0 replies; 13+ messages in thread
From: Nicolas Ferre @ 2017-12-19 14:53 UTC (permalink / raw
To: linux-arm-kernel
Hi,
On 15/12/2017 at 19:00, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 15 Dec 2017 18:55:11 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
Can you point which coccinelle script highlited this issue?
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/pwm/pwm-atmel-tcb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c
> index acd3ce8ecf3f..4fb1be246c44 100644
> --- a/drivers/pwm/pwm-atmel-tcb.c
> +++ b/drivers/pwm/pwm-atmel-tcb.c
> @@ -401,7 +401,6 @@ static int atmel_tcb_pwm_probe(struct platform_device *pdev)
> tcbpwm = devm_kzalloc(&pdev->dev, sizeof(*tcbpwm), GFP_KERNEL);
> if (tcbpwm == NULL) {
> err = -ENOMEM;
> - dev_err(&pdev->dev, "failed to allocate memory\n");
We have this in case of error:
atmel-tcb-pwm pwm: failed to allocate memory
atmel-tcb-pwm: probe of pwm failed with error -12
Which is somehow redundant I admit...
> goto err_free_tc;
> }
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_probe()
@ 2017-12-19 14:53 ` Nicolas Ferre
0 siblings, 0 replies; 13+ messages in thread
From: Nicolas Ferre @ 2017-12-19 14:53 UTC (permalink / raw
To: SF Markus Elfring, linux-pwm,
linux-arm-kernel@lists.infradead.org, Alexandre Belloni,
Thierry Reding
Cc: LKML, kernel-janitors
Hi,
On 15/12/2017 at 19:00, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 15 Dec 2017 18:55:11 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
Can you point which coccinelle script highlited this issue?
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/pwm/pwm-atmel-tcb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c
> index acd3ce8ecf3f..4fb1be246c44 100644
> --- a/drivers/pwm/pwm-atmel-tcb.c
> +++ b/drivers/pwm/pwm-atmel-tcb.c
> @@ -401,7 +401,6 @@ static int atmel_tcb_pwm_probe(struct platform_device *pdev)
> tcbpwm = devm_kzalloc(&pdev->dev, sizeof(*tcbpwm), GFP_KERNEL);
> if (tcbpwm == NULL) {
> err = -ENOMEM;
> - dev_err(&pdev->dev, "failed to allocate memory\n");
We have this in case of error:
atmel-tcb-pwm pwm: failed to allocate memory
atmel-tcb-pwm: probe of pwm failed with error -12
Which is somehow redundant I admit...
> goto err_free_tc;
> }
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_
@ 2017-12-19 14:53 ` Nicolas Ferre
0 siblings, 0 replies; 13+ messages in thread
From: Nicolas Ferre @ 2017-12-19 14:53 UTC (permalink / raw
To: linux-arm-kernel
Hi,
On 15/12/2017 at 19:00, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 15 Dec 2017 18:55:11 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
Can you point which coccinelle script highlited this issue?
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/pwm/pwm-atmel-tcb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c
> index acd3ce8ecf3f..4fb1be246c44 100644
> --- a/drivers/pwm/pwm-atmel-tcb.c
> +++ b/drivers/pwm/pwm-atmel-tcb.c
> @@ -401,7 +401,6 @@ static int atmel_tcb_pwm_probe(struct platform_device *pdev)
> tcbpwm = devm_kzalloc(&pdev->dev, sizeof(*tcbpwm), GFP_KERNEL);
> if (tcbpwm = NULL) {
> err = -ENOMEM;
> - dev_err(&pdev->dev, "failed to allocate memory\n");
We have this in case of error:
atmel-tcb-pwm pwm: failed to allocate memory
atmel-tcb-pwm: probe of pwm failed with error -12
Which is somehow redundant I admit...
> goto err_free_tc;
> }
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_probe()
2017-12-19 14:53 ` Nicolas Ferre
(?)
@ 2017-12-19 17:12 ` SF Markus Elfring
-1 siblings, 0 replies; 13+ messages in thread
From: SF Markus Elfring @ 2017-12-19 17:12 UTC (permalink / raw
To: Nicolas Ferre, linux-pwm, linux-arm-kernel
Cc: Alexandre Belloni, Thierry Reding, LKML, kernel-janitors
>> Omit an extra message for a memory allocation failure in this function.
>>
>> This issue was detected by using the Coccinelle software.
>
> Can you point which coccinelle script highlited this issue?
Not directly (so far).
I constructed an approach for the semantic patch language based on
information from the script “checkpatch.pl”.
Would you like to improve it any ways?
Regards,
Markus
^ permalink raw reply [flat|nested] 13+ messages in thread
* pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_probe()
@ 2017-12-19 17:12 ` SF Markus Elfring
0 siblings, 0 replies; 13+ messages in thread
From: SF Markus Elfring @ 2017-12-19 17:12 UTC (permalink / raw
To: linux-arm-kernel
>> Omit an extra message for a memory allocation failure in this function.
>>
>> This issue was detected by using the Coccinelle software.
>
> Can you point which coccinelle script highlited this issue?
Not directly (so far).
I constructed an approach for the semantic patch language based on
information from the script ?checkpatch.pl?.
Would you like to improve it any ways?
Regards,
Markus
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_probe()
@ 2017-12-19 17:12 ` SF Markus Elfring
0 siblings, 0 replies; 13+ messages in thread
From: SF Markus Elfring @ 2017-12-19 17:12 UTC (permalink / raw
To: linux-arm-kernel
>> Omit an extra message for a memory allocation failure in this function.
>>
>> This issue was detected by using the Coccinelle software.
>
> Can you point which coccinelle script highlited this issue?
Not directly (so far).
I constructed an approach for the semantic patch language based on
information from the script “checkpatch.pl”.
Would you like to improve it any ways?
Regards,
Markus
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_probe()
2017-12-15 18:00 ` [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_probe() SF Markus Elfring
(?)
@ 2018-03-27 21:29 ` Thierry Reding
-1 siblings, 0 replies; 13+ messages in thread
From: Thierry Reding @ 2018-03-27 21:29 UTC (permalink / raw
To: SF Markus Elfring
Cc: linux-pwm, linux-arm-kernel@lists.infradead.org,
Alexandre Belloni, Nicolas Ferre, LKML, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
On Fri, Dec 15, 2017 at 07:00:46PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 15 Dec 2017 18:55:11 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/pwm/pwm-atmel-tcb.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_probe()
@ 2018-03-27 21:29 ` Thierry Reding
0 siblings, 0 replies; 13+ messages in thread
From: Thierry Reding @ 2018-03-27 21:29 UTC (permalink / raw
To: linux-arm-kernel
On Fri, Dec 15, 2017 at 07:00:46PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 15 Dec 2017 18:55:11 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/pwm/pwm-atmel-tcb.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180327/4356c3b4/attachment.sig>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_
@ 2018-03-27 21:29 ` Thierry Reding
0 siblings, 0 replies; 13+ messages in thread
From: Thierry Reding @ 2018-03-27 21:29 UTC (permalink / raw
To: linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
On Fri, Dec 15, 2017 at 07:00:46PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 15 Dec 2017 18:55:11 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/pwm/pwm-atmel-tcb.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2018-03-27 21:29 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-15 18:00 [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_probe() SF Markus Elfring
2017-12-15 18:00 ` [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_prob SF Markus Elfring
2017-12-15 18:00 ` [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_probe() SF Markus Elfring
2017-12-19 14:53 ` Nicolas Ferre
2017-12-19 14:53 ` [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_ Nicolas Ferre
2017-12-19 14:53 ` [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_probe() Nicolas Ferre
2017-12-19 14:53 ` Nicolas Ferre
2017-12-19 17:12 ` SF Markus Elfring
2017-12-19 17:12 ` SF Markus Elfring
2017-12-19 17:12 ` SF Markus Elfring
2018-03-27 21:29 ` [PATCH] " Thierry Reding
2018-03-27 21:29 ` [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_ Thierry Reding
2018-03-27 21:29 ` [PATCH] pwm: atmel-tcb: Delete an error message for a failed memory allocation in atmel_tcb_pwm_probe() Thierry Reding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.