* [PATCH v2] ltp: fix rpc build error
@ 2020-12-17 14:07 Kory Maincent
2020-12-17 16:21 ` [OE-core] " Peter Kjellerstedt
2020-12-18 13:36 ` Richard Purdie
0 siblings, 2 replies; 8+ messages in thread
From: Kory Maincent @ 2020-12-17 14:07 UTC (permalink / raw
To: openembedded-core; +Cc: thomas.petazzoni
Add support to tirpc tests build.
Export incdir and libdir to have the right path.
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Change since v1:
- Use PACKAGECONFIG to enable rpc tests
- Improve ${libdir} and ${incdir} export
meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb b/meta/recipes-extended/ltp/ltp_20200930.bb
index 7acf15b360..9da5d90353 100644
--- a/meta/recipes-extended/ltp/ltp_20200930.bb
+++ b/meta/recipes-extended/ltp/ltp_20200930.bb
@@ -42,14 +42,14 @@ inherit autotools-brokensep pkgconfig
TARGET_CC_ARCH += "${LDFLAGS}"
+export libdir := "${exec_prefix}/${baselib}"
+export incdir := "${exec_prefix}/include"
export prefix = "/opt/${PN}"
-export exec_prefix = "/opt/${PN}"
PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"
+PACKAGECONFIG[rpc] = ", --without-tirpc, virtual/librpc,"
EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4"
EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite "
-# ltp network/rpc test cases ftbfs when libtirpc is found
-EXTRA_OECONF += " --without-tirpc "
do_install(){
install -d ${D}${prefix}/
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH v2] ltp: fix rpc build error
2020-12-17 14:07 [PATCH v2] ltp: fix rpc build error Kory Maincent
@ 2020-12-17 16:21 ` Peter Kjellerstedt
2020-12-18 8:52 ` Kory Maincent
2020-12-18 13:36 ` Richard Purdie
1 sibling, 1 reply; 8+ messages in thread
From: Peter Kjellerstedt @ 2020-12-17 16:21 UTC (permalink / raw
To: Kory Maincent, openembedded-core@lists.openembedded.org
Cc: thomas.petazzoni@bootlin.com
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Kory Maincent
> Sent: den 17 december 2020 15:08
> To: openembedded-core@lists.openembedded.org
> Cc: thomas.petazzoni@bootlin.com
> Subject: [OE-core] [PATCH v2] ltp: fix rpc build error
>
> Add support to tirpc tests build.
> Export incdir and libdir to have the right path.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
>
> Change since v1:
> - Use PACKAGECONFIG to enable rpc tests
> - Improve ${libdir} and ${incdir} export
>
>
> meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb b/meta/recipes-
> extended/ltp/ltp_20200930.bb
> index 7acf15b360..9da5d90353 100644
> --- a/meta/recipes-extended/ltp/ltp_20200930.bb
> +++ b/meta/recipes-extended/ltp/ltp_20200930.bb
> @@ -42,14 +42,14 @@ inherit autotools-brokensep pkgconfig
>
> TARGET_CC_ARCH += "${LDFLAGS}"
>
> +export libdir := "${exec_prefix}/${baselib}"
> +export incdir := "${exec_prefix}/include"
This should be a little bit better:
export libdir := "${libdir}"
export incdir := "${incdir}"
> export prefix = "/opt/${PN}"
> -export exec_prefix = "/opt/${PN}"
>
> PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"
> +PACKAGECONFIG[rpc] = ", --without-tirpc, virtual/librpc,"
I assume there is a --with-tirpc as well, so this should be:
PACKAGECONFIG[rpc] = "--with-tirpc, --without-tirpc, virtual/librpc,"
> EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4"
> EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite "
> -# ltp network/rpc test cases ftbfs when libtirpc is found
> -EXTRA_OECONF += " --without-tirpc "
>
> do_install(){
> install -d ${D}${prefix}/
> --
> 2.17.1
//Peter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH v2] ltp: fix rpc build error
2020-12-17 16:21 ` [OE-core] " Peter Kjellerstedt
@ 2020-12-18 8:52 ` Kory Maincent
2020-12-18 12:06 ` Peter Kjellerstedt
0 siblings, 1 reply; 8+ messages in thread
From: Kory Maincent @ 2020-12-18 8:52 UTC (permalink / raw
To: Peter Kjellerstedt
Cc: openembedded-core@lists.openembedded.org,
thomas.petazzoni@bootlin.com
Hello Peter,
On Thu, 17 Dec 2020 16:21:20 +0000
Peter Kjellerstedt <peter.kjellerstedt@axis.com> wrote:
> >
> > TARGET_CC_ARCH += "${LDFLAGS}"
> >
> > +export libdir := "${exec_prefix}/${baselib}"
> > +export incdir := "${exec_prefix}/include"
>
> This should be a little bit better:
>
> export libdir := "${libdir}"
> export incdir := "${incdir}"
Thanks,
I did not notice but it brings an error and I sent a V3 with it.
Your review returns this error:
bb.data_smart.ExpansionError: Failure expanding variable incdir,
expression was ${incdir} which triggered exception Exception: variable incdir
references itself!
Regards,
Köry,
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH v2] ltp: fix rpc build error
2020-12-18 8:52 ` Kory Maincent
@ 2020-12-18 12:06 ` Peter Kjellerstedt
2020-12-18 14:07 ` Kory Maincent
0 siblings, 1 reply; 8+ messages in thread
From: Peter Kjellerstedt @ 2020-12-18 12:06 UTC (permalink / raw
To: Kory Maincent
Cc: openembedded-core@lists.openembedded.org,
thomas.petazzoni@bootlin.com
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Kory Maincent
> Sent: den 18 december 2020 09:52
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Cc: openembedded-core@lists.openembedded.org;
> thomas.petazzoni@bootlin.com
> Subject: Re: [OE-core] [PATCH v2] ltp: fix rpc build error
>
> Hello Peter,
>
> On Thu, 17 Dec 2020 16:21:20 +0000
> Peter Kjellerstedt <peter.kjellerstedt@axis.com> wrote:
>
> > >
> > > TARGET_CC_ARCH += "${LDFLAGS}"
> > >
> > > +export libdir := "${exec_prefix}/${baselib}"
> > > +export incdir := "${exec_prefix}/include"
> >
> > This should be a little bit better:
> >
> > export libdir := "${libdir}"
> > export incdir := "${incdir}"
>
> Thanks,
> I did not notice but it brings an error and I sent a V3 with it.
> Your review returns this error:
> bb.data_smart.ExpansionError: Failure expanding variable incdir,
> expression was ${incdir} which triggered exception Exception: variable
> incdir references itself!
Duh, of course. That is because there is no incdir variable, so
"${incdir}" will expand to "\${incdir}". The real variable is called
includedir.
This of course brings the question whether ltp expects incdir or
includedir, and if it is the latter, then your changes so far have not
made any difference when it comes to includedir, which means they
shouldn't be needed.
>
> Regards,
>
> Köry,
//Peter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH v2] ltp: fix rpc build error
2020-12-17 14:07 [PATCH v2] ltp: fix rpc build error Kory Maincent
2020-12-17 16:21 ` [OE-core] " Peter Kjellerstedt
@ 2020-12-18 13:36 ` Richard Purdie
2020-12-19 11:03 ` Kory Maincent
1 sibling, 1 reply; 8+ messages in thread
From: Richard Purdie @ 2020-12-18 13:36 UTC (permalink / raw
To: Kory Maincent, openembedded-core; +Cc: thomas.petazzoni
On Thu, 2020-12-17 at 15:07 +0100, Kory Maincent wrote:
> Add support to tirpc tests build.
> Export incdir and libdir to have the right path.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
>
> Change since v1:
> - Use PACKAGECONFIG to enable rpc tests
> - Improve ${libdir} and ${incdir} export
>
>
> meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb
> b/meta/recipes-extended/ltp/ltp_20200930.bb
> index 7acf15b360..9da5d90353 100644
> --- a/meta/recipes-extended/ltp/ltp_20200930.bb
> +++ b/meta/recipes-extended/ltp/ltp_20200930.bb
> @@ -42,14 +42,14 @@ inherit autotools-brokensep pkgconfig
>
> TARGET_CC_ARCH += "${LDFLAGS}"
>
> +export libdir := "${exec_prefix}/${baselib}"
> +export incdir := "${exec_prefix}/include"
In general we try and avoid :=, is there a reason its needed here
rather than just "=" ? If so, it might be something that should be
mentioned in the commit message?
Cheers,
Richard
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH v2] ltp: fix rpc build error
2020-12-18 12:06 ` Peter Kjellerstedt
@ 2020-12-18 14:07 ` Kory Maincent
2020-12-18 18:59 ` Peter Kjellerstedt
0 siblings, 1 reply; 8+ messages in thread
From: Kory Maincent @ 2020-12-18 14:07 UTC (permalink / raw
To: Peter Kjellerstedt
Cc: openembedded-core@lists.openembedded.org,
thomas.petazzoni@bootlin.com
On Fri, 18 Dec 2020 12:06:06 +0000
Peter Kjellerstedt <peter.kjellerstedt@axis.com> wrote:
> > I did not notice but it brings an error and I sent a V3 with it.
> > Your review returns this error:
> > bb.data_smart.ExpansionError: Failure expanding variable incdir,
> > expression was ${incdir} which triggered exception Exception: variable
> > incdir references itself!
>
> Duh, of course. That is because there is no incdir variable, so
> "${incdir}" will expand to "\${incdir}". The real variable is called
> includedir.
>
> This of course brings the question whether ltp expects incdir or
> includedir, and if it is the latter, then your changes so far have not
> made any difference when it comes to includedir, which means they
> shouldn't be needed.
Your right it needs only ${libdir}.
In fact, the issue was the recipe could not find tirpc pkgconfig.
I have chosen to export libdir because
PKG_CONFIG_DIR=${STAGING_DIR_HOST}${libdir}/pkgconfig
But maybe it is better to add the path to PKG_CONFIG_PATH?
Regards,
Köry
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH v2] ltp: fix rpc build error
2020-12-18 14:07 ` Kory Maincent
@ 2020-12-18 18:59 ` Peter Kjellerstedt
0 siblings, 0 replies; 8+ messages in thread
From: Peter Kjellerstedt @ 2020-12-18 18:59 UTC (permalink / raw
To: Köry Maincent
Cc: openembedded-core@lists.openembedded.org,
thomas.petazzoni@bootlin.com
> -----Original Message-----
> From: Köry Maincent <kory.maincent@bootlin.com>
> Sent: den 18 december 2020 15:08
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Cc: openembedded-core@lists.openembedded.org;
> thomas.petazzoni@bootlin.com
> Subject: Re: [OE-core] [PATCH v2] ltp: fix rpc build error
>
> On Fri, 18 Dec 2020 12:06:06 +0000
> Peter Kjellerstedt <peter.kjellerstedt@axis.com> wrote:
>
> > > I did not notice but it brings an error and I sent a V3 with it.
> > > Your review returns this error:
> > > bb.data_smart.ExpansionError: Failure expanding variable incdir,
> > > expression was ${incdir} which triggered exception Exception:
> > > variable incdir references itself!
> >
> > Duh, of course. That is because there is no incdir variable, so
> > "${incdir}" will expand to "\${incdir}". The real variable is called
> > includedir.
> >
> > This of course brings the question whether ltp expects incdir or
> > includedir, and if it is the latter, then your changes so far have not
> > made any difference when it comes to includedir, which means they
> > shouldn't be needed.
>
> Your right it needs only ${libdir}.
> In fact, the issue was the recipe could not find tirpc pkgconfig.
> I have chosen to export libdir because
> PKG_CONFIG_DIR=${STAGING_DIR_HOST}${libdir}/pkgconfig
> But maybe it is better to add the path to PKG_CONFIG_PATH?
If that is the only reason for the exported libdir, then I agree, it is
better to add:
PKG_CONFIG_PATH .= ":${STAGING_DIR_HOST}${exec_prefix}/${baselib}/pkgconfig"
Preferably with a comment explaining why it is being done.
> Regards,
>
> Köry
//Peter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH v2] ltp: fix rpc build error
2020-12-18 13:36 ` Richard Purdie
@ 2020-12-19 11:03 ` Kory Maincent
0 siblings, 0 replies; 8+ messages in thread
From: Kory Maincent @ 2020-12-19 11:03 UTC (permalink / raw
To: Richard Purdie; +Cc: openembedded-core, thomas.petazzoni
On Fri, 18 Dec 2020 13:36:10 +0000
Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> > @@ -42,14 +42,14 @@ inherit autotools-brokensep pkgconfig
> >
> > TARGET_CC_ARCH += "${LDFLAGS}"
> >
> > +export libdir := "${exec_prefix}/${baselib}"
> > +export incdir := "${exec_prefix}/include"
>
> In general we try and avoid :=, is there a reason its needed here
> rather than just "=" ? If so, it might be something that should be
> mentioned in the commit message?
Ok, the point was to avoid these ${incdir} and ${libdir} get modified by the
"export ${prefix}". In fact, I need to do it only with the PKG_CONFIG_PATH
variable. Yes, I will mention it.
Regards,
Köry
>
> Cheers,
> Richard
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-12-19 11:03 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-17 14:07 [PATCH v2] ltp: fix rpc build error Kory Maincent
2020-12-17 16:21 ` [OE-core] " Peter Kjellerstedt
2020-12-18 8:52 ` Kory Maincent
2020-12-18 12:06 ` Peter Kjellerstedt
2020-12-18 14:07 ` Kory Maincent
2020-12-18 18:59 ` Peter Kjellerstedt
2020-12-18 13:36 ` Richard Purdie
2020-12-19 11:03 ` Kory Maincent
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.