From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH RFCv2 3/4] staging: etnaviv: add drm driver
Date: Wed, 16 Sep 2015 11:05:11 -0400
Message-ID: <871tdy2ymw.fsf@eliezer.anholt.net>
References: <1441980614-19216-1-git-send-email-l.stach@pengutronix.de>
 <1441980614-19216-4-git-send-email-l.stach@pengutronix.de>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0967603314=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <1441980614-19216-4-git-send-email-l.stach@pengutronix.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Lucas Stach <l.stach@pengutronix.de>, dri-devel@lists.freedesktop.org
Cc: Russell King <linux@arm.linux.org.uk>, kernel@pengutronix.de
List-Id: dri-devel@lists.freedesktop.org

--===============0967603314==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain

Lucas Stach <l.stach@pengutronix.de> writes:

> From: Christian Gmeiner <christian.gmeiner@gmail.com>

> +static bool etnaviv_validate_load_state(struct etnaviv_gpu *gpu, u32 *buf,
> +	unsigned int state, unsigned int num)
> +{
> +	return true;
> +	if (0x1200 - state < num * 4)
> +		return false;
> +	if (0x1228 - state < num * 4)
> +		return false;
> +	if (0x1238 - state < num * 4)
> +		return false;
> +	if (0x1284 - state < num * 4)
> +		return false;
> +	if (0x128c - state < num * 4)
> +		return false;
> +	if (0x1304 - state < num * 4)
> +		return false;
> +	if (0x1310 - state < num * 4)
> +		return false;
> +	if (0x1318 - state < num * 4)
> +		return false;
> +	if (0x1280c - state < num * 4 + 0x0c)
> +		return false;
> +	if (0x128ac - state < num * 4 + 0x0c)
> +		return false;
> +	if (0x128cc - state < num * 4 + 0x0c)
> +		return false;
> +	if (0x1297c - state < num * 4 + 0x0c)
> +		return false;
> +	return true;
> +}

I was browsing the code, and noticed that it looks like you've got a
debugging early return in your validation function here.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJV+YUoAAoJELXWKTbR/J7or0wQAIKgXSnfzSkTLtpTX0jBYY3s
Tgm4aGll0aUfQBsuoW6U2ld4CAzlDVmXme3FIcs8rkCsKfYgjIOH25boeC54JX1D
w7V8kpqtgm/VUxNCOyop13pzQjg8qT2ii2EsqF4138sdiIxQmFmII1mkpR2ysWrh
yDjUSMYYdQlGjsO4Nr1F+rYh+yPUgSdrIP7uMJx5Jtl/dVA+ZeTsEr+ZHVy6iBrB
IO8Z0gYRnGylCUqU/4Sxr+yxEYCDe3bUOejat7hEtmqJLeSDLR82WmiY/r+4/VHO
76oSSZF2OPTvGKU6RXoWTM6i2ML3o0ZvRDjqQFSX1OFI3nvx19+WgzTSlpRXER6Z
rjhh3McTdy2o3sEtpzv216g8HjNRmeQHgOeqYoHEyzoddfa3d4bNUqUQzEwIYvTG
ctPkTDkQ8hlyC7OCH4GFBMbY1HH8Hvh5hNFD7CsogbnW4ao+v+pG3B5xuToMTiaM
OAEmF0S9OukFew/TYJNur35FznBZMF6XvKewpwfoEvuPLH9Sdyl9M1ARsPq0mnum
FRSOt57fwcKkaYCc2+UEgdTE6YrKAnfGjtNnfcPjmSWBGkTvXXV5b/qJ549xeXRn
f0wHoa5rB2RdXQYWCgoON+Bgxnw3+HTfOtB/d/9nES02sTzzQwMX3XOrzk/CLf+J
fgvSC1tuRqQBF1BMI3zB
=kYV+
-----END PGP SIGNATURE-----
--=-=-=--

--===============0967603314==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK

--===============0967603314==--