* [Buildroot] [PATCH 1/1] package/sdbusplus: needs C++17
@ 2020-03-26 20:38 Fabrice Fontaine
2020-03-26 21:01 ` John Faith
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2020-03-26 20:38 UTC (permalink / raw
To: buildroot
sdbusplus needs C++17 since
https://github.com/openbmc/sdbusplus/commit/ca46b9d2e958d1e4b392265f656f782899c2de1d
This is not needed for host-sdbusplus as libsdbusplus is disabled on
host through --disable-libsdbusplus
Fixes:
- http://autobuild.buildroot.org/results/65a4652e5b419f03ace109c4b3738e9b997cdabe
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/sdbusplus/Config.in | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/sdbusplus/Config.in b/package/sdbusplus/Config.in
index e278d17156..c66203c463 100644
--- a/package/sdbusplus/Config.in
+++ b/package/sdbusplus/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_SDBUSPLUS
bool "sdbusplus"
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_PACKAGE_SYSTEMD
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17
help
A C++ library for sd-bus with a bindings and doc generator.
@@ -10,5 +11,6 @@ config BR2_PACKAGE_SDBUSPLUS
https://github.com/openbmc/sdbusplus
-comment "sdbusplus needs systemd and a toolchain w/ C++"
- depends on !BR2_PACKAGE_SYSTEMD || !BR2_INSTALL_LIBSTDCPP
+comment "sdbusplus needs systemd and a toolchain w/ C++, gcc >= 7"
+ depends on !BR2_PACKAGE_SYSTEMD || !BR2_INSTALL_LIBSTDCPP || \
+ !BR2_TOOLCHAIN_GCC_AT_LEAST_7
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/sdbusplus: needs C++17
2020-03-26 20:38 [Buildroot] [PATCH 1/1] package/sdbusplus: needs C++17 Fabrice Fontaine
@ 2020-03-26 21:01 ` John Faith
2020-03-26 22:04 ` Thomas Petazzoni
2020-04-07 18:25 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: John Faith @ 2020-03-26 21:01 UTC (permalink / raw
To: buildroot
> From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Sent: Thursday, March 26, 2020 1:38 PM
> To: buildroot at buildroot.org <buildroot@buildroot.org>
> Cc: John Faith <jfaith@impinj.com>; Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Subject: [PATCH 1/1] package/sdbusplus: needs C++17
>
> sdbusplus needs C++17 since
> https://github.com/openbmc/sdbusplus/commit/ca46b9d2e958d1e4b392265f656f782899c2de1d
>
> This is not needed for host-sdbusplus as libsdbusplus is disabled on
> host through --disable-libsdbusplus
>
> Fixes:
> -
> http://autobuild.buildroot.org/results/65a4652e5b419f03ace109c4b3738e9b997cdabe
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Reviewed-by: John Faith <jfaith@impinj.com>
Thanks for fixing this!
,
John
> ---
> package/sdbusplus/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/sdbusplus/Config.in b/package/sdbusplus/Config.in
> index e278d17156..c66203c463 100644
> --- a/package/sdbusplus/Config.in
> +++ b/package/sdbusplus/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_SDBUSPLUS
> bool "sdbusplus"
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_PACKAGE_SYSTEMD
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17
> help
> A C++ library for sd-bus with a bindings and doc generator.
>
> @@ -10,5 +11,6 @@ config BR2_PACKAGE_SDBUSPLUS
>
> https://github.com/openbmc/sdbusplus
>
> -comment "sdbusplus needs systemd and a toolchain w/ C++"
> - depends on !BR2_PACKAGE_SYSTEMD || !BR2_INSTALL_LIBSTDCPP
> +comment "sdbusplus needs systemd and a toolchain w/ C++, gcc >= 7"
> + depends on !BR2_PACKAGE_SYSTEMD || !BR2_INSTALL_LIBSTDCPP || \
> + !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> --
> 2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/sdbusplus: needs C++17
2020-03-26 20:38 [Buildroot] [PATCH 1/1] package/sdbusplus: needs C++17 Fabrice Fontaine
2020-03-26 21:01 ` John Faith
@ 2020-03-26 22:04 ` Thomas Petazzoni
2020-04-07 18:25 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2020-03-26 22:04 UTC (permalink / raw
To: buildroot
On Thu, 26 Mar 2020 21:38:20 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> sdbusplus needs C++17 since
> https://github.com/openbmc/sdbusplus/commit/ca46b9d2e958d1e4b392265f656f782899c2de1d
>
> This is not needed for host-sdbusplus as libsdbusplus is disabled on
> host through --disable-libsdbusplus
>
> Fixes:
> - http://autobuild.buildroot.org/results/65a4652e5b419f03ace109c4b3738e9b997cdabe
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/sdbusplus/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/sdbusplus: needs C++17
2020-03-26 20:38 [Buildroot] [PATCH 1/1] package/sdbusplus: needs C++17 Fabrice Fontaine
2020-03-26 21:01 ` John Faith
2020-03-26 22:04 ` Thomas Petazzoni
@ 2020-04-07 18:25 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2020-04-07 18:25 UTC (permalink / raw
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> sdbusplus needs C++17 since
> https://github.com/openbmc/sdbusplus/commit/ca46b9d2e958d1e4b392265f656f782899c2de1d
> This is not needed for host-sdbusplus as libsdbusplus is disabled on
> host through --disable-libsdbusplus
> Fixes:
> - http://autobuild.buildroot.org/results/65a4652e5b419f03ace109c4b3738e9b997cdabe
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2020.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-07 18:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-26 20:38 [Buildroot] [PATCH 1/1] package/sdbusplus: needs C++17 Fabrice Fontaine
2020-03-26 21:01 ` John Faith
2020-03-26 22:04 ` Thomas Petazzoni
2020-04-07 18:25 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.