Re: [PATCH] drm/i915: CABC support for backlight control

From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Deepak, M" <m.deepak@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: CABC support for backlight control
Date: Tue, 15 Sep 2015 10:03:55 +0300	[thread overview]
Message-ID: <878u88jh9g.fsf@intel.com> (raw)
In-Reply-To: <FA3CAD94929FEF4DA47A7BF98D8EC0F510D171D7@BGSMSX104.gar.corp.intel.com>

On Mon, 14 Sep 2015, "Deepak, M" <m.deepak@intel.com> wrote:
>>-----Original Message-----
>>From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
>>Sent: Monday, September 14, 2015 5:51 PM
>>To: Deepak, M; intel-gfx@lists.freedesktop.org
>>Cc: Deepak, M
>>Subject: Re: [Intel-gfx] [PATCH] drm/i915: CABC support for backlight control
>>
>>On Mon, 14 Sep 2015, Deepak M <m.deepak@intel.com> wrote:
>>> diff --git a/include/video/mipi_display.h
>>> b/include/video/mipi_display.h index ddcc8ca..5b8eeec 100644
>>> --- a/include/video/mipi_display.h
>>> +++ b/include/video/mipi_display.h
>>> @@ -117,6 +117,14 @@ enum {
>>>  	MIPI_DCS_GET_SCANLINE		= 0x45,
>>>  	MIPI_DCS_READ_DDB_START		= 0xA1,
>>>  	MIPI_DCS_READ_DDB_CONTINUE	= 0xA8,
>>> +	MIPI_DCS_CABC_LEVEL_RD          = 0x52,
>>> +	MIPI_DCS_CABC_MIN_BRIGHTNESS_RD = 0x5F,
>>> +	MIPI_DCS_CABC_CONTROL_RD        = 0x56,
>>> +	MIPI_DCS_CABC_CONTROL_BRIGHT_RD = 0x54,
>>> +	MIPI_DCS_CABC_LEVEL_WR          = 0x51,
>>> +	MIPI_DCS_CABC_MIN_BRIGHTNESS_WR = 0x5E,
>>> +	MIPI_DCS_CABC_CONTROL_WR        = 0x55,
>>> +	MIPI_DCS_CABC_CONTROL_BRIGHT_WR = 0x53,
>>
>>These changes need to be a separate patch. And what's the spec reference, I
>>can't find these.
>>
> [Deepak M] The HLD can be found in the link https://securewiki.ith.intel.com/display/GfxDisplay/MIPI+Display (it is under Intel firewall)

If you want to add stuff to include/video/mipi_display.h it has to be
standard DCS commands, in actual MIPI issued specs, not something
internal to us.

Manufacturer specific commands (usually referred to as MCS) need to be
hidden in manufacturer specific files in the driver.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx