From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80092C433B4 for ; Thu, 13 May 2021 14:18:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE0776142C for ; Thu, 13 May 2021 14:18:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE0776142C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhCAp-0007Ld-09 for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 10:18:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhC97-0005mM-Q3 for qemu-devel@nongnu.org; Thu, 13 May 2021 10:17:03 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:46602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhC8x-0002u9-Iy for qemu-devel@nongnu.org; Thu, 13 May 2021 10:16:59 -0400 Received: by mail-wm1-x32f.google.com with SMTP id p14-20020a05600c358eb029015c01f207d7so4721228wmq.5 for ; Thu, 13 May 2021 07:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=O0KtU/ntbmIwYWih2FrovVTaY7CG2uh/OSjBKvrV+FQ=; b=GCLkBydEkas+coH1MJJFGjjWnOAYaiBeGXG1WgZzx7Cb6ytV5twP6X+pE9fD51V8Ai OoXBFFRwqF9DlGP3a17OQr4vo76txwilrVpBkiNAPtBuApF00CWzIDUgnne2f0BF/IUe /4mgl7X/LeG3//SZF82/Uc7C9UKs5yRxLVXqtEeIjflyLH4FEVCm/eY8aqq+EKKi/te/ S4Y4Kwo1aIcg8biLRFsnUsiKrSbCWOFdaVls2RKQlCSGz7jGZLJ3mnyNqDIThIhb5ugY PrNnTo74wU/Xt6WFE4NPvFy1V2HJVZ37mpe7/IgAwS21OjxiB58qdFEcWJJKFTI3yCqj P9Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=O0KtU/ntbmIwYWih2FrovVTaY7CG2uh/OSjBKvrV+FQ=; b=hFX4UVXv0zk9MINDvhxkn1tugPTjYI3WS1seV0qndPsQWxPmDYJcEI8u84npZg+slp I1jbYCucievlChefeZ0GCyZheMvqnDk/lZzC5EeOEBa3havgrgwS9XmECmtASLUu61KL rxriBaTZTwwg6GzbwIG0nI6FDF3EjGZiZGgF+9RR//TvkiL+VJZUKsojJDhcZ79HEUkK wcQFDwTwO83pjmkbl1bAy1mUA5EOaA7Z/TDspOcjDYMUhOmyhMm8ryf/LsfNuD2kRazb 6Psc8WtrrWWyLml/dqsEbQY6P2NG77iWt1j7RbdpGJW/Sw8Ca3CSXuTOmY/QnrPH+exV cSiw== X-Gm-Message-State: AOAM533u1ehTq+EjAoPiaaP82nGM3MLVZnJdDWPGy+IRHqyC0tq2hE/h OATBBIAXuI0nPbA/V9+QUcbdOA== X-Google-Smtp-Source: ABdhPJx2sHPDyCC9EAvZwvL6yuUjQYSLhSxb38zPvDgB78RkP6nZYC6874gqS7DX2JaCyUJeRM9IRA== X-Received: by 2002:a7b:c93a:: with SMTP id h26mr4083945wml.107.1620915405456; Thu, 13 May 2021 07:16:45 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id l18sm2949721wrx.96.2021.05.13.07.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 07:16:44 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 14F6A1FF7E; Thu, 13 May 2021 15:16:44 +0100 (BST) References: <20210508014802.892561-1-richard.henderson@linaro.org> User-agent: mu4e 1.5.13; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Richard Henderson Subject: Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts Date: Thu, 13 May 2021 15:13:45 +0100 In-reply-to: <20210508014802.892561-1-richard.henderson@linaro.org> Message-ID: <87cztulnw3.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, david@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Richard Henderson writes: > Reorg everything using QEMU_GENERIC and multiple inclusion to > reduce the amount of code duplication between the formats. > > The use of QEMU_GENERIC means that we need to use pointers instead > of structures, which means that even the smaller float formats > need rearranging. > > I've carried it through to completion within fpu/, so that we don't > have (much) of the legacy code remaining. There is some floatx80 > stuff in target/m68k and target/i386 that's still hanging around. I'm going to take a break from reviewing this now I've been through about 2/3rds of the patches. Overall I think the series is in great shape and while the performance modulations are interesting they are not a blocker from my point of view. I'll happily take a small hit to performance for a more unified (and correct!) code base. However the frontend maintainers for those affected may take a different view. --=20 Alex Benn=C3=A9e