From mboxrd@z Thu Jan 1 00:00:00 1970 From: robert.jarzmik@free.fr (Robert Jarzmik) Date: Fri, 03 Jul 2015 17:27:25 +0200 Subject: [PATCH-V2 04/12] i2c: pxa: Reset i2c controller on timeout in interrupt and pio mode References: <1434383399-2370-1-git-send-email-vaibhav.hiremath@linaro.org> <1434383399-2370-5-git-send-email-vaibhav.hiremath@linaro.org> Message-ID: <87fv55clcy.fsf@belgarion.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Vaibhav Hiremath writes: > In case of timeout during msg xfer assert reset to > i2c controller for both interrupt and PIO mode of operation. > > Signed-off-by: Jett.Zhou > [vaibhav.hiremath at linaro.org: Split & merge patches into logical changes > and update the Changelog] > Signed-off-by: Vaibhav Hiremath I already said it previously, I'm against an unconditional reset in a timeout path. Make it a quirk or whatever, but in the current status, I'm against. The previous behavior looks correct to me : upon timeout, retry, no need to reset. -- Robert From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH-V2 04/12] i2c: pxa: Reset i2c controller on timeout in interrupt and pio mode Date: Fri, 03 Jul 2015 17:27:25 +0200 Message-ID: <87fv55clcy.fsf@belgarion.home> References: <1434383399-2370-1-git-send-email-vaibhav.hiremath@linaro.org> <1434383399-2370-5-git-send-email-vaibhav.hiremath@linaro.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vaibhav Hiremath Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org, "Jett.Zhou" List-Id: linux-i2c@vger.kernel.org Vaibhav Hiremath writes: > In case of timeout during msg xfer assert reset to > i2c controller for both interrupt and PIO mode of operation. > > Signed-off-by: Jett.Zhou > [vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org: Split & merge patches into logical changes > and update the Changelog] > Signed-off-by: Vaibhav Hiremath I already said it previously, I'm against an unconditional reset in a timeout path. Make it a quirk or whatever, but in the current status, I'm against. The previous behavior looks correct to me : upon timeout, retry, no need to reset. -- Robert