From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD68C48BE5 for ; Wed, 16 Jun 2021 13:53:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77BE061241 for ; Wed, 16 Jun 2021 13:53:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77BE061241 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltVyn-0002pY-Ck for qemu-devel@archiver.kernel.org; Wed, 16 Jun 2021 09:53:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltVy0-0001nx-Hn for qemu-devel@nongnu.org; Wed, 16 Jun 2021 09:52:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltVxy-0008QC-Ku for qemu-devel@nongnu.org; Wed, 16 Jun 2021 09:52:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623851545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mYa6URlpkHwsxYa7n+kM0sLT5oMPI/cpeHgKFa4p5qw=; b=Vq2ZP3byUqBZ+2aI4+u5YLliaC8STFHU9Q94ambu3jpuouyfmfXWaN+f74SdFyS8hrtpUy W9XN4La68SJyYMjE45yZn3YW1SMu05s9B0dXFdwb+f2AM/mTIJ5o5xO82DqnnjGhjT98dZ JXL5hQP1uvjaXFC62fKpHIJ/A9CZyIo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-272-ulYWyIexNbi_9yRWpbMUAw-1; Wed, 16 Jun 2021 09:52:22 -0400 X-MC-Unique: ulYWyIexNbi_9yRWpbMUAw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BDA04180D500; Wed, 16 Jun 2021 13:52:20 +0000 (UTC) Received: from localhost (ovpn-113-141.ams2.redhat.com [10.36.113.141]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 303C460BF1; Wed, 16 Jun 2021 13:52:12 +0000 (UTC) From: Cornelia Huck To: Eric Farman , qemu-devel@nongnu.org, qemu-s390x@nongnu.org Subject: Re: [PATCH v3 1/4] s390x/css: Introduce an ESW struct In-Reply-To: <8ec2adadaf29777bfd6b703fe1943867709511b8.camel@linux.ibm.com> Organization: Red Hat GmbH References: <20210616014749.2460133-1-farman@linux.ibm.com> <20210616014749.2460133-2-farman@linux.ibm.com> <87r1h2w39y.fsf@redhat.com> <8ec2adadaf29777bfd6b703fe1943867709511b8.camel@linux.ibm.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Wed, 16 Jun 2021 15:52:09 +0200 Message-ID: <87im2dx6gm.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.133.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Matthew Rosato , David Hildenbrand , Richard Henderson , Halil Pasic , Christian Borntraeger , Alex Williamson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jun 16 2021, Eric Farman wrote: > On Wed, 2021-06-16 at 11:46 +0200, Cornelia Huck wrote: >> On Wed, Jun 16 2021, Eric Farman wrote: >> >> > The Interrupt Response Block is comprised of several other >> > structures concatenated together, but only the 12-byte >> > Subchannel-Status Word (SCSW) is defined as a proper struct. >> > Everything else is a simple array of 32-bit words. >> > >> > Let's define a proper struct for the 20-byte Extended-Status >> > Word (ESW) so that we can make good decisions about the sense >> > data that would go into the ECW area for virtual vs >> > passthrough devices. >> > >> > Signed-off-by: Eric Farman >> > --- >> > hw/s390x/css.c | 19 +++++++++++++------ >> > include/hw/s390x/ioinst.h | 12 +++++++++++- >> > 2 files changed, 24 insertions(+), 7 deletions(-) >> > >> >> (...) >> >> > diff --git a/include/hw/s390x/ioinst.h b/include/hw/s390x/ioinst.h >> > index c6737a30d4..9613e0ccbb 100644 >> > --- a/include/hw/s390x/ioinst.h >> > +++ b/include/hw/s390x/ioinst.h >> > @@ -123,10 +123,20 @@ typedef struct SCHIB { >> > uint8_t mda[4]; >> > } QEMU_PACKED SCHIB; >> > >> > +/* extended-status word */ >> > +typedef struct ESW { >> > + uint32_t sublog; >> > + uint32_t erw; >> > + uint64_t f_addr; >> > + uint32_t s_addr; >> > +} QEMU_PACKED ESW; >> >> Strictly speaking, that's a format 0 esw. > > True. I thought I put that in there, but I guess not. I can make a > clarification. A short comment would be fine. > >> Doesn't matter too much in the >> end, I think: >> - erw is always the same >> - f_addr and s_addr are always 0 for the other formats >> - 'sublog' is always a u32 with the lpum in the same place (which we >> always set to 0x80 for virtual subchannels, as they have only one >> path) >> > > Yeah, I didn't want to get into the different formats' word 0. Since > the lpum is common to all, what if I just rename 'sublog' to 'word0' > and add some comments for f_addr and s_addr as only being applicable to > Format 0? Works for me. > >> > + >> > +#define ESW_ERW_SENSE 0x01000000 >> > + >> > /* interruption response block */ >> > typedef struct IRB { >> > SCSW scsw; >> > - uint32_t esw[5]; >> > + ESW esw; >> > uint32_t ecw[8]; >> > uint32_t emw[8]; >> > } IRB;