From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752407AbbGKGIO (ORCPT ); Sat, 11 Jul 2015 02:08:14 -0400 Received: from gabe.freedesktop.org ([131.252.210.177]:58507 "EHLO gabe.freedesktop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737AbbGKGHw (ORCPT ); Sat, 11 Jul 2015 02:07:52 -0400 From: Eric Anholt To: Stephen Warren Cc: linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , devicetree@vger.kernel.org, Thomas Gleixner , Jason Cooper Subject: Re: [PATCH 3/4] irqchip: Add documentation for the bcm2836 interrupt controller. In-Reply-To: <55A0A251.1010301@wwwdotorg.org> References: <1436303617-17185-1-git-send-email-eric@anholt.net> <1436303617-17185-4-git-send-email-eric@anholt.net> <55A0A251.1010301@wwwdotorg.org> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 10 Jul 2015 23:01:01 -0700 Message-ID: <87io9r9qsi.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Stephen Warren writes: > On 07/07/2015 03:13 PM, Eric Anholt wrote: >> This is a new per-cpu root interrupt controller on the Raspberry Pi 2, >> which will chain to the bcm2835 interrupt controller for peripheral >> interrupts. > >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt > >> +local_intc: local_intc { > >> + interrupt-parent = <&local_intc>; > > I think that property shouldn't be there? If you don't have it there, the core finds the interrupt-parent in the parent node, and waits for that one before initializing (which is in turn waiting for us). Note that for original 2835, you're finding the parent node as well. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJVoLEdAAoJELXWKTbR/J7ohTwP/RlmPgFsUsmc6bTsBL6b+A70 atiu0FQN0QHW0TkplPkuQPoUjpnnDaeaRcjtf3TTUWij5pjxm2KAIyloyAfmrnbi H8W4L6BeWI9KRx8oZLwpkfsyPhyW/rkWerSGdycNJ+nJbs42smGGOkRMkcW9QG/D 4lOxhf+nKOYbmLNuWI6TUBsCwgOQHyg1FDhuRwk/IpHplSzeL376aGQjxMCsgfQV CmB9r79BLA1bGVv5R92hZtRt//Gp49D3d4MQJjHNxXfYjJdSzkJ4GSPvBl6Zzulw S0IDHGNuwfkVgn6+5v2i6jJi3lAQ7LpqCCDvwZJbJqnqEezwB6uU2PinCfK0GU1I HD3D4Bc48kJkmq+2etwMPPZoIFnUt3zR2kBVCJDB9auV+onZ5Fudv0W2Hdk9BRSf cwUk7q7m1wwtTJvkrETcRypX1CS1bmiezyUNLTiVUH2vMrHwZvY9DyxO/FBnkgfG qrn23zITenqLlRENYLndfN3M3OJR/lY8lQ4+CJkcv7Am1UemqCDgL6snDhnibJgC uRso14wMVarDT9ilAz7K70+5GpMSjs7JCmix65dhS5XZAjgznCwofa6AcyFGOTVA yHhy2tagBOMpB0LlaBFv+tRqetfgG5yVkQKQVHTGPETW4ul7DiAlFQut7ksS9VFS pKulzcjqiSZsW5ogNOL9 =Kqco -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 3/4] irqchip: Add documentation for the bcm2836 interrupt controller. Date: Fri, 10 Jul 2015 23:01:01 -0700 Message-ID: <87io9r9qsi.fsf@eliezer.anholt.net> References: <1436303617-17185-1-git-send-email-eric@anholt.net> <1436303617-17185-4-git-send-email-eric@anholt.net> <55A0A251.1010301@wwwdotorg.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7550412885018942103==" Return-path: In-Reply-To: <55A0A251.1010301@wwwdotorg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Stephen Warren Cc: devicetree@vger.kernel.org, Jason Cooper , Lee Jones , linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org --===============7550412885018942103== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Stephen Warren writes: > On 07/07/2015 03:13 PM, Eric Anholt wrote: >> This is a new per-cpu root interrupt controller on the Raspberry Pi 2, >> which will chain to the bcm2835 interrupt controller for peripheral >> interrupts. > >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt > >> +local_intc: local_intc { > >> + interrupt-parent = <&local_intc>; > > I think that property shouldn't be there? If you don't have it there, the core finds the interrupt-parent in the parent node, and waits for that one before initializing (which is in turn waiting for us). Note that for original 2835, you're finding the parent node as well. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJVoLEdAAoJELXWKTbR/J7ohTwP/RlmPgFsUsmc6bTsBL6b+A70 atiu0FQN0QHW0TkplPkuQPoUjpnnDaeaRcjtf3TTUWij5pjxm2KAIyloyAfmrnbi H8W4L6BeWI9KRx8oZLwpkfsyPhyW/rkWerSGdycNJ+nJbs42smGGOkRMkcW9QG/D 4lOxhf+nKOYbmLNuWI6TUBsCwgOQHyg1FDhuRwk/IpHplSzeL376aGQjxMCsgfQV CmB9r79BLA1bGVv5R92hZtRt//Gp49D3d4MQJjHNxXfYjJdSzkJ4GSPvBl6Zzulw S0IDHGNuwfkVgn6+5v2i6jJi3lAQ7LpqCCDvwZJbJqnqEezwB6uU2PinCfK0GU1I HD3D4Bc48kJkmq+2etwMPPZoIFnUt3zR2kBVCJDB9auV+onZ5Fudv0W2Hdk9BRSf cwUk7q7m1wwtTJvkrETcRypX1CS1bmiezyUNLTiVUH2vMrHwZvY9DyxO/FBnkgfG qrn23zITenqLlRENYLndfN3M3OJR/lY8lQ4+CJkcv7Am1UemqCDgL6snDhnibJgC uRso14wMVarDT9ilAz7K70+5GpMSjs7JCmix65dhS5XZAjgznCwofa6AcyFGOTVA yHhy2tagBOMpB0LlaBFv+tRqetfgG5yVkQKQVHTGPETW4ul7DiAlFQut7ksS9VFS pKulzcjqiSZsW5ogNOL9 =Kqco -----END PGP SIGNATURE----- --=-=-=-- --===============7550412885018942103== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7550412885018942103==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: eric@anholt.net (Eric Anholt) Date: Fri, 10 Jul 2015 23:01:01 -0700 Subject: [PATCH 3/4] irqchip: Add documentation for the bcm2836 interrupt controller. In-Reply-To: <55A0A251.1010301@wwwdotorg.org> References: <1436303617-17185-1-git-send-email-eric@anholt.net> <1436303617-17185-4-git-send-email-eric@anholt.net> <55A0A251.1010301@wwwdotorg.org> Message-ID: <87io9r9qsi.fsf@eliezer.anholt.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Stephen Warren writes: > On 07/07/2015 03:13 PM, Eric Anholt wrote: >> This is a new per-cpu root interrupt controller on the Raspberry Pi 2, >> which will chain to the bcm2835 interrupt controller for peripheral >> interrupts. > >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt > >> +local_intc: local_intc { > >> + interrupt-parent = <&local_intc>; > > I think that property shouldn't be there? If you don't have it there, the core finds the interrupt-parent in the parent node, and waits for that one before initializing (which is in turn waiting for us). Note that for original 2835, you're finding the parent node as well. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 818 bytes Desc: not available URL: