From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BDBCC2B9F4 for ; Thu, 17 Jun 2021 13:08:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DAAC613CB for ; Thu, 17 Jun 2021 13:08:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232200AbhFQNKp convert rfc822-to-8bit (ORCPT ); Thu, 17 Jun 2021 09:10:45 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:33343 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230137AbhFQNKo (ORCPT ); Thu, 17 Jun 2021 09:10:44 -0400 Received: (Authenticated sender: gregory.clement@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 84A68240009; Thu, 17 Jun 2021 13:08:34 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Andrew Lunn Cc: Marek =?utf-8?Q?Beh=C3=BAn?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 mvebu + mvebu/dt64 2/2] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file In-Reply-To: <20210520113844.32319-3-pali@kernel.org> References: <20210308153703.23097-1-kabel@kernel.org> <20210520113844.32319-1-pali@kernel.org> <20210520113844.32319-3-pali@kernel.org> Date: Thu, 17 Jun 2021 15:08:34 +0200 Message-ID: <87mtro1vvx.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, > Move the turris-mox-rwtm firmware node from Turris MOX' device tree into > the generic armada-37xx.dtsi file and use the generic compatible string > 'marvell,armada-3700-rwtm-firmware' instead of the current one. > > Turris MOX DTS file contains also old compatible string for backward > compatibility. > > The Turris MOX rWTM firmware can be used on any Armada 37xx device, > giving them access to the rWTM hardware random number generator, which > is otherwise unavailable. > > This change allows Linux to load the turris-mox-rwtm.ko module on these > boards. > > Tested on ESPRESSObin v5 with both default Marvell WTMI firmware and > CZ.NIC's firmware. With default WTMI firmware the turris-mox-rwtm fails > to probe, while with CZ.NIC's firmware it registers the HW random number > generator. > > Signed-off-by: Pali Rohár > Signed-off-by: Marek Behún > Cc: # 5.4+: 46d2f6d0c99f ("arm64: dts: armada-3720-turris-mox: add firmware node") Applied on mvebu/dt64 (I removed the Fixes line) Thanks, Gregory > --- > arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 6 ++---- > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 8 ++++++++ > 2 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > index 0753cc489638..6700f2212b61 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > @@ -109,10 +109,8 @@ > }; > > firmware { > - turris-mox-rwtm { > - compatible = "cznic,turris-mox-rwtm"; > - mboxes = <&rwtm 0>; > - status = "okay"; > + armada-3700-rwtm { > + compatible = "marvell,armada-3700-rwtm-firmware", "cznic,turris-mox-rwtm"; > }; > }; > }; > diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > index 1b7f43e27589..847a2d12a4be 100644 > --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > @@ -505,4 +505,12 @@ > }; > }; > }; > + > + firmware { > + armada-3700-rwtm { > + compatible = "marvell,armada-3700-rwtm-firmware"; > + mboxes = <&rwtm 0>; > + status = "okay"; > + }; > + }; > }; > -- > 2.20.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3548CC49EA2 for ; Thu, 17 Jun 2021 13:10:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1243613B9 for ; Thu, 17 Jun 2021 13:10:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1243613B9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BQVvWIIhJ8cjicBWU0DIsdIqs0RFrJA4k1aatyiIl58=; b=NpB2kDwOgO83BQ nMxLODFA1327NoRZM2BefmcvtU9HYyjAQwOCTm8Qd4qnXI32FyJdUfbnMlgB1X30EbG4szTut7xp8 ylGt+0WZQO56ekW6FwcsfPC1o3y5qVEdWjZ8VVyN8THECg7zvgjT7UZoxNNxHsxlCtE0pdFH64Ru8 XE2T7Wf8EunAnlTvgY8cn9wS6gEhM3uum0gggMwupyEdCdaXFxY7nuO2QfPWMlLEcRqwle1rOkcGK Z62aHXRbaqxRIwCuRZgk4wmn2cg7RKlau925o+Mox8tndESOjRH5cVbB9SgvII5tocR9LsRX3BjnA Xydpn7NgPlF1tXdnAWIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltrlG-00AOWr-0l; Thu, 17 Jun 2021 13:08:46 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltrl9-00AOTY-09 for linux-arm-kernel@lists.infradead.org; Thu, 17 Jun 2021 13:08:43 +0000 Received: (Authenticated sender: gregory.clement@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 84A68240009; Thu, 17 Jun 2021 13:08:34 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Andrew Lunn Cc: Marek =?utf-8?Q?Beh=C3=BAn?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 mvebu + mvebu/dt64 2/2] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file In-Reply-To: <20210520113844.32319-3-pali@kernel.org> References: <20210308153703.23097-1-kabel@kernel.org> <20210520113844.32319-1-pali@kernel.org> <20210520113844.32319-3-pali@kernel.org> Date: Thu, 17 Jun 2021 15:08:34 +0200 Message-ID: <87mtro1vvx.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210617_060839_233469_E09702B1 X-CRM114-Status: GOOD ( 16.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgo+IE1vdmUgdGhlIHR1cnJpcy1tb3gtcnd0bSBmaXJtd2FyZSBub2RlIGZyb20gVHVy cmlzIE1PWCcgZGV2aWNlIHRyZWUgaW50bwo+IHRoZSBnZW5lcmljIGFybWFkYS0zN3h4LmR0c2kg ZmlsZSBhbmQgdXNlIHRoZSBnZW5lcmljIGNvbXBhdGlibGUgc3RyaW5nCj4gJ21hcnZlbGwsYXJt YWRhLTM3MDAtcnd0bS1maXJtd2FyZScgaW5zdGVhZCBvZiB0aGUgY3VycmVudCBvbmUuCj4KPiBU dXJyaXMgTU9YIERUUyBmaWxlIGNvbnRhaW5zIGFsc28gb2xkIGNvbXBhdGlibGUgc3RyaW5nIGZv ciBiYWNrd2FyZAo+IGNvbXBhdGliaWxpdHkuCj4KPiBUaGUgVHVycmlzIE1PWCByV1RNIGZpcm13 YXJlIGNhbiBiZSB1c2VkIG9uIGFueSBBcm1hZGEgMzd4eCBkZXZpY2UsCj4gZ2l2aW5nIHRoZW0g YWNjZXNzIHRvIHRoZSByV1RNIGhhcmR3YXJlIHJhbmRvbSBudW1iZXIgZ2VuZXJhdG9yLCB3aGlj aAo+IGlzIG90aGVyd2lzZSB1bmF2YWlsYWJsZS4KPgo+IFRoaXMgY2hhbmdlIGFsbG93cyBMaW51 eCB0byBsb2FkIHRoZSB0dXJyaXMtbW94LXJ3dG0ua28gbW9kdWxlIG9uIHRoZXNlCj4gYm9hcmRz Lgo+Cj4gVGVzdGVkIG9uIEVTUFJFU1NPYmluIHY1IHdpdGggYm90aCBkZWZhdWx0IE1hcnZlbGwg V1RNSSBmaXJtd2FyZSBhbmQKPiBDWi5OSUMncyBmaXJtd2FyZS4gV2l0aCBkZWZhdWx0IFdUTUkg ZmlybXdhcmUgdGhlIHR1cnJpcy1tb3gtcnd0bSBmYWlscwo+IHRvIHByb2JlLCB3aGlsZSB3aXRo IENaLk5JQydzIGZpcm13YXJlIGl0IHJlZ2lzdGVycyB0aGUgSFcgcmFuZG9tIG51bWJlcgo+IGdl bmVyYXRvci4KPgo+IFNpZ25lZC1vZmYtYnk6IFBhbGkgUm9ow6FyIDxwYWxpQGtlcm5lbC5vcmc+ Cj4gU2lnbmVkLW9mZi1ieTogTWFyZWsgQmVow7puIDxrYWJlbEBrZXJuZWwub3JnPgo+IENjOiA8 c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyA1LjQrOiA0NmQyZjZkMGM5OWYgKCJhcm02NDogZHRz OiBhcm1hZGEtMzcyMC10dXJyaXMtbW94OiBhZGQgZmlybXdhcmUgbm9kZSIpCgpBcHBsaWVkIG9u IG12ZWJ1L2R0NjQgKEkgcmVtb3ZlZCB0aGUgRml4ZXMgbGluZSkKClRoYW5rcywKCkdyZWdvcnkK PiAtLS0KPiAgYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXR1cnJpcy1t b3guZHRzIHwgNiArKy0tLS0KPiAgYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0z N3h4LmR0c2kgICAgICAgICAgIHwgOCArKysrKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDEwIGlu c2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9i b290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXR1cnJpcy1tb3guZHRzIGIvYXJjaC9hcm02NC9i b290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXR1cnJpcy1tb3guZHRzCj4gaW5kZXggMDc1M2Nj NDg5NjM4Li42NzAwZjIyMTJiNjEgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9t YXJ2ZWxsL2FybWFkYS0zNzIwLXR1cnJpcy1tb3guZHRzCj4gKysrIGIvYXJjaC9hcm02NC9ib290 L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXR1cnJpcy1tb3guZHRzCj4gQEAgLTEwOSwxMCArMTA5 LDggQEAKPiAgCX07Cj4gIAo+ICAJZmlybXdhcmUgewo+IC0JCXR1cnJpcy1tb3gtcnd0bSB7Cj4g LQkJCWNvbXBhdGlibGUgPSAiY3puaWMsdHVycmlzLW1veC1yd3RtIjsKPiAtCQkJbWJveGVzID0g PCZyd3RtIDA+Owo+IC0JCQlzdGF0dXMgPSAib2theSI7Cj4gKwkJYXJtYWRhLTM3MDAtcnd0bSB7 Cj4gKwkJCWNvbXBhdGlibGUgPSAibWFydmVsbCxhcm1hZGEtMzcwMC1yd3RtLWZpcm13YXJlIiwg ImN6bmljLHR1cnJpcy1tb3gtcnd0bSI7Cj4gIAkJfTsKPiAgCX07Cj4gIH07Cj4gZGlmZiAtLWdp dCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvbWFydmVsbC9hcm1hZGEtMzd4eC5kdHNpIGIvYXJjaC9h cm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zN3h4LmR0c2kKPiBpbmRleCAxYjdmNDNlMjc1 ODkuLjg0N2EyZDEyYTRiZSAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL21hcnZl bGwvYXJtYWRhLTM3eHguZHRzaQo+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvbWFydmVsbC9h cm1hZGEtMzd4eC5kdHNpCj4gQEAgLTUwNSw0ICs1MDUsMTIgQEAKPiAgCQkJfTsKPiAgCQl9Owo+ ICAJfTsKPiArCj4gKwlmaXJtd2FyZSB7Cj4gKwkJYXJtYWRhLTM3MDAtcnd0bSB7Cj4gKwkJCWNv bXBhdGlibGUgPSAibWFydmVsbCxhcm1hZGEtMzcwMC1yd3RtLWZpcm13YXJlIjsKPiArCQkJbWJv eGVzID0gPCZyd3RtIDA+Owo+ICsJCQlzdGF0dXMgPSAib2theSI7Cj4gKwkJfTsKPiArCX07Cj4g IH07Cj4gLS0gCj4gMi4yMC4xCj4KCi0tIApHcmVnb3J5IENsZW1lbnQsIEJvb3RsaW4KRW1iZWRk ZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwpodHRwOi8vYm9vdGxpbi5jb20KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK