From: Markus Armbruster <armbru@redhat.com>
To: Collin Walling <walling@linux.ibm.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, thuth@redhat.com,
david@redhat.com, wangyanan55@huawei.com, philmd@linaro.org,
marcel.apfelbaum@gmail.com, eduardo@habkost.net,
armbru@redhat.com
Subject: Re: [PATCH v3 1/2] target/s390x: report deprecated-props in cpu-model-expansion reply
Date: Fri, 26 Apr 2024 10:42:04 +0200 [thread overview]
Message-ID: <87o79wy0pv.fsf@pond.sub.org> (raw)
In-Reply-To: <20240424215633.48906-2-walling@linux.ibm.com> (Collin Walling's message of "Wed, 24 Apr 2024 17:56:32 -0400")
Collin Walling <walling@linux.ibm.com> writes:
> Retain a list of deprecated features disjoint from any particular
> CPU model. A query-cpu-model-expansion reply will now provide a list of
> properties (i.e. features) that are flagged as deprecated. Example:
>
> {
> "return": {
> "model": {
> "name": "z14.2-base",
> "deprecated-props": [
> "bpb",
> "csske"
> ],
> "props": {
> "pfmfi": false,
> "exrl": true,
> ...a lot more props...
> "skey": false,
> "vxpdeh2": false
> }
> }
> }
> }
>
> It is recommended that s390 guests operate with these features
> explicitly disabled to ensure compatability with future hardware.
>
> Signed-off-by: Collin Walling <walling@linux.ibm.com>
> ---
> qapi/machine-target.json | 5 ++++-
> target/s390x/cpu_features.c | 14 ++++++++++++++
> target/s390x/cpu_features.h | 1 +
> target/s390x/cpu_models_sysemu.c | 6 ++++++
> 4 files changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/machine-target.json b/qapi/machine-target.json
> index 29e695aa06..3799a60e3d 100644
> --- a/qapi/machine-target.json
> +++ b/qapi/machine-target.json
> @@ -20,11 +20,14 @@
> #
> # @props: a dictionary of QOM properties to be applied
> #
> +# @deprecated-props: a list of QOM properties that are flagged as deprecated
Deprecated by whom? QEMU? The CPU vendor?
docs/devel/qapi-code-gen.rst:
For legibility, wrap text paragraphs so every line is at most 70
characters long.
> +#
> # Since: 2.8
> ##
> { 'struct': 'CpuModelInfo',
> 'data': { 'name': 'str',
> - '*props': 'any' } }
> + '*props': 'any',
> + '*deprecated-props': ['str'] } }
>
> ##
> # @CpuModelExpansionType:
[...]
next prev parent reply other threads:[~2024-04-26 8:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 21:56 [PATCH v3 0/2] query-cpu-model-expansion: report deprecated features Collin Walling
2024-04-24 21:56 ` [PATCH v3 1/2] target/s390x: report deprecated-props in cpu-model-expansion reply Collin Walling
2024-04-26 8:42 ` Markus Armbruster [this message]
2024-04-26 17:35 ` Collin Walling
2024-04-26 20:11 ` Collin Walling
2024-04-26 17:44 ` David Hildenbrand
2024-04-26 17:45 ` David Hildenbrand
2024-04-26 19:28 ` Collin Walling
2024-04-24 21:56 ` [PATCH v3 2/2] target/s390x: flag te and cte as deprecated Collin Walling
2024-04-24 22:05 ` [PATCH v3 0/2] query-cpu-model-expansion: report deprecated features Collin Walling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o79wy0pv.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=david@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
--cc=walling@linux.ibm.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.