From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76803C4338F for ; Mon, 2 Aug 2021 12:36:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E34960EBD for ; Mon, 2 Aug 2021 12:36:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232682AbhHBMgX (ORCPT ); Mon, 2 Aug 2021 08:36:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:43334 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232629AbhHBMgX (ORCPT ); Mon, 2 Aug 2021 08:36:23 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1FD7460551; Mon, 2 Aug 2021 12:36:14 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mAXAy-002RiU-6o; Mon, 02 Aug 2021 13:36:12 +0100 Date: Mon, 02 Aug 2021 13:36:11 +0100 Message-ID: <87o8ag10sk.wl-maz@kernel.org> From: Marc Zyngier To: Catalin Marinas Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com, Quentin Perret , stable@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Unregister HYP sections from kmemleak in protected mode In-Reply-To: <20210729164214.GB31848@arm.com> References: <20210729135016.3037277-1-maz@kernel.org> <20210729164214.GB31848@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: catalin.marinas@arm.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, will@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, alexandru.elisei@arm.com, kernel-team@android.com, qperret@google.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, 29 Jul 2021 17:42:15 +0100, Catalin Marinas wrote: > > On Thu, Jul 29, 2021 at 02:50:16PM +0100, Marc Zyngier wrote: > > Booting a KVM host in protected mode with kmemleak quickly results > > in a pretty bad crash, as kmemleak doesn't know that the HYP sections > > have been taken away. > > > > Make the unregistration from kmemleak part of marking the sections > > as HYP-private. The rest of the HYP-specific data is obtained via > > the page allocator, which is not subjected to kmemleak. > > > > Fixes: 90134ac9cabb ("KVM: arm64: Protect the .hyp sections from the host") > > Signed-off-by: Marc Zyngier > > Cc: Quentin Perret > > Cc: Catalin Marinas > > Cc: stable@vger.kernel.org # 5.13 > > --- > > arch/arm64/kvm/arm.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > > index e9a2b8f27792..23f12e602878 100644 > > --- a/arch/arm64/kvm/arm.c > > +++ b/arch/arm64/kvm/arm.c > > @@ -15,6 +15,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -1960,8 +1961,12 @@ static inline int pkvm_mark_hyp(phys_addr_t start, phys_addr_t end) > > } > > > > #define pkvm_mark_hyp_section(__section) \ > > +({ \ > > + u64 sz = __section##_end - __section##_start; \ > > + kmemleak_free_part(__section##_start, sz); \ > > pkvm_mark_hyp(__pa_symbol(__section##_start), \ > > - __pa_symbol(__section##_end)) > > + __pa_symbol(__section##_end)); \ > > +}) > > Using kmemleak_free_part() is fine in principle as this is not a slab > object. However, the above would call the function even for ranges that > are not tracked at all by kmemleak (text, idmap). Luckily Kmemleak won't > complain, unless you #define DEBUG in the file (initially I tried to > warn all the time but I couldn't fix all the callbacks). Yeah, I had a look last week, and this fires everywhere (KVM only adds a drop in an ocean of warnings). > If it was just the BSS, I would move the kmemleak_free_part() call to > finalize_hyp_mode() but there's the __hyp_rodata section as well. > > I think we have some inconsistency with .hyp.rodata which falls under > _sdata.._edata while the kernel's own .rodata goes immediately after > _etext. Should we move __hyp_rodata outside _sdata.._edata as well? It > would benefit from the RO NX marking (probably more useful without the > protected mode). If this works, we'd only need to call kmemleak once for > the BSS. That's a good idea, and pretty easy to implement. I'll post a respin shortly. Thanks, M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3C32C4338F for ; Mon, 2 Aug 2021 12:36:20 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 343DE610CC for ; Mon, 2 Aug 2021 12:36:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 343DE610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 938354A19A; Mon, 2 Aug 2021 08:36:19 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LzPkG+Nh76R3; Mon, 2 Aug 2021 08:36:17 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 910494A4A4; Mon, 2 Aug 2021 08:36:17 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 63EBE4099E for ; Mon, 2 Aug 2021 08:36:16 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pzKaTRXVhv-t for ; Mon, 2 Aug 2021 08:36:15 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 382A940667 for ; Mon, 2 Aug 2021 08:36:15 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1FD7460551; Mon, 2 Aug 2021 12:36:14 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mAXAy-002RiU-6o; Mon, 02 Aug 2021 13:36:12 +0100 Date: Mon, 02 Aug 2021 13:36:11 +0100 Message-ID: <87o8ag10sk.wl-maz@kernel.org> From: Marc Zyngier To: Catalin Marinas Subject: Re: [PATCH] KVM: arm64: Unregister HYP sections from kmemleak in protected mode In-Reply-To: <20210729164214.GB31848@arm.com> References: <20210729135016.3037277-1-maz@kernel.org> <20210729164214.GB31848@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: catalin.marinas@arm.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, will@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, alexandru.elisei@arm.com, kernel-team@android.com, qperret@google.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kernel-team@android.com, kvm@vger.kernel.org, stable@vger.kernel.org, Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Thu, 29 Jul 2021 17:42:15 +0100, Catalin Marinas wrote: > > On Thu, Jul 29, 2021 at 02:50:16PM +0100, Marc Zyngier wrote: > > Booting a KVM host in protected mode with kmemleak quickly results > > in a pretty bad crash, as kmemleak doesn't know that the HYP sections > > have been taken away. > > > > Make the unregistration from kmemleak part of marking the sections > > as HYP-private. The rest of the HYP-specific data is obtained via > > the page allocator, which is not subjected to kmemleak. > > > > Fixes: 90134ac9cabb ("KVM: arm64: Protect the .hyp sections from the host") > > Signed-off-by: Marc Zyngier > > Cc: Quentin Perret > > Cc: Catalin Marinas > > Cc: stable@vger.kernel.org # 5.13 > > --- > > arch/arm64/kvm/arm.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > > index e9a2b8f27792..23f12e602878 100644 > > --- a/arch/arm64/kvm/arm.c > > +++ b/arch/arm64/kvm/arm.c > > @@ -15,6 +15,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -1960,8 +1961,12 @@ static inline int pkvm_mark_hyp(phys_addr_t start, phys_addr_t end) > > } > > > > #define pkvm_mark_hyp_section(__section) \ > > +({ \ > > + u64 sz = __section##_end - __section##_start; \ > > + kmemleak_free_part(__section##_start, sz); \ > > pkvm_mark_hyp(__pa_symbol(__section##_start), \ > > - __pa_symbol(__section##_end)) > > + __pa_symbol(__section##_end)); \ > > +}) > > Using kmemleak_free_part() is fine in principle as this is not a slab > object. However, the above would call the function even for ranges that > are not tracked at all by kmemleak (text, idmap). Luckily Kmemleak won't > complain, unless you #define DEBUG in the file (initially I tried to > warn all the time but I couldn't fix all the callbacks). Yeah, I had a look last week, and this fires everywhere (KVM only adds a drop in an ocean of warnings). > If it was just the BSS, I would move the kmemleak_free_part() call to > finalize_hyp_mode() but there's the __hyp_rodata section as well. > > I think we have some inconsistency with .hyp.rodata which falls under > _sdata.._edata while the kernel's own .rodata goes immediately after > _etext. Should we move __hyp_rodata outside _sdata.._edata as well? It > would benefit from the RO NX marking (probably more useful without the > protected mode). If this works, we'd only need to call kmemleak once for > the BSS. That's a good idea, and pretty easy to implement. I'll post a respin shortly. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70856C4338F for ; Mon, 2 Aug 2021 12:38:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37D3660F50 for ; Mon, 2 Aug 2021 12:38:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 37D3660F50 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=63cNuRrzNrKFO4fIu5ls56hMytFO5zfcJ9Mn3o5KNAs=; b=3Fa5XqF8kTm9Le CVYQUboJTMc/tPRkMOjEgSuLxPwL0z8Z2a2Kzk8zVvo5o1X5jt+NsMgba6asdwvHo15wI1J9HH4KD /nd5DTJcjV//dhOWDcwpsl7j+0zV8WSISjlo37UAtvzYD2zzbKF77lJbcnWjt9xR3QhgdKVSdvQAK Sj4xeNxplcrEN2H/OUrFEgqbVS9hkXQPuxkAyTMmnOWkbZsTEZVBN9XlpohnKZFp8B6ZHfQgApwA9 Ri9eexn15xIeQvOxmDSZFOElYxdJi5BUQOlQJYYEEivQx08VNNYcLj629MeqQKboQO3HOooSY1659 si6lGX4As/6mmapEE5Sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAXBD-00GD8X-Uz; Mon, 02 Aug 2021 12:36:28 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAXB0-00GD6u-AZ for linux-arm-kernel@lists.infradead.org; Mon, 02 Aug 2021 12:36:17 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1FD7460551; Mon, 2 Aug 2021 12:36:14 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mAXAy-002RiU-6o; Mon, 02 Aug 2021 13:36:12 +0100 Date: Mon, 02 Aug 2021 13:36:11 +0100 Message-ID: <87o8ag10sk.wl-maz@kernel.org> From: Marc Zyngier To: Catalin Marinas Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com, Quentin Perret , stable@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Unregister HYP sections from kmemleak in protected mode In-Reply-To: <20210729164214.GB31848@arm.com> References: <20210729135016.3037277-1-maz@kernel.org> <20210729164214.GB31848@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: catalin.marinas@arm.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, will@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, alexandru.elisei@arm.com, kernel-team@android.com, qperret@google.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210802_053614_465875_3B66BF26 X-CRM114-Status: GOOD ( 33.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 29 Jul 2021 17:42:15 +0100, Catalin Marinas wrote: > > On Thu, Jul 29, 2021 at 02:50:16PM +0100, Marc Zyngier wrote: > > Booting a KVM host in protected mode with kmemleak quickly results > > in a pretty bad crash, as kmemleak doesn't know that the HYP sections > > have been taken away. > > > > Make the unregistration from kmemleak part of marking the sections > > as HYP-private. The rest of the HYP-specific data is obtained via > > the page allocator, which is not subjected to kmemleak. > > > > Fixes: 90134ac9cabb ("KVM: arm64: Protect the .hyp sections from the host") > > Signed-off-by: Marc Zyngier > > Cc: Quentin Perret > > Cc: Catalin Marinas > > Cc: stable@vger.kernel.org # 5.13 > > --- > > arch/arm64/kvm/arm.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > > index e9a2b8f27792..23f12e602878 100644 > > --- a/arch/arm64/kvm/arm.c > > +++ b/arch/arm64/kvm/arm.c > > @@ -15,6 +15,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -1960,8 +1961,12 @@ static inline int pkvm_mark_hyp(phys_addr_t start, phys_addr_t end) > > } > > > > #define pkvm_mark_hyp_section(__section) \ > > +({ \ > > + u64 sz = __section##_end - __section##_start; \ > > + kmemleak_free_part(__section##_start, sz); \ > > pkvm_mark_hyp(__pa_symbol(__section##_start), \ > > - __pa_symbol(__section##_end)) > > + __pa_symbol(__section##_end)); \ > > +}) > > Using kmemleak_free_part() is fine in principle as this is not a slab > object. However, the above would call the function even for ranges that > are not tracked at all by kmemleak (text, idmap). Luckily Kmemleak won't > complain, unless you #define DEBUG in the file (initially I tried to > warn all the time but I couldn't fix all the callbacks). Yeah, I had a look last week, and this fires everywhere (KVM only adds a drop in an ocean of warnings). > If it was just the BSS, I would move the kmemleak_free_part() call to > finalize_hyp_mode() but there's the __hyp_rodata section as well. > > I think we have some inconsistency with .hyp.rodata which falls under > _sdata.._edata while the kernel's own .rodata goes immediately after > _etext. Should we move __hyp_rodata outside _sdata.._edata as well? It > would benefit from the RO NX marking (probably more useful without the > protected mode). If this works, we'd only need to call kmemleak once for > the BSS. That's a good idea, and pretty easy to implement. I'll post a respin shortly. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel