From: Cornelia Huck <cohuck@redhat.com>
To: Eric Farman <farman@linux.ibm.com>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eric Farman <farman@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH v3 4/4] s390x/css: Add passthrough IRB
Date: Wed, 16 Jun 2021 11:59:59 +0200 [thread overview]
Message-ID: <87o8c6w2n4.fsf@redhat.com> (raw)
In-Reply-To: <20210616014749.2460133-5-farman@linux.ibm.com>
On Wed, Jun 16 2021, Eric Farman <farman@linux.ibm.com> wrote:
> Wire in the subchannel callback for building the IRB
> ESW and ECW space for passthrough devices, and copy
> the hardware's ESW into the IRB we are building.
>
> If the hardware presented concurrent sense, then copy
> that sense data into the IRB's ECW space.
>
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> ---
> hw/s390x/css.c | 13 ++++++++++++-
> hw/s390x/s390-ccw.c | 1 +
> hw/vfio/ccw.c | 4 ++++
> include/hw/s390x/css.h | 3 +++
> 4 files changed, 20 insertions(+), 1 deletion(-)
>
(...)
> +void build_irb_passthrough(SubchDev *sch, IRB *irb)
> +{
> + /* Copy ESW from hardware */
> + irb->esw = sch->esw;
> +
> + if (irb->esw.erw & ESW_ERW_SENSE) {
> + /* Copy ECW from hardware */
> + build_irb_sense_data(sch, irb);
> + }
I'm wondering whether we should also copy "Model-dependent information"
(scsw 5 + 14 set, erw 7 unset). Seems more correct, and IIUC the guest
was tripped by the presence of erw 7 without valid sense data.
> +}
> +
next prev parent reply other threads:[~2021-06-16 10:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 1:47 [PATCH v3 0/4] s390x: Fix IRB sense data Eric Farman
2021-06-16 1:47 ` [PATCH v3 1/4] s390x/css: Introduce an ESW struct Eric Farman
2021-06-16 9:46 ` Cornelia Huck
2021-06-16 12:57 ` Eric Farman
2021-06-16 13:52 ` Cornelia Huck
2021-06-16 1:47 ` [PATCH v3 2/4] s390x/css: Split out the IRB sense data Eric Farman
2021-06-17 5:05 ` Thomas Huth
2021-06-16 1:47 ` [PATCH v3 3/4] s390x/css: Refactor IRB construction Eric Farman
2021-06-16 1:47 ` [PATCH v3 4/4] s390x/css: Add passthrough IRB Eric Farman
2021-06-16 9:59 ` Cornelia Huck [this message]
2021-06-16 13:03 ` Eric Farman
2021-06-16 13:53 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8c6w2n4.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.