* [PATCH 1/2] ARM: bcm2835: dts: fix i2c0 pins
@ 2017-01-29 19:53 Baruch Siach
2017-01-29 19:53 ` [PATCH 2/2] ARM: bcm2835: dts: fix uart0/uart1 pins Baruch Siach
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2017-01-29 19:53 UTC (permalink / raw
To: linux-arm-kernel
According to the BCM2835 ARM Peripherals document i2c0 doesn't map to pins 32,
34 but to 28, 29.
Fixes: 21ff843931b ("ARM: dts: bcm283x: Define standard pinctrl groups in the gpio node.")
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
arch/arm/boot/dts/bcm283x.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
index bc8ad417c8a3..2ae842921250 100644
--- a/arch/arm/boot/dts/bcm283x.dtsi
+++ b/arch/arm/boot/dts/bcm283x.dtsi
@@ -195,8 +195,8 @@
brcm,pins = <0 1>;
brcm,function = <BCM2835_FSEL_ALT0>;
};
- i2c0_gpio32: i2c0_gpio32 {
- brcm,pins = <32 34>;
+ i2c0_gpio28: i2c0_gpio28 {
+ brcm,pins = <28 29>;
brcm,function = <BCM2835_FSEL_ALT0>;
};
i2c0_gpio44: i2c0_gpio44 {
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] ARM: bcm2835: dts: fix uart0/uart1 pins
2017-01-29 19:53 [PATCH 1/2] ARM: bcm2835: dts: fix i2c0 pins Baruch Siach
@ 2017-01-29 19:53 ` Baruch Siach
2017-01-30 23:32 ` Eric Anholt
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2017-01-29 19:53 UTC (permalink / raw
To: linux-arm-kernel
According to the BCM2835 ARM Peripherals document uart1 doesn't map to pins
36-39, but uart0 does.
Also, split into separate Rx/Tx and CST/RTS groups to match other uart nodes.
Fixes: 21ff843931b ("ARM: dts: bcm283x: Define standard pinctrl groups in the gpio node.")
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
arch/arm/boot/dts/bcm283x.dtsi | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
index 2ae842921250..9ee8346b8b19 100644
--- a/arch/arm/boot/dts/bcm283x.dtsi
+++ b/arch/arm/boot/dts/bcm283x.dtsi
@@ -306,6 +306,14 @@
brcm,pins = <32 33>;
brcm,function = <BCM2835_FSEL_ALT3>;
};
+ uart0_gpio36: uart0_gpio36 {
+ brcm,pins = <36 37>;
+ brcm,function = <BCM2835_FSEL_ALT2>;
+ };
+ uart0_ctsrts_gpio38: uart0_ctsrts_gpio38 {
+ brcm,pins = <38 39>;
+ brcm,function = <BCM2835_FSEL_ALT2>;
+ };
uart1_gpio14: uart1_gpio14 {
brcm,pins = <14 15>;
@@ -323,10 +331,6 @@
brcm,pins = <30 31>;
brcm,function = <BCM2835_FSEL_ALT5>;
};
- uart1_gpio36: uart1_gpio36 {
- brcm,pins = <36 37 38 39>;
- brcm,function = <BCM2835_FSEL_ALT2>;
- };
uart1_gpio40: uart1_gpio40 {
brcm,pins = <40 41>;
brcm,function = <BCM2835_FSEL_ALT5>;
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] ARM: bcm2835: dts: fix uart0/uart1 pins
2017-01-29 19:53 ` [PATCH 2/2] ARM: bcm2835: dts: fix uart0/uart1 pins Baruch Siach
@ 2017-01-30 23:32 ` Eric Anholt
0 siblings, 0 replies; 3+ messages in thread
From: Eric Anholt @ 2017-01-30 23:32 UTC (permalink / raw
To: linux-arm-kernel
Baruch Siach <baruch@tkos.co.il> writes:
> According to the BCM2835 ARM Peripherals document uart1 doesn't map to pins
> 36-39, but uart0 does.
>
> Also, split into separate Rx/Tx and CST/RTS groups to match other uart nodes.
>
> Fixes: 21ff843931b ("ARM: dts: bcm283x: Define standard pinctrl groups in the gpio node.")
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
These look good, too. Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170130/e7f67085/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-30 23:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-29 19:53 [PATCH 1/2] ARM: bcm2835: dts: fix i2c0 pins Baruch Siach
2017-01-29 19:53 ` [PATCH 2/2] ARM: bcm2835: dts: fix uart0/uart1 pins Baruch Siach
2017-01-30 23:32 ` Eric Anholt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.