From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoUAI-00040q-4T for qemu-devel@nongnu.org; Tue, 20 Oct 2015 06:29:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoUAG-0005Mo-MG for qemu-devel@nongnu.org; Tue, 20 Oct 2015 06:29:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoUAG-0005Mk-Gj for qemu-devel@nongnu.org; Tue, 20 Oct 2015 06:29:08 -0400 From: Juan Quintela In-Reply-To: <20150806104559.GB2251@work-vm> (David Alan Gilbert's message of "Thu, 6 Aug 2015 11:45:59 +0100") References: <1434450415-11339-1-git-send-email-dgilbert@redhat.com> <1434450415-11339-32-git-send-email-dgilbert@redhat.com> <87egkbgkra.fsf@neno.neno> <20150806104559.GB2251@work-vm> Date: Tue, 20 Oct 2015 12:29:04 +0200 Message-ID: <87si55x28f.fsf@neno.neno> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v7 31/42] Page request: Process incoming page request Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, liang.z.li@intel.com, qemu-devel@nongnu.org, luis@cs.umu.se, amit.shah@redhat.com, pbonzini@redhat.com, david@gibson.dropbear.id.au "Dr. David Alan Gilbert" wrote: > * Juan Quintela (quintela@redhat.com) wrote: >> Once here, do we care about calling malloc with the rcu set? or could >> we just call malloc at the beggining of the function and free it in case >> that it is not needed on err? > > Why would that be better? We would make the rcu region smaller, not sure we should care, so forget. Later, Juan.