From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23E25C433B4 for ; Fri, 21 May 2021 13:49:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F39BD60C3E for ; Fri, 21 May 2021 13:49:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236021AbhEUNvE (ORCPT ); Fri, 21 May 2021 09:51:04 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:54146 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233028AbhEUNvD (ORCPT ); Fri, 21 May 2021 09:51:03 -0400 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1621604979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HCaRskSS01bIv3f54A3vpRo8CfM3PmECUijGdGwwaZM=; b=tsNUav2Duagwr1OktGXOly/chOAYD2bmyTPog0/54KKIKgYWZsSj/KoA1Do9CIlOHdRrAy l8Wckg+es45UV29dbhRXSgApo2+AA7VfG6Kv4QP5t2xotRhoPFrD14s879TsrebIlT2oHp bmNW0TCc/ml3Cs7HILsyp5pOHK9OrPtqv5Y8e3lTC7X0YK987RaccdtTlPYiwjKqO4KpMq +WnGTkwEG6unkbj+4hC1rK180OyD1MXnnm3yMzvzH3FbMRvu0BIFrhKb1Y5k0eOTUagNu9 AbR2TCX062iTP9D1yquicr4ZkyTLQ/IxM5ro0kAK9v0hx2uk7VbtIo+KNQZieQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1621604979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HCaRskSS01bIv3f54A3vpRo8CfM3PmECUijGdGwwaZM=; b=rnSbMyottTAmrHZEvgHBOGGBmuadQg48n9AQwtQ/zr3dDfwTnr15r9+PCVzal5FQ9yr1WI vVjVECQFwutUJeDg== To: Will Deacon , Mika =?utf-8?Q?Penttil=C3=A4?= Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frederic Weisbecker , Marc Zyngier , Lorenzo Colitti , John Stultz , Stephen Boyd , kernel-team@android.com Subject: Re: [PATCH 3/5] tick/broadcast: Prefer per-cpu oneshot wakeup timers to broadcast In-Reply-To: <20210521112503.GA11850@willie-the-truck> References: <20210520184705.10845-1-will@kernel.org> <20210520184705.10845-4-will@kernel.org> <20210521112503.GA11850@willie-the-truck> Date: Fri, 21 May 2021 15:49:39 +0200 Message-ID: <87tumw9oy4.ffs@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 21 2021 at 12:25, Will Deacon wrote: > On Fri, May 21, 2021 at 05:25:41AM +0300, Mika Penttil=C3=A4 wrote: >> On 20.5.2021 21.47, Will Deacon wrote: >> > /* >> > * Conditionally install/replace broadcast device >> > */ >> > -void tick_install_broadcast_device(struct clock_event_device *dev) >> > +void tick_install_broadcast_device(struct clock_event_device *dev, in= t cpu) >> > { >> > struct clock_event_device *cur =3D tick_broadcast_device.evtdev; >> > + if (tick_set_oneshot_wakeup_device(dev, cpu)) >> > + return; >> > + >> > if (!tick_check_broadcast_device(cur, dev)) >> > return; >>=20 >> Does this disable hpet registering as a global broadcast device on x86 ?= I >> think it starts with cpumask =3D cpu0 so it qualifies for a percpu wakeup >> timer. > > Well spotted, I think you're probably right. I'll try to reproduce on my > laptop to confirm, but I hadn't noticed the tricks played with the cpumask > on x86. > > I'll probably need to rework things so that we install the broadcast timer > first, but prefer global devices. HPET has cpumask(0) but does not have CLOCK_EVT_FEAT_PERCPU set. The feature flag is a clear indicator for per cpu. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BD21C433B4 for ; Fri, 21 May 2021 13:51:56 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E76D26008E for ; Fri, 21 May 2021 13:51:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E76D26008E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yHz9W//dNRYFBb5orv+g/yQwoIc1YDIJlieeQOZcRNA=; b=XZfIojL/pDOSG11m6kUtjUC/q/ ymzQJSDEtiIlC1RoWwKD8il/whW5zVLRZ2EbO5Ia1foOfZVZshPwqccavEvPx3SbAoj3U5EV4+sgm 6Il5f/Q7MxzdkNimm7ZlZyUYn8SZfq+40cnDM7XGMsA0p5PEeqaQRnt+ArL9SRxv++qlqoI5zdIpg Pks0VaYEaIX9CF8WrC5dxqThMDdlDjdozTEHCbL4uRExIXG0Dmby+yiAwxpbY3pcY30hgLbFApip5 UqGofah/wj09/YHWJiq3JvG+55g8fPaBgNBHegsczUXC/f43E3jq1BPxq3+JD6h8Z8uHcbxjOhdDO gisMcDUw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk5XC-005eeD-OC; Fri, 21 May 2021 13:49:50 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk5X9-005edU-5Q for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 13:49:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=HCaRskSS01bIv3f54A3vpRo8CfM3PmECUijGdGwwaZM=; b=TGRYrfM0198p+BNMVbYngH7SjJ goL5qXbh+jMm+msL0bnMdYV8OGyjSaIyKIFfMfLcqXObOVFELo01+MyKUZTO6Pa/C9hchITUDBDca rbOWvmjYy4u10BH5/M2vCuHwnz2M9zELqJ8vwR50UCBvYbgtwMPo53BByBFSm9vHo2/ng9R6eMDuQ Qi2s8YxJKcIIjouofxUFLWt8PqMWz3Am55Ixfukyd0wod1fBAFfMTxH6lUb3Q4VEnQHmzHkft8WQb WGCjirDp+kmltCWXqdqTIU2DtVrz4pTulnbN9me5vAOUd2h8dBQLwY8sV2Mx0PLhQaGMCO0R28R4S Y42sRqpQ==; Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk5X5-00HAO0-Sa for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 13:49:45 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1621604979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HCaRskSS01bIv3f54A3vpRo8CfM3PmECUijGdGwwaZM=; b=tsNUav2Duagwr1OktGXOly/chOAYD2bmyTPog0/54KKIKgYWZsSj/KoA1Do9CIlOHdRrAy l8Wckg+es45UV29dbhRXSgApo2+AA7VfG6Kv4QP5t2xotRhoPFrD14s879TsrebIlT2oHp bmNW0TCc/ml3Cs7HILsyp5pOHK9OrPtqv5Y8e3lTC7X0YK987RaccdtTlPYiwjKqO4KpMq +WnGTkwEG6unkbj+4hC1rK180OyD1MXnnm3yMzvzH3FbMRvu0BIFrhKb1Y5k0eOTUagNu9 AbR2TCX062iTP9D1yquicr4ZkyTLQ/IxM5ro0kAK9v0hx2uk7VbtIo+KNQZieQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1621604979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HCaRskSS01bIv3f54A3vpRo8CfM3PmECUijGdGwwaZM=; b=rnSbMyottTAmrHZEvgHBOGGBmuadQg48n9AQwtQ/zr3dDfwTnr15r9+PCVzal5FQ9yr1WI vVjVECQFwutUJeDg== To: Will Deacon , Mika =?utf-8?Q?Penttil=C3=A4?= Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frederic Weisbecker , Marc Zyngier , Lorenzo Colitti , John Stultz , Stephen Boyd , kernel-team@android.com Subject: Re: [PATCH 3/5] tick/broadcast: Prefer per-cpu oneshot wakeup timers to broadcast In-Reply-To: <20210521112503.GA11850@willie-the-truck> References: <20210520184705.10845-1-will@kernel.org> <20210520184705.10845-4-will@kernel.org> <20210521112503.GA11850@willie-the-truck> Date: Fri, 21 May 2021 15:49:39 +0200 Message-ID: <87tumw9oy4.ffs@nanos.tec.linutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_064944_093298_058BD372 X-CRM114-Status: GOOD ( 15.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBNYXkgMjEgMjAyMSBhdCAxMjoyNSwgV2lsbCBEZWFjb24gd3JvdGU6Cj4gT24gRnJp LCBNYXkgMjEsIDIwMjEgYXQgMDU6MjU6NDFBTSArMDMwMCwgTWlrYSBQZW50dGlsw6Qgd3JvdGU6 Cj4+IE9uIDIwLjUuMjAyMSAyMS40NywgV2lsbCBEZWFjb24gd3JvdGU6Cj4+ID4gICAvKgo+PiA+ ICAgICogQ29uZGl0aW9uYWxseSBpbnN0YWxsL3JlcGxhY2UgYnJvYWRjYXN0IGRldmljZQo+PiA+ ICAgICovCj4+ID4gLXZvaWQgdGlja19pbnN0YWxsX2Jyb2FkY2FzdF9kZXZpY2Uoc3RydWN0IGNs b2NrX2V2ZW50X2RldmljZSAqZGV2KQo+PiA+ICt2b2lkIHRpY2tfaW5zdGFsbF9icm9hZGNhc3Rf ZGV2aWNlKHN0cnVjdCBjbG9ja19ldmVudF9kZXZpY2UgKmRldiwgaW50IGNwdSkKPj4gPiAgIHsK Pj4gPiAgIAlzdHJ1Y3QgY2xvY2tfZXZlbnRfZGV2aWNlICpjdXIgPSB0aWNrX2Jyb2FkY2FzdF9k ZXZpY2UuZXZ0ZGV2Owo+PiA+ICsJaWYgKHRpY2tfc2V0X29uZXNob3Rfd2FrZXVwX2RldmljZShk ZXYsIGNwdSkpCj4+ID4gKwkJcmV0dXJuOwo+PiA+ICsKPj4gPiAgIAlpZiAoIXRpY2tfY2hlY2tf YnJvYWRjYXN0X2RldmljZShjdXIsIGRldikpCj4+ID4gICAJCXJldHVybjsKPj4gCj4+IERvZXMg dGhpcyBkaXNhYmxlIGhwZXQgcmVnaXN0ZXJpbmcgYXMgYSBnbG9iYWwgYnJvYWRjYXN0IGRldmlj ZSBvbiB4ODYgPyBJCj4+IHRoaW5rIGl0IHN0YXJ0cyB3aXRoIGNwdW1hc2sgPSBjcHUwIHNvIGl0 IHF1YWxpZmllcyBmb3IgYSBwZXJjcHUgd2FrZXVwCj4+IHRpbWVyLgo+Cj4gV2VsbCBzcG90dGVk LCBJIHRoaW5rIHlvdSdyZSBwcm9iYWJseSByaWdodC4gSSdsbCB0cnkgdG8gcmVwcm9kdWNlIG9u IG15Cj4gbGFwdG9wIHRvIGNvbmZpcm0sIGJ1dCBJIGhhZG4ndCBub3RpY2VkIHRoZSB0cmlja3Mg cGxheWVkIHdpdGggdGhlIGNwdW1hc2sKPiBvbiB4ODYuCj4KPiBJJ2xsIHByb2JhYmx5IG5lZWQg dG8gcmV3b3JrIHRoaW5ncyBzbyB0aGF0IHdlIGluc3RhbGwgdGhlIGJyb2FkY2FzdCB0aW1lcgo+ IGZpcnN0LCBidXQgcHJlZmVyIGdsb2JhbCBkZXZpY2VzLgoKSFBFVCBoYXMgY3B1bWFzaygwKSBi dXQgZG9lcyBub3QgaGF2ZSBDTE9DS19FVlRfRkVBVF9QRVJDUFUgc2V0LiBUaGUKZmVhdHVyZSBm bGFnIGlzIGEgY2xlYXIgaW5kaWNhdG9yIGZvciBwZXIgY3B1LgoKVGhhbmtzLAoKICAgICAgICB0 Z2x4CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==