* [PATCH net v2] Documentation: netdev-FAQ: suggest how to post co-dependent series
@ 2020-11-25 4:15 Jakub Kicinski
2020-11-25 4:38 ` David Ahern
2020-11-25 4:47 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Jakub Kicinski @ 2020-11-25 4:15 UTC (permalink / raw
To: davem
Cc: netdev, brouer, f.fainelli, andrea.mayer, dsahern, stephen, ast,
Jakub Kicinski
Make an explicit suggestion how to post user space side of kernel
patches to avoid reposts when patchwork groups the wrong patches.
v2: mention the cases unlike iproute2 explicitly
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
Documentation/networking/netdev-FAQ.rst | 26 +++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/Documentation/networking/netdev-FAQ.rst b/Documentation/networking/netdev-FAQ.rst
index 21537766be4d..4b9ed5874d5a 100644
--- a/Documentation/networking/netdev-FAQ.rst
+++ b/Documentation/networking/netdev-FAQ.rst
@@ -254,6 +254,32 @@ you will have done run-time testing specific to your change, but at a
minimum, your changes should survive an ``allyesconfig`` and an
``allmodconfig`` build without new warnings or failures.
+Q: How do I post corresponding changes to user space components?
+----------------------------------------------------------------
+A: User space code exercising kernel features should be posted
+alongside kernel patches. This gives reviewers a chance to see
+how any new interface is used and how well it works.
+
+When user space tools reside in the kernel repo itself all changes
+should generally come as one series. If series becomes too large
+or the user space project is not reviewed on netdev include a link
+to a public repo where user space patches can be seen.
+
+In case user space tooling lives in a separate repository but is
+reviewed on netdev (e.g. patches to `iproute2` tools) kernel and
+user space patches should form separate series (threads) when posted
+to the mailing list, e.g.::
+
+ [PATCH net-next 0/3] net: some feature cover letter
+ └─ [PATCH net-next 1/3] net: some feature prep
+ └─ [PATCH net-next 2/3] net: some feature do it
+ └─ [PATCH net-next 3/3] selftest: net: some feature
+
+ [PATCH iproute2-next] ip: add support for some feature
+
+Posting as one thread is discouraged because it confuses patchwork
+(as of patchwork 2.2.2).
+
Q: Any other tips to help ensure my net/net-next patch gets OK'd?
-----------------------------------------------------------------
A: Attention to detail. Re-read your own work as if you were the
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net v2] Documentation: netdev-FAQ: suggest how to post co-dependent series
2020-11-25 4:15 [PATCH net v2] Documentation: netdev-FAQ: suggest how to post co-dependent series Jakub Kicinski
@ 2020-11-25 4:38 ` David Ahern
2020-11-25 4:47 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Ahern @ 2020-11-25 4:38 UTC (permalink / raw
To: Jakub Kicinski, davem
Cc: netdev, brouer, f.fainelli, andrea.mayer, stephen, ast
On 11/24/20 9:15 PM, Jakub Kicinski wrote:
> Make an explicit suggestion how to post user space side of kernel
> patches to avoid reposts when patchwork groups the wrong patches.
>
> v2: mention the cases unlike iproute2 explicitly
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Documentation/networking/netdev-FAQ.rst | 26 +++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/Documentation/networking/netdev-FAQ.rst b/Documentation/networking/netdev-FAQ.rst
> index 21537766be4d..4b9ed5874d5a 100644
> --- a/Documentation/networking/netdev-FAQ.rst
> +++ b/Documentation/networking/netdev-FAQ.rst
> @@ -254,6 +254,32 @@ you will have done run-time testing specific to your change, but at a
> minimum, your changes should survive an ``allyesconfig`` and an
> ``allmodconfig`` build without new warnings or failures.
>
> +Q: How do I post corresponding changes to user space components?
> +----------------------------------------------------------------
> +A: User space code exercising kernel features should be posted
> +alongside kernel patches. This gives reviewers a chance to see
> +how any new interface is used and how well it works.
> +
> +When user space tools reside in the kernel repo itself all changes
> +should generally come as one series. If series becomes too large
> +or the user space project is not reviewed on netdev include a link
> +to a public repo where user space patches can be seen.
> +
> +In case user space tooling lives in a separate repository but is
> +reviewed on netdev (e.g. patches to `iproute2` tools) kernel and
double space. besides that:
Reviewed-by: David Ahern <dsahern@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v2] Documentation: netdev-FAQ: suggest how to post co-dependent series
2020-11-25 4:15 [PATCH net v2] Documentation: netdev-FAQ: suggest how to post co-dependent series Jakub Kicinski
2020-11-25 4:38 ` David Ahern
@ 2020-11-25 4:47 ` David Miller
2020-11-25 10:37 ` Toke Høiland-Jørgensen
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2020-11-25 4:47 UTC (permalink / raw
To: kuba; +Cc: netdev, brouer, f.fainelli, andrea.mayer, dsahern, stephen, ast
From: Jakub Kicinski <kuba@kernel.org>
Date: Tue, 24 Nov 2020 20:15:24 -0800
> Make an explicit suggestion how to post user space side of kernel
> patches to avoid reposts when patchwork groups the wrong patches.
>
> v2: mention the cases unlike iproute2 explicitly
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks!!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v2] Documentation: netdev-FAQ: suggest how to post co-dependent series
2020-11-25 4:47 ` David Miller
@ 2020-11-25 10:37 ` Toke Høiland-Jørgensen
0 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-11-25 10:37 UTC (permalink / raw
To: David Miller, kuba
Cc: netdev, brouer, f.fainelli, andrea.mayer, dsahern, stephen, ast
>David Miller <davem@davemloft.net> writes:
> From: Jakub Kicinski <kuba@kernel.org>
> Date: Tue, 24 Nov 2020 20:15:24 -0800
>
>> Make an explicit suggestion how to post user space side of kernel
>> patches to avoid reposts when patchwork groups the wrong patches.
>>
>> v2: mention the cases unlike iproute2 explicitly
>>
>> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Applied, thanks!!
W000t! Welcome back Davem - we missed you! :)
-Toke
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-25 10:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-25 4:15 [PATCH net v2] Documentation: netdev-FAQ: suggest how to post co-dependent series Jakub Kicinski
2020-11-25 4:38 ` David Ahern
2020-11-25 4:47 ` David Miller
2020-11-25 10:37 ` Toke Høiland-Jørgensen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.