From: iarenaza@mondragon.edu (Iñaki Arenaza)
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: "linux-bluetooth\@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 1/1] device: Some devices send HSP UUIDs in the wrong order
Date: Tue, 14 Jul 2015 14:28:09 +0200 [thread overview]
Message-ID: <87y4iily92.fsf@osgiliath.escomposlinux.org> (raw)
In-Reply-To: <CABBYNZL=y8K34DBsQJ3onFxFXNDUZ-6Qt_PWz_ok34e74C1=cA@mail.gmail.com> (Luiz Augusto von Dentz's message of "Tue, 14 Jul 2015 15:17:27 +0300")
On Tue, Jul 14 2015, Luiz Augusto von Dentz wrote:
Hi Luiz,
>> + /* Fix devices that report HEADSET_HS_UUID before HSP_HS_UUID,
>> + * contrary to what Erratum #3507 says.
>> + */
>> + if ((bt_uuid_strcmp(profile_uuid, HEADSET_HS_UUID) == 0)) {
>
> I guess we could stop right here and just assume it should be
> HSP_HS_UUID instead so you just have to free and use assign
> g_strdup(HSP_HS_UUID) to profile_uuid.
That was exactly what I did in my first (private) version of the
patch. But I wanted to play safe and make sure HSP_HS_UUID was also
there.
Frankly, I don't know how broken other devices are, as I don't deal with
Bluetooth on a regular basis. So I fully trust your judgement on this
:-)
Best regards,
--
Iñaki Arenaza
Electronics and Computing Department
Mondragon University – Faculty of Engineering
http://www.mondragon.edu/
Goiru kalea 2, 20500 Arrasate-Mondragon (Spain)
Tel: +34 647503750 (direct) / +34 943794700 (pbx)
next prev parent reply other threads:[~2015-07-14 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 21:32 [PATCH 0/1] device: Some devices send HSP UUIDs in the wrong order Iñaki Arenaza
2015-07-13 21:32 ` [PATCH 1/1] " Iñaki Arenaza
2015-07-14 12:17 ` Luiz Augusto von Dentz
2015-07-14 12:28 ` Iñaki Arenaza [this message]
2015-07-19 14:55 ` [PATCH v2 0/1] " Iñaki Arenaza
2015-07-19 14:57 ` [PATCH v2 1/1] " Iñaki Arenaza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4iily92.fsf@osgiliath.escomposlinux.org \
--to=iarenaza@mondragon.edu \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.