From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5wBq-0003E9-5n for qemu-devel@nongnu.org; Fri, 19 Jun 2015 09:18:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5wBm-0006Wi-Vy for qemu-devel@nongnu.org; Fri, 19 Jun 2015 09:18:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5wBm-0006WX-Qw for qemu-devel@nongnu.org; Fri, 19 Jun 2015 09:18:34 -0400 From: Markus Armbruster References: <1434194302-26589-1-git-send-email-armbru@redhat.com> <1434194302-26589-3-git-send-email-armbru@redhat.com> <55840E20.5010300@suse.de> Date: Fri, 19 Jun 2015 15:18:32 +0200 In-Reply-To: <55840E20.5010300@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22?= =?utf-8?Q?'s?= message of "Fri, 19 Jun 2015 14:42:08 +0200") Message-ID: <87zj3vn8ev.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/7] qdev: Un-deprecate qdev_init_nofail() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com Andreas F=C3=A4rber writes: > Am 13.06.2015 um 13:18 schrieb Markus Armbruster: >> It's a perfectly sensible helper function. > > But only in the current state. Once/if we just set realized=3Dtrue on > /machine level, then no other helper functions will need to set it, as > pointed out in the following paragraph. > >>=20 >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake >> --- >> include/hw/qdev-core.h | 2 -- >> 1 file changed, 2 deletions(-) >>=20 >> diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h >> index 5789b91..fbfc741 100644 >> --- a/include/hw/qdev-core.h >> +++ b/include/hw/qdev-core.h >> @@ -65,8 +65,6 @@ struct VMStateDescription; >> * Operations depending on @props static properties should go into @rea= lize. >> * After successful realization, setting static properties will fail. >> * >> - * As an interim step, the #DeviceState:realized property is set by dep= recated >> - * function qdev_init_nofail(). >> * In the future, devices will propagate this state change to their chi= ldren >> * and along busses they expose. >> * The point in time will be deferred to machine creation, so that valu= es > > Nack to the patch as is. I would be much more open to it if you just > removed the word "deprecated" rather than the full paragraph explaining > where it is currently set. I can certainly do that. May I add your R-by then?