From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44001)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Z5CKO-0003fs-VT
	for qemu-devel@nongnu.org; Wed, 17 Jun 2015 08:20:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Z5CKJ-0001xu-BE
	for qemu-devel@nongnu.org; Wed, 17 Jun 2015 08:20:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41632)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Z5CKJ-0001xp-5a
	for qemu-devel@nongnu.org; Wed, 17 Jun 2015 08:20:19 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1434450415-11339-10-git-send-email-dgilbert@redhat.com> (David
	Alan Gilbert's message of "Tue, 16 Jun 2015 11:26:22 +0100")
References: <1434450415-11339-1-git-send-email-dgilbert@redhat.com>
	<1434450415-11339-10-git-send-email-dgilbert@redhat.com>
Date: Wed, 17 Jun 2015 14:20:17 +0200
Message-ID: <87zj3y4jcu.fsf@neno.neno>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v7 09/42] Rename save_live_complete to
	save_live_complete_precopy
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, liang.z.li@intel.com, qemu-devel@nongnu.org, luis@cs.umu.se, amit.shah@redhat.com, pbonzini@redhat.com, david@gibson.dropbear.id.au

"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> In postcopy we're going to need to perform the complete phase
> for postcopiable devices at a different point, start out by
> renaming all of the 'complete's to make the difference obvious.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

I will have called it save_live_precopy() and just drop the complete to
make names shorter, but as I am not doing the coding ....