From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [PATCH 4/5] virtio: free queue memory in
	virtio_dev_close()
Date: Wed, 15 Jul 2015 08:27:18 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C204A49031@IRSMSX108.ger.corp.intel.com>
References: <PATCH>
 <1436879459-18400-1-git-send-email-bernard.iremonger@intel.com>
 <1436879459-18400-5-git-send-email-bernard.iremonger@intel.com>
 <20150714112810.1319eddd@urahara>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id B1080C32A
 for <dev@dpdk.org>; Wed, 15 Jul 2015 10:27:21 +0200 (CEST)
In-Reply-To: <20150714112810.1319eddd@urahara>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Tuesday, July 14, 2015 7:28 PM
> To: Iremonger, Bernard
> Cc: dev@dpdk.org; Ouyang, Changchun
> Subject: Re: [PATCH 4/5] virtio: free queue memory in virtio_dev_close()
>=20
> On Tue, 14 Jul 2015 14:10:58 +0100
> Bernard Iremonger <bernard.iremonger@intel.com> wrote:
>=20
> >  static void
> > +virtio_free_queues(struct rte_eth_dev *dev) {
> > +	unsigned int i;
> > +
> > +	for (i =3D 0; i < dev->data->nb_rx_queues; i++) {
> > +		virtio_dev_rx_queue_release(dev->data->rx_queues[i]);
> > +		dev->data->rx_queues[i] =3D NULL;
> > +	}
> > +	dev->data->nb_rx_queues =3D 0;
> > +
> > +	for (i =3D 0; i < dev->data->nb_tx_queues; i++) {
> > +		virtio_dev_tx_queue_release(dev->data->tx_queues[i]);
> > +		dev->data->tx_queues[i] =3D NULL;
> > +	}
> > +	dev->data->nb_tx_queues =3D 0;
> > +}
> > +
>=20
> Where does command queue get freed?

The command queue is set up in the eth_virtio_dev_init() function and  free=
d in the eth_virtio_dev_uninit() function.

Regards,

Bernard.