From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Iremonger, Bernard" Subject: Re: [PATCH v4 1/1] ring: changes to support PCI Port Hotplug Date: Tue, 21 Jul 2015 15:36:58 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C204A4A8FA@IRSMSX108.ger.corp.intel.com> References: <1436274563-15555-2-git-send-email-bernard.iremonger@intel.com> <2594927.gpZtJzTWlz@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 6F20B106B for ; Tue, 21 Jul 2015 17:37:33 +0200 (CEST) In-Reply-To: <2594927.gpZtJzTWlz@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Saturday, July 18, 2015 9:28 PM > To: Iremonger, Bernard > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 1/1] ring: changes to support PCI Port > Hotplug >=20 > 2015-07-07 14:09, Bernard Iremonger: > > +static struct eth_driver rte_ring_pmd =3D { > > + .pci_drv =3D { >=20 > We really have to stop faking PCI. > EAL must be changed to allow non-PCI drivers without workaround. > A device can have no bus (virtual device) or a PCI bus or another one. >=20 > Let's rework EAL for release 2.2 before integrating this patch. The fake pci _drv is already used in the pcap and null pmds and in the or= iginal ring driver. Could they not all be reworked when the EAL is changed for 2.2. Surely we should be working with the 2.1 EAL. Regards, Bernard.