From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Iremonger, Bernard" Subject: Re: [PATCH v2 1/1] bonding: fix error handling in rte_eth_bond_create() Date: Wed, 5 Aug 2015 13:19:20 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C219F36EA6@IRSMSX108.ger.corp.intel.com> References: <1438778204-8896-1-git-send-email-bernard.iremonger@intel.com> <1514392.p4W8R5bZo1@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5D7295947 for ; Wed, 5 Aug 2015 15:19:53 +0200 (CEST) In-Reply-To: <1514392.p4W8R5bZo1@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, August 5, 2015 2:16 PM > To: Iremonger, Bernard > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/1] bonding: fix error handling in > rte_eth_bond_create() >=20 > 2015-08-05 13:36, Bernard Iremonger: > > if the name parameter to rte_eth_bond_create() was NULL, there was a > > segmentation fault because eth_dev was also NULL. >=20 > You also add error handling of mac_addrs alloc and release_port(). > It deserves to be said in this commit message. Will I send a v3 patch ? Regards, Bernard.