From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [PATCH v3 02/20] librte_ether: add fields
	from	rte_pci_driver to rte_eth_dev_data
Date: Fri, 16 Oct 2015 10:34:47 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C219F712C2@IRSMSX108.ger.corp.intel.com>
References: <PATCH>
 <1444667120-12891-1-git-send-email-bernard.iremonger@intel.com>
 <1444667120-12891-3-git-send-email-bernard.iremonger@intel.com>
 <B27915DBBA3421428155699D51E4CFE2023822AB@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
To: "Mcnamara, John" <john.mcnamara@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 445975A84
 for <dev@dpdk.org>; Fri, 16 Oct 2015 12:34:51 +0200 (CEST)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2023822AB@IRSMSX103.ger.corp.intel.com>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi John,

<snip>

> > Subject: [dpdk-dev] [PATCH v3 02/20] librte_ether: add fields from ...
> >
> >  		lro         : 1;   /**< RX LRO is ON(1) / OFF(0) */
> > +	uint32_t dev_flags; /**< Flags controlling handling of device. */
> > +	enum rte_kernel_driver kdrv;	/**< Kernel driver passthrough */
> > +	int numa_node;
> > +	const char *drv_name;
> >  };
> >
>=20
> Should the last two members have doxygen comments as well?
>=20
Yes,  I will add the following doxygen comments:

	int numa_node; /**< NUMA node connection */
	const char *drv_name;	/**< Driver name. */

Regards,

Bernard.