From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [PATCH v3 1/2] app/test: fix failures in the
 ring_pmd_autotest program
Date: Fri, 27 Nov 2015 16:40:21 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C219F8B689@IRSMSX108.ger.corp.intel.com>
References: <PATCH>
 <1448640460-25249-1-git-send-email-bernard.iremonger@intel.com>
 <1448640460-25249-2-git-send-email-bernard.iremonger@intel.com>
 <20151127161445.GB27472@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id A951A58D8
 for <dev@dpdk.org>; Fri, 27 Nov 2015 17:40:24 +0100 (CET)
In-Reply-To: <20151127161445.GB27472@bricha3-MOBL3>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Bruce,
<snip>

> Subject: Re: [dpdk-dev] [PATCH v3 1/2] app/test: fix failures in the
> ring_pmd_autotest program
>=20
> On Fri, Nov 27, 2015 at 04:07:39PM +0000, Bernard Iremonger wrote:
> > If eth_ring vdevs are created from the command line with the --vdev
> > option, they create there own rings which are not shared by other vdevs=
.
>=20
> Typo: s/their/there/

Will correct in v4.

>=20
> > Some of tests in this suite require that the vdevs share rings, so
> > some of the tests fail.
> >
> > For vdevs to share rings they must be created in the test code with
> > the
> > rte_eth_from_rings() function using rings created with the
> > rte_ring_create() function.
> >
> > Use the command line option --vdev=3Deth_ring0 to create port 0.
>=20
> As I understand it, this option is not mandatory for the tests to pass, i=
t only
> allows some additional functional tests on cmd-line created rings to be r=
un.
> This should perhaps still be called out in the commit message.

I will add that this option is not mandatory to the commit message.

>=20
> > Create two rings and five ethdevs in test_pmd_ring.c for ports 1 to 5.
> "... and then use these to run the unit tests on the pmd ring functionali=
ty"
>=20
>=20
> > Improve test output by adding the port number to printf statements,
> > and adding a printf describing each test.
> >
>=20
> /Bruce

Regards,

Bernard.