From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWPxd-0003pB-7l for qemu-devel@nongnu.org; Tue, 02 Jan 2018 12:02:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWPxc-00066A-Kc for qemu-devel@nongnu.org; Tue, 02 Jan 2018 12:02:45 -0500 Received: from mail-pl0-x243.google.com ([2607:f8b0:400e:c01::243]:33715) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWPxc-00065p-ER for qemu-devel@nongnu.org; Tue, 02 Jan 2018 12:02:44 -0500 Received: by mail-pl0-x243.google.com with SMTP id 1so27533035plv.0 for ; Tue, 02 Jan 2018 09:02:44 -0800 (PST) References: <20180102011032.30056-1-laurent@vivier.eu> <20180102011032.30056-15-laurent@vivier.eu> From: Richard Henderson Message-ID: <8b46b84b-d673-b0b3-e989-d3484093e48f@linaro.org> Date: Tue, 2 Jan 2018 09:02:39 -0800 MIME-Version: 1.0 In-Reply-To: <20180102011032.30056-15-laurent@vivier.eu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 14/17] target/m68k: add 680x0 "move to SR" instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-devel@nongnu.org Cc: Thomas Huth On 01/01/2018 05:10 PM, Laurent Vivier wrote: > Some cleanup, and allows SR to be moved from any addressing mode. > Previous code was wrong for coldfire: coldfire also allows to > use addressing mode to set SR/CCR. It only supports Data register > to get SR/CCR (move from) > > Signed-off-by: Laurent Vivier > --- > target/m68k/translate.c | 38 ++++++++++++++++++++++---------------- > 1 file changed, 22 insertions(+), 16 deletions(-) Reviewed-by: Richard Henderson r~