From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E68DDC48BE6 for ; Wed, 16 Jun 2021 06:57:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCAF3613B9 for ; Wed, 16 Jun 2021 06:57:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231699AbhFPG7X (ORCPT ); Wed, 16 Jun 2021 02:59:23 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:4938 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230508AbhFPG7W (ORCPT ); Wed, 16 Jun 2021 02:59:22 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G4bWd6ncbz70N2; Wed, 16 Jun 2021 14:54:05 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:57:15 +0800 Received: from [127.0.0.1] (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:57:15 +0800 Subject: Re: [PATCH v2 1/1] mcb: Use DEFINE_RES_MEM() to simplify code To: Greg Kroah-Hartman CC: Johannes Thumshirn , linux-kernel References: <20210616015509.672-1-thunder.leizhen@huawei.com> <20210616015509.672-2-thunder.leizhen@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: <8bd6946b-b3f5-35c7-2cbe-51f4c4841d20@huawei.com> Date: Wed, 16 Jun 2021 14:57:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/6/16 14:41, Greg Kroah-Hartman wrote: > On Wed, Jun 16, 2021 at 09:55:09AM +0800, Zhen Lei wrote: >> Use DEFINE_RES_MEM() to save a couple of lines of code, which makes the >> code a bit shorter and easier to read. The start address does not need to >> appear twice. >> >> By the way, the value of '.end' should be "start + size - 1". So the >> previous writing should have omitted subtracted 1. > > Does that mean the current code is wrong and this is a bugfix? If so, > what commit id does this fix? OK, I'll add Fixes. However, some people think that only functional fixes need to add "Fixes". If "Fixes" were added, I'd have to change the subject, too. > > thanks, > > greg k-h > > . >