From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9BE912C466; Tue, 16 Apr 2024 13:21:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.178.240 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713273672; cv=none; b=fJpjmMBbtfMLnJfwQPq9SesjKsP7cITAzTavnkCHRZ7kFrCNptjHXBfkrL36eRUSo74fDr1Ytn5Yw3PfxcqxWfhhwGR2povoFRodoWz0UcwhbKL34lWwrnn3gOMqjUPmRwWbm8qrAKbAt0KUZlS5k80x3AmYEGE1TIpN/7VCOhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713273672; c=relaxed/simple; bh=H9XJnECG+rehggPZBwMJ2UcoWV6pit0iZcc8APFEx6U=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=Gs2NZyAShD60MZjb3M9o5UIaKuyT6bwpaDegDMYHXpeGlGijaNWyX5oVLTvH/xSkR+i+uGAmgxv+V6i9LiThD/BBEJVBnyXV2rhNDTW/atbWbZAIjx881OojUl0rN/qYxq00xhXTAF/tBISIlJrJ6X9g01PtdYRdXIOTO1K82VM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=jprFcJrV; arc=none smtp.client-ip=217.70.178.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="jprFcJrV" Received: from relay4-d.mail.gandi.net (unknown [217.70.183.196]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 979BEC699F; Tue, 16 Apr 2024 13:21:03 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 1F9ABE0003; Tue, 16 Apr 2024 13:20:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713273656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WCnKnoSsQoEAYv75BNn3l7B7yy2mGKGbl/sOd184mU0=; b=jprFcJrVd9rSnrTiyxix2blgTrCU/Qlp+tzngtuXlZLiieDwzkoOldUgEDp5yVLsbulKIZ CzSEXc5zzaQHSVsTI5W6AOCIkga+IsG1oFTjYI+JU7a3nor22PG5eIgHIbgpmXTpUzBalM mCn64ex2Hn2WUlBRAFWl2qzVao7CKHpEBs+ucgOXjh4GH4LmArUBjbOWczTwHYK7ShMHNl KmqTxXL6PM1QSO34cOPfhY+Nfw1c63wJjVcxyoZ6Vh/+Qj5UH4M+GBNyfiDllwmnsAfBBo Il45EZNbkMeX3HOTXI5P3oxAe/GyR4f2LJuUEWuXGSighZKeZw4vOiEL7rntOA== Date: Tue, 16 Apr 2024 15:21:30 +0200 (CEST) From: Romain Gantois To: Serge Semin cc: Romain Gantois , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Yanteng Si , Maxime Coquelin , Simon Horman , Huacai Chen , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 4/4] net: stmmac: Move MAC caps init to phylink MAC caps getter In-Reply-To: Message-ID: <8ffb6634-6d57-8df8-90c3-aecc585395e5@bootlin.com> References: <20240412180340.7965-1-fancer.lancer@gmail.com> <20240412180340.7965-5-fancer.lancer@gmail.com> <714199e5-edf2-dcbb-216b-563431d70488@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-GND-Sasl: romain.gantois@bootlin.com On Tue, 16 Apr 2024, Serge Semin wrote: > So I don't think that changing it to something different would be a > good alternative. What could be a better option is to rename the > stmmac_ops::phylink_get_caps() callback and > stmmac_mac_phylink_get_caps() macro-function to something like: > > stmmac_ops::link_update_caps() > stmmac_mac_link_update_caps() > > especially seeing the callback no longer sets the phylink MAC > capabilities directly. What do you think? This seems like a good solution to me. Thanks, -- Romain Gantois, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11646C4345F for ; Tue, 16 Apr 2024 13:21:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O3e89erAQu+/Nvr+oS+8nA4mai997CQFkLIDRkmUf9U=; b=i1Mn2IO4xlS9QS eNrHojkBANbckFNmeyT6XB2dZGXZ/O7WmWwdpLp3llpIqTgZKnElI0gXOIMS3rkwZ/1PHGJBCCMFv lWEG1ALdznlSPPXHz0nDffbNlgHn0j2v+GxYtwA8xDvIBwD17ahA2DXM+KqOC1A/K13i/Jm9R9XHC 5mNPP3RhAy8Vf20Q+66O618zgIVkBpWe0PYxFFv6clvBWSs2ULoE2S+1PVDQjLFdoL6VZZYbZvkmV BRKLhkt6fgduymHHDhLEWe5MeLX5UH1hhTgnmnEgX1l+5/ztkekzoPsIBgMfEuL/cfodxbSY27C/w UZpV7hqlP7rYsrBsihqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwikG-0000000CH9N-0KYm; Tue, 16 Apr 2024 13:21:08 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwik9-0000000CH8j-38IG for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2024 13:21:06 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 1F9ABE0003; Tue, 16 Apr 2024 13:20:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713273656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WCnKnoSsQoEAYv75BNn3l7B7yy2mGKGbl/sOd184mU0=; b=jprFcJrVd9rSnrTiyxix2blgTrCU/Qlp+tzngtuXlZLiieDwzkoOldUgEDp5yVLsbulKIZ CzSEXc5zzaQHSVsTI5W6AOCIkga+IsG1oFTjYI+JU7a3nor22PG5eIgHIbgpmXTpUzBalM mCn64ex2Hn2WUlBRAFWl2qzVao7CKHpEBs+ucgOXjh4GH4LmArUBjbOWczTwHYK7ShMHNl KmqTxXL6PM1QSO34cOPfhY+Nfw1c63wJjVcxyoZ6Vh/+Qj5UH4M+GBNyfiDllwmnsAfBBo Il45EZNbkMeX3HOTXI5P3oxAe/GyR4f2LJuUEWuXGSighZKeZw4vOiEL7rntOA== Date: Tue, 16 Apr 2024 15:21:30 +0200 (CEST) From: Romain Gantois To: Serge Semin cc: Romain Gantois , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Yanteng Si , Maxime Coquelin , Simon Horman , Huacai Chen , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 4/4] net: stmmac: Move MAC caps init to phylink MAC caps getter In-Reply-To: Message-ID: <8ffb6634-6d57-8df8-90c3-aecc585395e5@bootlin.com> References: <20240412180340.7965-1-fancer.lancer@gmail.com> <20240412180340.7965-5-fancer.lancer@gmail.com> <714199e5-edf2-dcbb-216b-563431d70488@bootlin.com> MIME-Version: 1.0 X-GND-Sasl: romain.gantois@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240416_062102_603436_4E66CD62 X-CRM114-Status: UNSURE ( 9.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 16 Apr 2024, Serge Semin wrote: > So I don't think that changing it to something different would be a > good alternative. What could be a better option is to rename the > stmmac_ops::phylink_get_caps() callback and > stmmac_mac_phylink_get_caps() macro-function to something like: > > stmmac_ops::link_update_caps() > stmmac_mac_link_update_caps() > > especially seeing the callback no longer sets the phylink MAC > capabilities directly. What do you think? This seems like a good solution to me. Thanks, -- Romain Gantois, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel