From: Krzysztof Kozlowski <krzk@kernel.org>
To: Swathi K S <swathi.ks@samsung.com>
Cc: krzk+dt@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh@kernel.org, conor+dt@kernel.org, richardcochran@gmail.com,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
rmk+kernel@armlinux.org.uk, netdev@vger.kernel.org,
devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
'Pankaj Dubey' <pankaj.dubey@samsung.com>
Subject: Re: [PATCH v6 1/2] dt-bindings: net: Add FSD EQoS device tree bindings
Date: Fri, 14 Feb 2025 11:55:49 +0100 [thread overview]
Message-ID: <904930a2-61e7-4dba-8752-deff45cfeb2e@kernel.org> (raw)
In-Reply-To: <00ce01db7ec3$7f9ab750$7ed025f0$@samsung.com>
On 14/02/2025 10:33, Swathi K S wrote:
>>> Could you please help in detail what specifically needs to be modified
>> regarding the ordering and minItems/maxItems usage?
>> You did not try hard enough.
>>
>> Open other bindings and look how they list clocks. For example any Samsung
>> clock controller bindings. Or any qcom bindings.
>
> Thanks for your insight. I tried understanding the dt-binding implementations from Samsung/ qcom as you suggested.
> I am thinking of making the following modification in clock-names:
>
> clock-names:
> minItems: 5
> items:
> - const: ptp_ref
> - const: master_bus
> - const: slave_bus
> - const: tx
> - const: rx
> - const: master2_bus
> - const: slave2_bus
> - const: eqos_rxclk_mux
> - const: eqos_phyrxclk
> - const: dout_peric_rgmii_clk
>
> Does this align with your feedback or do you suggest any further changes?
Yes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-14 10:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250213044950epcas5p1a7badb480a7e8d843fe0ff51bcf5cbf4@epcas5p1.samsung.com>
2025-02-13 4:46 ` [PATCH v6 0/2] net: stmmac: dwc-qos: Add FSD EQoS support Swathi K S
2025-02-13 4:46 ` [PATCH v6 1/2] dt-bindings: net: Add FSD EQoS device tree bindings Swathi K S
2025-02-13 7:54 ` Krzysztof Kozlowski
2025-02-13 11:04 ` Swathi K S
2025-02-13 12:00 ` Krzysztof Kozlowski
2025-02-14 4:53 ` Swathi K S
2025-02-14 7:31 ` Krzysztof Kozlowski
2025-02-14 9:33 ` Swathi K S
2025-02-14 10:55 ` Krzysztof Kozlowski [this message]
2025-02-14 0:19 ` Andrew Lunn
2025-02-14 5:17 ` Swathi K S
2025-02-14 13:10 ` Andrew Lunn
2025-02-17 5:19 ` Swathi K S
2025-02-17 15:18 ` Andrew Lunn
2025-02-18 3:55 ` Swathi K S
2025-02-18 15:33 ` Andrew Lunn
2025-02-13 4:46 ` [PATCH v6 2/2] net: stmmac: dwc-qos: Add FSD EQoS support Swathi K S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=904930a2-61e7-4dba-8752-deff45cfeb2e@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pankaj.dubey@samsung.com \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=swathi.ks@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.