* [PATCH 0/2] insane.bbclass: fix package_qa_check_buildpaths
@ 2015-07-15 9:16 Robert Yang
2015-07-15 9:16 ` [PATCH 1/2] " Robert Yang
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Robert Yang @ 2015-07-15 9:16 UTC (permalink / raw
To: openembedded-core
The following changes since commit 6be698b7270f73f40d38713ecf13f12aec0ced61:
dpkg: Fix for Fedora22 and new versions of tar (2015-07-13 13:46:45 +0100)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib rbt/buildpath
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/buildpath
Robert Yang (2):
insane.bbclass: fix package_qa_check_buildpaths
insane.bbclass: make package_qa_clean_path return a relative path
meta/classes/insane.bbclass | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] insane.bbclass: fix package_qa_check_buildpaths
2015-07-15 9:16 [PATCH 0/2] insane.bbclass: fix package_qa_check_buildpaths Robert Yang
@ 2015-07-15 9:16 ` Robert Yang
2015-07-15 9:16 ` [PATCH 2/2] insane.bbclass: make package_qa_clean_path return a relative path Robert Yang
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Robert Yang @ 2015-07-15 9:16 UTC (permalink / raw
To: openembedded-core
* Ignore elf files because they usually contain build path:
- The path of the source file such as .c, these are usually happen
when separate B and S since we use absolute path to run configure
script, and then VPATH in Makefile will be an absolute path and
contains build path, we can use relative path in autotools.bbclass
to fix the problem, but we don't have to since they are harmless.
- The configure options such as "configure --with-libtool-sysroot"
- The compile options such as "gcc --sysroot"
These are harmless usually, so ignore elf files.
* Ignore "-dbg" and "-staticdev" package since symbols and .a files
usually contain buildpath.
* Ignore .a files too since they contain buildpath, this mainly for
ignoring:
glibc-2.21: glibc-dev/usr/lib/libc_nonshared.a
libgcc-4.9.3: libgcc-dev/usr/lib/x86_64-poky-linux/4.9.3/libgcc_eh.a
gcc-runtime-4.9.3: libssp-dev/usr/lib/libssp_nonshared.a
* Use full path rather than package_qa_clean_path() when report issue,
this makes it easier to find the file and fix the problem.
Then we will verify other warings and fix one be one.
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
meta/classes/insane.bbclass | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 4537eec..f1eb60a 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -566,8 +566,14 @@ def package_qa_check_buildpaths(path, name, d, elf, messages):
"""
Check for build paths inside target files and error if not found in the whitelist
"""
- # Ignore .debug files, not interesting
- if path.find(".debug") != -1:
+
+ # Ignore staticdev and debug files since symbols and .a usually
+ # contain buildpath.
+ if name.endswith("-dbg") or name.endswith("-staticdev"):
+ return
+
+ # Ignore elf and .a files
+ if elf or path.endswith('.a'):
return
# Ignore symlinks
@@ -578,7 +584,7 @@ def package_qa_check_buildpaths(path, name, d, elf, messages):
with open(path) as f:
file_content = f.read()
if tmpdir in file_content:
- messages["buildpaths"] = "File %s in package contained reference to tmpdir" % package_qa_clean_path(path,d)
+ messages["buildpaths"] = "File %s in package contained reference to tmpdir" % path
QAPATHTEST[xorg-driver-abi] = "package_qa_check_xorg_driver_abi"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] insane.bbclass: make package_qa_clean_path return a relative path
2015-07-15 9:16 [PATCH 0/2] insane.bbclass: fix package_qa_check_buildpaths Robert Yang
2015-07-15 9:16 ` [PATCH 1/2] " Robert Yang
@ 2015-07-15 9:16 ` Robert Yang
2015-07-28 2:24 ` [PATCH 0/2] insane.bbclass: fix package_qa_check_buildpaths Robert Yang
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Robert Yang @ 2015-07-15 9:16 UTC (permalink / raw
To: openembedded-core
Make package_qa_clean_path() return something like "work/path/to/file"
rather than "/work/path/to/file", the relative path is a little clear.
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
meta/classes/insane.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index f1eb60a..5290686 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -161,7 +161,7 @@ def package_qa_get_machine_dict():
def package_qa_clean_path(path,d):
""" Remove the common prefix from the path. In this case it is the TMPDIR"""
- return path.replace(d.getVar('TMPDIR',True),"")
+ return path.replace(d.getVar("TMPDIR", True) + "/", "")
def package_qa_write_error(type, error, d):
logfile = d.getVar('QA_LOGFILE', True)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] insane.bbclass: fix package_qa_check_buildpaths
2015-07-15 9:16 [PATCH 0/2] insane.bbclass: fix package_qa_check_buildpaths Robert Yang
2015-07-15 9:16 ` [PATCH 1/2] " Robert Yang
2015-07-15 9:16 ` [PATCH 2/2] insane.bbclass: make package_qa_clean_path return a relative path Robert Yang
@ 2015-07-28 2:24 ` Robert Yang
2015-08-10 2:44 ` Robert Yang
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Robert Yang @ 2015-07-28 2:24 UTC (permalink / raw
To: openembedded-core
ping.
// Robert
On 07/15/2015 05:16 PM, Robert Yang wrote:
> The following changes since commit 6be698b7270f73f40d38713ecf13f12aec0ced61:
>
> dpkg: Fix for Fedora22 and new versions of tar (2015-07-13 13:46:45 +0100)
>
> are available in the git repository at:
>
> git://git.openembedded.org/openembedded-core-contrib rbt/buildpath
> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/buildpath
>
> Robert Yang (2):
> insane.bbclass: fix package_qa_check_buildpaths
> insane.bbclass: make package_qa_clean_path return a relative path
>
> meta/classes/insane.bbclass | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] insane.bbclass: fix package_qa_check_buildpaths
2015-07-15 9:16 [PATCH 0/2] insane.bbclass: fix package_qa_check_buildpaths Robert Yang
` (2 preceding siblings ...)
2015-07-28 2:24 ` [PATCH 0/2] insane.bbclass: fix package_qa_check_buildpaths Robert Yang
@ 2015-08-10 2:44 ` Robert Yang
2015-08-17 7:14 ` Robert Yang
2015-09-06 7:35 ` Robert Yang
5 siblings, 0 replies; 7+ messages in thread
From: Robert Yang @ 2015-08-10 2:44 UTC (permalink / raw
To: openembedded-core
Ping.
// Robert
On 07/15/2015 05:16 PM, Robert Yang wrote:
> The following changes since commit 6be698b7270f73f40d38713ecf13f12aec0ced61:
>
> dpkg: Fix for Fedora22 and new versions of tar (2015-07-13 13:46:45 +0100)
>
> are available in the git repository at:
>
> git://git.openembedded.org/openembedded-core-contrib rbt/buildpath
> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/buildpath
>
> Robert Yang (2):
> insane.bbclass: fix package_qa_check_buildpaths
> insane.bbclass: make package_qa_clean_path return a relative path
>
> meta/classes/insane.bbclass | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] insane.bbclass: fix package_qa_check_buildpaths
2015-07-15 9:16 [PATCH 0/2] insane.bbclass: fix package_qa_check_buildpaths Robert Yang
` (3 preceding siblings ...)
2015-08-10 2:44 ` Robert Yang
@ 2015-08-17 7:14 ` Robert Yang
2015-09-06 7:35 ` Robert Yang
5 siblings, 0 replies; 7+ messages in thread
From: Robert Yang @ 2015-08-17 7:14 UTC (permalink / raw
To: openembedded-core
ping.
// Robert
On 07/15/2015 05:16 PM, Robert Yang wrote:
> The following changes since commit 6be698b7270f73f40d38713ecf13f12aec0ced61:
>
> dpkg: Fix for Fedora22 and new versions of tar (2015-07-13 13:46:45 +0100)
>
> are available in the git repository at:
>
> git://git.openembedded.org/openembedded-core-contrib rbt/buildpath
> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/buildpath
>
> Robert Yang (2):
> insane.bbclass: fix package_qa_check_buildpaths
> insane.bbclass: make package_qa_clean_path return a relative path
>
> meta/classes/insane.bbclass | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] insane.bbclass: fix package_qa_check_buildpaths
2015-07-15 9:16 [PATCH 0/2] insane.bbclass: fix package_qa_check_buildpaths Robert Yang
` (4 preceding siblings ...)
2015-08-17 7:14 ` Robert Yang
@ 2015-09-06 7:35 ` Robert Yang
5 siblings, 0 replies; 7+ messages in thread
From: Robert Yang @ 2015-09-06 7:35 UTC (permalink / raw
To: openembedded-core
Hello, any comments on this please ?
// Robert
On 07/15/2015 05:16 PM, Robert Yang wrote:
> The following changes since commit 6be698b7270f73f40d38713ecf13f12aec0ced61:
>
> dpkg: Fix for Fedora22 and new versions of tar (2015-07-13 13:46:45 +0100)
>
> are available in the git repository at:
>
> git://git.openembedded.org/openembedded-core-contrib rbt/buildpath
> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/buildpath
>
> Robert Yang (2):
> insane.bbclass: fix package_qa_check_buildpaths
> insane.bbclass: make package_qa_clean_path return a relative path
>
> meta/classes/insane.bbclass | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-09-06 7:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-15 9:16 [PATCH 0/2] insane.bbclass: fix package_qa_check_buildpaths Robert Yang
2015-07-15 9:16 ` [PATCH 1/2] " Robert Yang
2015-07-15 9:16 ` [PATCH 2/2] insane.bbclass: make package_qa_clean_path return a relative path Robert Yang
2015-07-28 2:24 ` [PATCH 0/2] insane.bbclass: fix package_qa_check_buildpaths Robert Yang
2015-08-10 2:44 ` Robert Yang
2015-08-17 7:14 ` Robert Yang
2015-09-06 7:35 ` Robert Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.