From: Chengchang Tang <tangchengchang@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"Min Hu (Connor)" <humin29@huawei.com>
Cc: <dev@dpdk.org>, <maryam.tahhan@intel.com>, <reshma.pattan@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/procinfo: add device registers dump
Date: Mon, 19 Jul 2021 14:40:30 +0800 [thread overview]
Message-ID: <9231217e-8db4-e816-600a-5b6a0d8675fe@huawei.com> (raw)
In-Reply-To: <20210717105107.3d87bd56@hermes.local>
On 2021/7/18 1:51, Stephen Hemminger wrote:
> On Sun, 25 Apr 2021 21:02:22 +0800
> "Min Hu (Connor)" <humin29@huawei.com> wrote:
>
>> +
>> + memset(®_info, 0, sizeof(reg_info));
>> + memset(&dev_info, 0, sizeof(dev_info));
>
> This memset is redundant, rte_eth_dev_info_get already has the same memset.
> For the registers, ethdev should be fixed to do it.
>
The memset for dev_info is indeed redundant. But the memset for reg_info seems
reasonable, because there are some input parameters in reg_info.
E.g. If info->data is NULL the get_reg_info() fills in the width and length
fields. If non-NULL the registers are put into the buffer pointed at by the data
field.
So, I will remove the redundant memset for dev_info, and keep the memset for reg_info
in the next version.
>> +
>> + ret = rte_eth_dev_info_get(i, &dev_info);
>> + if (ret) {
>> + printf("Error getting device info: %d\n", ret);
>> + continue;
>> + }
>> +
>> + ret = rte_eth_dev_get_reg_info(i, ®_info);
>> + if (ret) {
>> + printf("Error getting device reg info: %d\n", ret);
>> + continue;
>> + }
> .
>
next prev parent reply other threads:[~2021-07-19 6:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 13:02 [dpdk-dev] [PATCH] app/procinfo: add device registers dump Min Hu (Connor)
2021-05-19 10:16 ` Thomas Monjalon
2021-06-04 15:04 ` Pattan, Reshma
2021-06-05 3:15 ` Chengchang Tang
2021-06-10 16:25 ` Pattan, Reshma
2021-06-21 2:17 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-07-09 21:55 ` Thomas Monjalon
2021-07-17 2:16 ` Min Hu (Connor)
2021-07-17 17:51 ` [dpdk-dev] [PATCH] " Stephen Hemminger
2021-07-19 6:40 ` Chengchang Tang [this message]
2021-07-17 17:53 ` Stephen Hemminger
2021-07-19 7:00 ` Chengchang Tang
2021-07-22 10:58 ` [dpdk-dev] [PATCH v3] " Min Hu (Connor)
2021-07-29 14:14 ` Pattan, Reshma
2021-07-30 16:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9231217e-8db4-e816-600a-5b6a0d8675fe@huawei.com \
--to=tangchengchang@huawei.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=maryam.tahhan@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.