From: Mikko Perttunen <cyndis@kapsi.fi>
To: Wolfram Sang <wsa@kernel.org>,
Mikko Perttunen <mperttunen@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com, talho@nvidia.com,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, Muhammed Fazal <mfazale@nvidia.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] i2c: tegra-bpmp: ignore DMA safe buffer flag
Date: Tue, 12 Jan 2021 12:19:58 +0200 [thread overview]
Message-ID: <92fb3f30-a08c-eb42-0741-affc3ceae0c0@kapsi.fi> (raw)
In-Reply-To: <20210111214221.GF17475@kunai>
On 1/11/21 11:42 PM, Wolfram Sang wrote:
> On Mon, Jan 11, 2021 at 05:58:16PM +0200, Mikko Perttunen wrote:
>> From: Muhammed Fazal <mfazale@nvidia.com>
>>
>> Ignore I2C_M_DMA_SAFE flag as it does not make a difference
>> for bpmp-i2c, but causes -EINVAL to be returned for valid
>> transactions.
>
> I wonder if bailing out on an unknown flag shouldn't be revisited in
> general? I mean this will happen again when a new I2C_M_* flag is
> introduced.
>
If it's guaranteed that any new flags are optional to handle by the
driver, than that is certainly better. I'll post a v3 with that approach.
thanks,
Mikko
next prev parent reply other threads:[~2021-01-12 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 15:58 [PATCH v2] i2c: tegra-bpmp: ignore DMA safe buffer flag Mikko Perttunen
2021-01-11 21:42 ` Wolfram Sang
2021-01-12 10:19 ` Mikko Perttunen [this message]
2021-01-12 10:26 ` Wolfram Sang
2021-01-12 10:27 ` Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92fb3f30-a08c-eb42-0741-affc3ceae0c0@kapsi.fi \
--to=cyndis@kapsi.fi \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mfazale@nvidia.com \
--cc=mperttunen@nvidia.com \
--cc=stable@vger.kernel.org \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.