From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2FDBC433EF for ; Mon, 4 Jul 2022 10:49:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C5C7383F2F; Mon, 4 Jul 2022 12:49:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 4295D84499; Mon, 4 Jul 2022 12:49:51 +0200 (CEST) Received: from mail-m118111.qiye.163.com (mail-m118111.qiye.163.com [115.236.118.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 64E2383A2F for ; Mon, 4 Jul 2022 12:49:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m118111.qiye.163.com (Hmail) with ESMTPA id B7C3F580450; Mon, 4 Jul 2022 18:49:33 +0800 (CST) Message-ID: <935e205b-976a-4f07-e920-2acc6aa609f3@rock-chips.com> Date: Mon, 4 Jul 2022 18:49:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling Content-Language: en-US To: Lee Jones Cc: sjg@chromium.org, philipp.tomsich@vrull.eu, cym@rock-chips.com, u-boot@lists.denx.de References: <20220621100729.979275-1-lee.jones@linaro.org> From: Kever Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJSktLSjdXWS1ZQUlXWQ8JGhUIEh9ZQVkaSRpCVk1OSktNGk5CTh0eTFUTARMWGhIXJB QOD1lXWRgSC1lBWU5DVUlJVUxVSkpPWVdZFhoPEhUdFFlBWU9LSFVKSktISkNVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Ogg6MSo*Dj09Ty0vF09DLhYC HjgwCx5VSlVKTU5NQkhKTExPSE9MVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFJTE1KNwY+ X-HM-Tid: 0a81c8d46e572eb7kusnb7c3f580450 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi On 2022/7/4 17:23, Lee Jones wrote: > On Fri, 01 Jul 2022, Kever Yang wrote: > >> Hi Lee Jones, >> >> >> On 2022/6/27 16:39, Lee Jones wrote: >>> On Tue, 21 Jun 2022, Lee Jones wrote: >>> >>>> Functions pointed to by this op pointer can return non-zero values >>>> indicating an error. Ensure any error value is propagated back up the >>>> call-chain. >>>> >>>> Signed-off-by: Lee Jones >>>> --- >>>> drivers/ram/rockchip/sdram_rk3399.c | 4 +++- >>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> Weekly check-in: >>> >>> Are these still on someone's radar, or would you like me to [RESEND]? >> It would be better to add leading message "rockchip:" in the subject. > That would be highly unusual. > > Patch subjects are usually formed, as follows: You should able to see many patches with "rockchip:" in U-Boot commit, and also many patches with other platform prefix like "imx:" or "sunxi:". Not like kernel, U-Boot using the same mailing list for all soc platform, so this can help easier to identify which soc vendor it belongs to. Thanks, - Kever > > ": : " > > I only see 2 RAM-only patches (out of the 91 that touch this file) > that do as you suggested and you were the author of both of them. :) >