* [igt-dev] [PATCH i-g-t v3 1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check
@ 2019-08-05 21:30 Caz Yokoyama
2019-08-05 22:09 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/1] " Patchwork
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Caz Yokoyama @ 2019-08-05 21:30 UTC (permalink / raw
To: igt-dev
Signed-off-by: Caz Yokoyama <caz.yokoyama@intel.com>
---
tests/i915/gem_exec_balancer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/i915/gem_exec_balancer.c b/tests/i915/gem_exec_balancer.c
index b2074486..abf90df6 100644
--- a/tests/i915/gem_exec_balancer.c
+++ b/tests/i915/gem_exec_balancer.c
@@ -1267,8 +1267,6 @@ igt_main
{
int i915 = -1;
- igt_skip_on_simulation();
-
igt_fixture {
i915 = drm_open_driver(DRIVER_INTEL);
igt_require_gem(i915);
--
2.21.0.5.gaeb582a983
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check
2019-08-05 21:30 [igt-dev] [PATCH i-g-t v3 1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check Caz Yokoyama
@ 2019-08-05 22:09 ` Patchwork
2019-08-06 9:12 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-10-10 7:55 ` [igt-dev] [PATCH i-g-t v3 1/1] " Katarzyna Dec
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-08-05 22:09 UTC (permalink / raw
To: Caz Yokoyama; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,v3,1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check
URL : https://patchwork.freedesktop.org/series/64734/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6633 -> IGTPW_3318
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/64734/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_3318 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [PASS][1] -> [FAIL][2] ([fdo#103167])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
#### Possible fixes ####
* igt@gem_flink_basic@flink-lifetime:
- fi-icl-u3: [DMESG-WARN][3] ([fdo#107724]) -> [PASS][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/fi-icl-u3/igt@gem_flink_basic@flink-lifetime.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/fi-icl-u3/igt@gem_flink_basic@flink-lifetime.html
* igt@i915_selftest@live_execlists:
- fi-skl-gvtdvm: [DMESG-FAIL][5] ([fdo#111108]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
* igt@i915_selftest@live_hangcheck:
- {fi-icl-guc}: [INCOMPLETE][7] ([fdo#107713] / [fdo#108569]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/fi-icl-guc/igt@i915_selftest@live_hangcheck.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/fi-icl-guc/igt@i915_selftest@live_hangcheck.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: [FAIL][9] ([fdo#109483]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108
Participating hosts (52 -> 45)
------------------------------
Additional (1): fi-kbl-r
Missing (8): fi-kbl-soraka fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-pnv-d510 fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5121 -> IGTPW_3318
CI-20190529: 20190529
CI_DRM_6633: 8009b790d05451f3c92fb5f49d2c0f697e08a2d2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3318: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/
IGT_5121: 242cb6f2149cb9699ba9b316e5f60b756260e829 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v3,1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check
2019-08-05 21:30 [igt-dev] [PATCH i-g-t v3 1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check Caz Yokoyama
2019-08-05 22:09 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/1] " Patchwork
@ 2019-08-06 9:12 ` Patchwork
2019-10-10 7:55 ` [igt-dev] [PATCH i-g-t v3 1/1] " Katarzyna Dec
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-08-06 9:12 UTC (permalink / raw
To: Caz Yokoyama; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,v3,1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check
URL : https://patchwork.freedesktop.org/series/64734/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6633_full -> IGTPW_3318_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/64734/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_3318_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_tiled_swapping@non-threaded:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#108686])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-iclb8/igt@gem_tiled_swapping@non-threaded.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-iclb4/igt@gem_tiled_swapping@non-threaded.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-apl4/igt@gem_workarounds@suspend-resume-context.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
* igt@kms_cursor_crc@pipe-c-cursor-64x21-random:
- shard-apl: [PASS][5] -> [FAIL][6] ([fdo#103232])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-apl1/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-apl2/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html
- shard-kbl: [PASS][7] -> [FAIL][8] ([fdo#103232])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html
* igt@kms_flip@modeset-vs-vblank-race-interruptible:
- shard-glk: [PASS][9] -> [FAIL][10] ([fdo#103060])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-glk5/igt@kms_flip@modeset-vs-vblank-race-interruptible.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-glk7/igt@kms_flip@modeset-vs-vblank-race-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103167]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
- shard-iclb: [PASS][13] -> [INCOMPLETE][14] ([fdo#107713])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-iclb6/igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-iclb7/igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109441]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-iclb3/igt@kms_psr@psr2_primary_page_flip.html
#### Possible fixes ####
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][17] ([fdo#110854]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-iclb7/igt@gem_exec_balancer@smoke.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-iclb4/igt@gem_exec_balancer@smoke.html
* igt@i915_pm_rpm@cursor-dpms:
- shard-iclb: [INCOMPLETE][19] ([fdo#107713] / [fdo#108840]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-iclb7/igt@i915_pm_rpm@cursor-dpms.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-iclb4/igt@i915_pm_rpm@cursor-dpms.html
* igt@i915_pm_rpm@i2c:
- shard-hsw: [FAIL][21] ([fdo#104097]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-hsw7/igt@i915_pm_rpm@i2c.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-hsw5/igt@i915_pm_rpm@i2c.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [DMESG-WARN][23] ([fdo#108566]) -> [PASS][24] +5 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-apl6/igt@i915_suspend@debugfs-reader.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-apl7/igt@i915_suspend@debugfs-reader.html
* igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen:
- shard-kbl: [FAIL][25] ([fdo#103232]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen.html
- shard-apl: [FAIL][27] ([fdo#103232]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-apl5/igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen.html
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: [FAIL][29] ([fdo#105363]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-iclb: [FAIL][31] ([fdo#103167]) -> [PASS][32] +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-kbl: [INCOMPLETE][33] ([fdo#103665]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][35] ([fdo#109441]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-iclb8/igt@kms_psr@psr2_cursor_plane_onoff.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
#### Warnings ####
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][37] ([fdo#107724]) -> [SKIP][38] ([fdo#109349])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6633/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/shard-iclb8/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5121 -> IGTPW_3318
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_6633: 8009b790d05451f3c92fb5f49d2c0f697e08a2d2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3318: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/
IGT_5121: 242cb6f2149cb9699ba9b316e5f60b756260e829 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3318/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v3 1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check
2019-08-05 21:30 [igt-dev] [PATCH i-g-t v3 1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check Caz Yokoyama
2019-08-05 22:09 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/1] " Patchwork
2019-08-06 9:12 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-10-10 7:55 ` Katarzyna Dec
2019-10-10 8:06 ` Chris Wilson
2019-10-10 15:31 ` Caz Yokoyama
2 siblings, 2 replies; 7+ messages in thread
From: Katarzyna Dec @ 2019-10-10 7:55 UTC (permalink / raw
To: Caz Yokoyama; +Cc: igt-dev
On Mon, Aug 05, 2019 at 02:30:35PM -0700, Caz Yokoyama wrote:
Usual approach for patches it to explain WHY we do things. WHAT is
self-explainable by code.
Adding commit msg could make patch more noticable.
Moreover - I would talk to author of the code what he thinks of this change.
Kasia
> Signed-off-by: Caz Yokoyama <caz.yokoyama@intel.com>
> ---
> tests/i915/gem_exec_balancer.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tests/i915/gem_exec_balancer.c b/tests/i915/gem_exec_balancer.c
> index b2074486..abf90df6 100644
> --- a/tests/i915/gem_exec_balancer.c
> +++ b/tests/i915/gem_exec_balancer.c
> @@ -1267,8 +1267,6 @@ igt_main
> {
> int i915 = -1;
>
> - igt_skip_on_simulation();
> -
> igt_fixture {
> i915 = drm_open_driver(DRIVER_INTEL);
> igt_require_gem(i915);
> --
> 2.21.0.5.gaeb582a983
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v3 1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check
2019-10-10 7:55 ` [igt-dev] [PATCH i-g-t v3 1/1] " Katarzyna Dec
@ 2019-10-10 8:06 ` Chris Wilson
2019-10-10 22:38 ` Dixit, Ashutosh
2019-10-10 15:31 ` Caz Yokoyama
1 sibling, 1 reply; 7+ messages in thread
From: Chris Wilson @ 2019-10-10 8:06 UTC (permalink / raw
To: Caz Yokoyama, Katarzyna Dec; +Cc: igt-dev
Quoting Katarzyna Dec (2019-10-10 08:55:28)
> On Mon, Aug 05, 2019 at 02:30:35PM -0700, Caz Yokoyama wrote:
>
> Usual approach for patches it to explain WHY we do things. WHAT is
> self-explainable by code.
> Adding commit msg could make patch more noticable.
>
> Moreover - I would talk to author of the code what he thinks of this change.
No strong opinion; it's a note to say that this igt focusing on sw
details rather than hw so the test is unlikely to be useful for early
bringup.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v3 1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check
2019-10-10 7:55 ` [igt-dev] [PATCH i-g-t v3 1/1] " Katarzyna Dec
2019-10-10 8:06 ` Chris Wilson
@ 2019-10-10 15:31 ` Caz Yokoyama
1 sibling, 0 replies; 7+ messages in thread
From: Caz Yokoyama @ 2019-10-10 15:31 UTC (permalink / raw
To: Katarzyna Dec; +Cc: igt-dev
On Thu, 2019-10-10 at 09:55 +0200, Katarzyna Dec wrote:
> On Mon, Aug 05, 2019 at 02:30:35PM -0700, Caz Yokoyama wrote:
>
> Usual approach for patches it to explain WHY we do things. WHAT is
> self-explainable by code.
> Adding commit msg could make patch more noticable.
Agree. For this case however, I followed the advice which asked me to
do not expose Intel Internal information. The explanation why simulator
check is not neccessary should include because the test runs on pre-
sillicon not yet publicly announced XXX chip.
Anyway, I follow the advice of original author.
>
> Moreover - I would talk to author of the code what he thinks of this
> change.
>
> Kasia
>
> > Signed-off-by: Caz Yokoyama <caz.yokoyama@intel.com>
> > ---
> > tests/i915/gem_exec_balancer.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/tests/i915/gem_exec_balancer.c
> > b/tests/i915/gem_exec_balancer.c
> > index b2074486..abf90df6 100644
> > --- a/tests/i915/gem_exec_balancer.c
> > +++ b/tests/i915/gem_exec_balancer.c
> > @@ -1267,8 +1267,6 @@ igt_main
> > {
> > int i915 = -1;
> >
> > - igt_skip_on_simulation();
> > -
> > igt_fixture {
> > i915 = drm_open_driver(DRIVER_INTEL);
> > igt_require_gem(i915);
> > --
> > 2.21.0.5.gaeb582a983
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v3 1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check
2019-10-10 8:06 ` Chris Wilson
@ 2019-10-10 22:38 ` Dixit, Ashutosh
0 siblings, 0 replies; 7+ messages in thread
From: Dixit, Ashutosh @ 2019-10-10 22:38 UTC (permalink / raw
To: Chris Wilson; +Cc: igt-dev
On Thu, 10 Oct 2019 01:06:54 -0700, Chris Wilson wrote:
>
> Quoting Katarzyna Dec (2019-10-10 08:55:28)
> > On Mon, Aug 05, 2019 at 02:30:35PM -0700, Caz Yokoyama wrote:
> >
> > Usual approach for patches it to explain WHY we do things. WHAT is
> > self-explainable by code.
> > Adding commit msg could make patch more noticable.
> >
> > Moreover - I would talk to author of the code what he thinks of this change.
>
> No strong opinion; it's a note to say that this igt focusing on sw
> details rather than hw so the test is unlikely to be useful for early
> bringup.
Agreed, though there doesn't seem to be any reason for not merging the
change either...
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-10-10 22:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-05 21:30 [igt-dev] [PATCH i-g-t v3 1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check Caz Yokoyama
2019-08-05 22:09 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/1] " Patchwork
2019-08-06 9:12 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-10-10 7:55 ` [igt-dev] [PATCH i-g-t v3 1/1] " Katarzyna Dec
2019-10-10 8:06 ` Chris Wilson
2019-10-10 22:38 ` Dixit, Ashutosh
2019-10-10 15:31 ` Caz Yokoyama
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.