From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: vf init issue with patch igb_uio: issue FLR during open and release of device file Date: Wed, 13 Sep 2017 12:03:57 +0100 Message-ID: <95faf7af-367a-ff42-ed16-b8bf3fdea466@intel.com> References: <20170913104840.GA14229@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , Jianfeng Tan To: Shijith Thotton , "Yang, Qiming" , Gregory Etelson Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E26377CFD for ; Wed, 13 Sep 2017 13:04:01 +0200 (CEST) In-Reply-To: <20170913104840.GA14229@localhost.localdomain> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/13/2017 11:48 AM, Shijith Thotton wrote: > On Wed, Sep 13, 2017 at 07:51:30AM +0000, Yang, Qiming wrote: >> Hi, Shijith >> >> >> >> VF init error will happen after apply your patch, error log as below. If >> revert your commit, all things work well. And this issue is not only occur >> in i40 VF but also ixgbe. >> >> Could you help to check it soon? >> >> >> >> [root@localhost app]# ./testpmd -c 7 -n 4 -- -i >> >> EAL: Detected 10 lcore(s) >> >> EAL: No free hugepages reported in hugepages-1048576kB >> >> EAL: Probing VFIO support... >> >> EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using >> unreliable clock cycles ! >> >> EAL: PCI device 0000:00:03.0 on NUMA socket -1 >> >> EAL: Invalid NUMA socket, default to 0 >> >> EAL: probe driver: 8086:154c net_i40e_vf >> >> i40evf_init_vf(): init_adminq failed: -53 >> >> i40evf_dev_init(): Init vf failed >> >> EAL: Requested device 0000:00:03.0 cannot be used >> >> >> >> commit b58eedfc7dd57eef6d12e2c654a52c834f36084a >> Author: Shijith Thotton >> Date: Fri Jul 7 16:43:51 2017 +0530 >> >> igb_uio: issue FLR during open and release of device file >> >> Set UIO info device file operations open and release. Call pci reset >> function inside open and release to clear device state at start and end. >> Copied this behaviour from vfio_pci kernel module code. With this patch, >> it is not mandatory to issue FLR by PMD's during init and close. >> >> Bus master enable and disable are added in open and release respectively >> to take care of device DMA. >> >> Signed-off-by: Shijith Thotton >> Reviewed-by: Jianfeng Tan >> Acked-by: Ferruh Yigit >> Acked-by: Gregory Etelson >> >> >> >> Best Regard, >> >> Yang Qiming >> >> > > Hi Yang Qiming, > > We didn't face this issue while preparing patch. I think, Gregory tested > it for Intel NICs. Adding more people to the loop for help. > I will try to reproduce the issue. > Shijith >