From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH v2 02/17] x86/hvm: re-name struct hvm_mmio_handler to hvm_mmio_ops Date: Wed, 17 Jun 2015 12:45:48 +0000 Message-ID: <9AAE0902D5BC7E449B7C8E4E778ABCD025952EA3@AMSPEX01CL01.citrite.net> References: <1434037381-10917-1-git-send-email-paul.durrant@citrix.com> <1434037381-10917-3-git-send-email-paul.durrant@citrix.com> <558187A202000078000861ED@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z5Cj2-000063-Jl for xen-devel@lists.xenproject.org; Wed, 17 Jun 2015 12:45:52 +0000 In-Reply-To: <558187A202000078000861ED@mail.emea.novell.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Andrew Cooper , "Keir (Xen.org)" , "xen-devel@lists.xenproject.org" List-Id: xen-devel@lists.xenproject.org > -----Original Message----- > From: Jan Beulich [mailto:JBeulich@suse.com] > Sent: 17 June 2015 13:44 > To: Paul Durrant > Cc: Andrew Cooper; xen-devel@lists.xenproject.org; Keir (Xen.org) > Subject: Re: [PATCH v2 02/17] x86/hvm: re-name struct hvm_mmio_handler > to hvm_mmio_ops > > >>> On 11.06.15 at 17:42, wrote: > > The struct just contains three methods and no data, so the name > > hvm_mmio_ops more accurately reflects its content. A subsequent patch > > introduces a new structure which more accurately warrants the name > > hvm_mmio_handler so doing the rename in this purely cosmetic patch > avoids > > conflating functional and cosmetic changes in a single patch. > > > > Signed-off-by: Paul Durrant > > Acked-by: Jan Beulich Thanks. > albeit > > > @@ -182,21 +182,21 @@ int hvm_mmio_intercept(ioreq_t *p) > > > > for ( i = 0; i < HVM_MMIO_HANDLER_NR; i++ ) > > { > > - hvm_mmio_check_t check_handler = > > - hvm_mmio_handlers[i]->check_handler; > > + hvm_mmio_check_t check = > > + hvm_mmio_handlers[i]->check; > > Does this still not fit on a single line? > Probably does. I'll pull the change into v3 of the series if that's the case. > Jan