* [PATCH v4 1/1] NFSD: fix error handling in NFSv4.0 callbacks
@ 2021-03-11 15:55 Olga Kornievskaia
2021-03-11 16:02 ` Chuck Lever III
0 siblings, 1 reply; 2+ messages in thread
From: Olga Kornievskaia @ 2021-03-11 15:55 UTC (permalink / raw
To: bfields, chuck.lever; +Cc: linux-nfs
From: Olga Kornievskaia <kolga@netapp.com>
When the server tries to do a callback and a client fails it due to
authentication problems, we need the server to set callback down
flag in RENEW so that client can recover.
Suggested-by: Bruce Fields <bfields@redhat.com>
Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
---
fs/nfsd/nfs4callback.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index 052be5bf9ef5..7325592b456e 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -1189,6 +1189,7 @@ static void nfsd4_cb_done(struct rpc_task *task, void *calldata)
switch (task->tk_status) {
case -EIO:
case -ETIMEDOUT:
+ case -EACCES:
nfsd4_mark_cb_down(clp, task->tk_status);
}
break;
--
2.18.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4 1/1] NFSD: fix error handling in NFSv4.0 callbacks
2021-03-11 15:55 [PATCH v4 1/1] NFSD: fix error handling in NFSv4.0 callbacks Olga Kornievskaia
@ 2021-03-11 16:02 ` Chuck Lever III
0 siblings, 0 replies; 2+ messages in thread
From: Chuck Lever III @ 2021-03-11 16:02 UTC (permalink / raw
To: Olga Kornievskaia; +Cc: Bruce Fields, Linux NFS Mailing List
> On Mar 11, 2021, at 10:55 AM, Olga Kornievskaia <olga.kornievskaia@gmail.com> wrote:
>
> From: Olga Kornievskaia <kolga@netapp.com>
>
> When the server tries to do a callback and a client fails it due to
> authentication problems, we need the server to set callback down
> flag in RENEW so that client can recover.
>
> Suggested-by: Bruce Fields <bfields@redhat.com>
> Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
Thanks. This patch has been included in the for-rc topic
branch in the repo at
git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git
I added Ben's Tested-by.
> ---
> fs/nfsd/nfs4callback.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
> index 052be5bf9ef5..7325592b456e 100644
> --- a/fs/nfsd/nfs4callback.c
> +++ b/fs/nfsd/nfs4callback.c
> @@ -1189,6 +1189,7 @@ static void nfsd4_cb_done(struct rpc_task *task, void *calldata)
> switch (task->tk_status) {
> case -EIO:
> case -ETIMEDOUT:
> + case -EACCES:
> nfsd4_mark_cb_down(clp, task->tk_status);
> }
> break;
> --
> 2.18.2
--
Chuck Lever
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-11 16:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-11 15:55 [PATCH v4 1/1] NFSD: fix error handling in NFSv4.0 callbacks Olga Kornievskaia
2021-03-11 16:02 ` Chuck Lever III
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.