* [RFT i-g-t] tests/prime_vgem/basic-fence-flip: Probe display resolution
@ 2019-04-10 11:43 ` Tvrtko Ursulin
0 siblings, 0 replies; 15+ messages in thread
From: Tvrtko Ursulin @ 2019-04-10 11:43 UTC (permalink / raw
To: igt-dev; +Cc: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Some displays might not support hardcoded 1024x768.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109294
---
tests/prime_vgem.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/tests/prime_vgem.c b/tests/prime_vgem.c
index 60bb951c8cbe..458846add9ee 100644
--- a/tests/prime_vgem.c
+++ b/tests/prime_vgem.c
@@ -744,8 +744,22 @@ static void flip_to_vgem(int i915, int vgem,
static void test_flip(int i915, int vgem, unsigned hang)
{
- struct vgem_bo bo[2];
+ drmModeModeInfo *mode = NULL;
uint32_t fb_id[2], handle[2], crtc_id;
+ igt_display_t display;
+ igt_output_t *output;
+ struct vgem_bo bo[2];
+ enum pipe pipe;
+
+ igt_display_require(&display, i915);
+ igt_display_require_output(&display);
+
+ for_each_pipe_with_valid_output(&display, pipe, output) {
+ mode = igt_output_get_mode(output);
+ break;
+ }
+
+ igt_assert(mode);
signal(SIGHUP, sighandler);
@@ -754,8 +768,8 @@ static void test_flip(int i915, int vgem, unsigned hang)
uint32_t offsets[4] = {};
int fd;
- bo[i].width = 1024;
- bo[i].height = 768;
+ bo[i].width = mode->hdisplay;
+ bo[i].height = mode->vdisplay;
bo[i].bpp = 32;
vgem_create(vgem, &bo[i]);
--
2.19.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] [RFT i-g-t] tests/prime_vgem/basic-fence-flip: Probe display resolution
@ 2019-04-10 11:43 ` Tvrtko Ursulin
0 siblings, 0 replies; 15+ messages in thread
From: Tvrtko Ursulin @ 2019-04-10 11:43 UTC (permalink / raw
To: igt-dev; +Cc: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Some displays might not support hardcoded 1024x768.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109294
---
tests/prime_vgem.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/tests/prime_vgem.c b/tests/prime_vgem.c
index 60bb951c8cbe..458846add9ee 100644
--- a/tests/prime_vgem.c
+++ b/tests/prime_vgem.c
@@ -744,8 +744,22 @@ static void flip_to_vgem(int i915, int vgem,
static void test_flip(int i915, int vgem, unsigned hang)
{
- struct vgem_bo bo[2];
+ drmModeModeInfo *mode = NULL;
uint32_t fb_id[2], handle[2], crtc_id;
+ igt_display_t display;
+ igt_output_t *output;
+ struct vgem_bo bo[2];
+ enum pipe pipe;
+
+ igt_display_require(&display, i915);
+ igt_display_require_output(&display);
+
+ for_each_pipe_with_valid_output(&display, pipe, output) {
+ mode = igt_output_get_mode(output);
+ break;
+ }
+
+ igt_assert(mode);
signal(SIGHUP, sighandler);
@@ -754,8 +768,8 @@ static void test_flip(int i915, int vgem, unsigned hang)
uint32_t offsets[4] = {};
int fd;
- bo[i].width = 1024;
- bo[i].height = 768;
+ bo[i].width = mode->hdisplay;
+ bo[i].height = mode->vdisplay;
bo[i].bpp = 32;
vgem_create(vgem, &bo[i]);
--
2.19.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [RFT i-g-t] tests/prime_vgem/basic-fence-flip: Probe display resolution
2019-04-10 11:43 ` [Intel-gfx] " Tvrtko Ursulin
@ 2019-04-10 11:48 ` Chris Wilson
-1 siblings, 0 replies; 15+ messages in thread
From: Chris Wilson @ 2019-04-10 11:48 UTC (permalink / raw
To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx
Quoting Tvrtko Ursulin (2019-04-10 12:43:22)
> @@ -754,8 +768,8 @@ static void test_flip(int i915, int vgem, unsigned hang)
> uint32_t offsets[4] = {};
> int fd;
>
> - bo[i].width = 1024;
> - bo[i].height = 768;
> + bo[i].width = mode->hdisplay;
> + bo[i].height = mode->vdisplay;
> bo[i].bpp = 32;
> vgem_create(vgem, &bo[i]);
That may not result in a buffer that we are able to flip to. :|
width = ALIGN(hdisplay, 16); vdisplay should be ok.
I would query what happened to the scalers though :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [igt-dev] [Intel-gfx] [RFT i-g-t] tests/prime_vgem/basic-fence-flip: Probe display resolution
@ 2019-04-10 11:48 ` Chris Wilson
0 siblings, 0 replies; 15+ messages in thread
From: Chris Wilson @ 2019-04-10 11:48 UTC (permalink / raw
To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx
Quoting Tvrtko Ursulin (2019-04-10 12:43:22)
> @@ -754,8 +768,8 @@ static void test_flip(int i915, int vgem, unsigned hang)
> uint32_t offsets[4] = {};
> int fd;
>
> - bo[i].width = 1024;
> - bo[i].height = 768;
> + bo[i].width = mode->hdisplay;
> + bo[i].height = mode->vdisplay;
> bo[i].bpp = 32;
> vgem_create(vgem, &bo[i]);
That may not result in a buffer that we are able to flip to. :|
width = ALIGN(hdisplay, 16); vdisplay should be ok.
I would query what happened to the scalers though :)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFT i-g-t] tests/prime_vgem/basic-fence-flip: Probe display resolution
2019-04-10 11:48 ` [igt-dev] [Intel-gfx] " Chris Wilson
@ 2019-04-10 12:11 ` Tvrtko Ursulin
-1 siblings, 0 replies; 15+ messages in thread
From: Tvrtko Ursulin @ 2019-04-10 12:11 UTC (permalink / raw
To: Chris Wilson, igt-dev; +Cc: Intel-gfx
On 10/04/2019 12:48, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-04-10 12:43:22)
>> @@ -754,8 +768,8 @@ static void test_flip(int i915, int vgem, unsigned hang)
>> uint32_t offsets[4] = {};
>> int fd;
>>
>> - bo[i].width = 1024;
>> - bo[i].height = 768;
>> + bo[i].width = mode->hdisplay;
>> + bo[i].height = mode->vdisplay;
>> bo[i].bpp = 32;
>> vgem_create(vgem, &bo[i]);
>
> That may not result in a buffer that we are able to flip to. :|
> width = ALIGN(hdisplay, 16); vdisplay should be ok.
Oh.. well I don't know. Maarten helpfully described in the BZ that the
skip is due BO being too small for the FB. Aligning width would then
make it too large. Is that OK? Who assigned this display related IGT bug
to me anyway? :))
> I would query what happened to the scalers though :)
Are they supposed to automagicaly apply any fb to any output? Or an
explicit step is required? Regardless - it may be better to involve less
of the driver and hardware stack in a simple test.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [igt-dev] [Intel-gfx] [RFT i-g-t] tests/prime_vgem/basic-fence-flip: Probe display resolution
@ 2019-04-10 12:11 ` Tvrtko Ursulin
0 siblings, 0 replies; 15+ messages in thread
From: Tvrtko Ursulin @ 2019-04-10 12:11 UTC (permalink / raw
To: Chris Wilson, igt-dev; +Cc: Intel-gfx
On 10/04/2019 12:48, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-04-10 12:43:22)
>> @@ -754,8 +768,8 @@ static void test_flip(int i915, int vgem, unsigned hang)
>> uint32_t offsets[4] = {};
>> int fd;
>>
>> - bo[i].width = 1024;
>> - bo[i].height = 768;
>> + bo[i].width = mode->hdisplay;
>> + bo[i].height = mode->vdisplay;
>> bo[i].bpp = 32;
>> vgem_create(vgem, &bo[i]);
>
> That may not result in a buffer that we are able to flip to. :|
> width = ALIGN(hdisplay, 16); vdisplay should be ok.
Oh.. well I don't know. Maarten helpfully described in the BZ that the
skip is due BO being too small for the FB. Aligning width would then
make it too large. Is that OK? Who assigned this display related IGT bug
to me anyway? :))
> I would query what happened to the scalers though :)
Are they supposed to automagicaly apply any fb to any output? Or an
explicit step is required? Regardless - it may be better to involve less
of the driver and hardware stack in a simple test.
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/prime_vgem/basic-fence-flip: Probe display resolution
2019-04-10 11:43 ` [Intel-gfx] " Tvrtko Ursulin
(?)
(?)
@ 2019-04-10 12:31 ` Patchwork
2019-04-10 12:36 ` Tvrtko Ursulin
-1 siblings, 1 reply; 15+ messages in thread
From: Patchwork @ 2019-04-10 12:31 UTC (permalink / raw
To: Tvrtko Ursulin; +Cc: igt-dev
== Series Details ==
Series: tests/prime_vgem/basic-fence-flip: Probe display resolution
URL : https://patchwork.freedesktop.org/series/59284/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5898 -> IGTPW_2838
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59284/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2838 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@gem_exec_basic@gtt-bsd2:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] +57
* igt@gem_exec_basic@readonly-bsd2:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +76
* igt@i915_module_load@reload:
- fi-blb-e6850: NOTRUN -> INCOMPLETE [fdo#107718]
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: PASS -> DMESG-FAIL [fdo#110235 ]
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: PASS -> INCOMPLETE [fdo#108602] / [fdo#108744]
* igt@kms_busy@basic-flip-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +29
* igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103191] / [fdo#107362] +2
* igt@kms_psr@cursor_plane_move:
- fi-skl-6260u: NOTRUN -> SKIP [fdo#109271] +37
* igt@runner@aborted:
- fi-skl-iommu: NOTRUN -> FAIL [fdo#104108] / [fdo#108602]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@i915_selftest@live_hangcheck:
- fi-bxt-dsi: INCOMPLETE [fdo#103927] -> PASS
* igt@prime_vgem@basic-fence-flip:
- fi-glk-dsi: SKIP [fdo#109271] -> PASS
- fi-bxt-dsi: SKIP [fdo#109271] -> PASS
- fi-kbl-r: SKIP [fdo#109271] -> PASS
- fi-skl-6600u: SKIP [fdo#109271] -> PASS
- fi-icl-y: SKIP [fdo#109294] -> PASS
- fi-whl-u: SKIP [fdo#109271] -> PASS
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-glk-dsi: DMESG-WARN [fdo#105538] / [fdo#107732] / [fdo#109513] -> DMESG-FAIL [fdo#105538] / [fdo#107732] / [fdo#109513]
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105538]: https://bugs.freedesktop.org/show_bug.cgi?id=105538
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107732]: https://bugs.freedesktop.org/show_bug.cgi?id=107732
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109513]: https://bugs.freedesktop.org/show_bug.cgi?id=109513
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (49 -> 44)
------------------------------
Additional (3): fi-byt-clapper fi-skl-6260u fi-pnv-d510
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-n2820 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4937 -> IGTPW_2838
CI_DRM_5898: b7ec63a9ba82930148c90769d04f957f10b6b6da @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2838: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2838/
IGT_4937: 256c6107ee127d2ff07d23dfeb3b8d828cb43b37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2838/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [igt-dev] ✓ Fi.CI.BAT: success for tests/prime_vgem/basic-fence-flip: Probe display resolution
2019-04-10 12:31 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-04-10 12:36 ` Tvrtko Ursulin
0 siblings, 0 replies; 15+ messages in thread
From: Tvrtko Ursulin @ 2019-04-10 12:36 UTC (permalink / raw
To: igt-dev
On 10/04/2019 13:31, Patchwork wrote:
> == Series Details ==
>
> Series: tests/prime_vgem/basic-fence-flip: Probe display resolution
> URL : https://patchwork.freedesktop.org/series/59284/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_5898 -> IGTPW_2838
> ====================================================
>
> Summary
> -------
>
> **SUCCESS**
>
> No regressions found.
[snip]
> #### Possible fixes ####
>
> * igt@gem_exec_suspend@basic-s3:
> - fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
>
> * igt@i915_selftest@live_hangcheck:
> - fi-bxt-dsi: INCOMPLETE [fdo#103927] -> PASS
>
> * igt@prime_vgem@basic-fence-flip:
> - fi-glk-dsi: SKIP [fdo#109271] -> PASS
> - fi-bxt-dsi: SKIP [fdo#109271] -> PASS
> - fi-kbl-r: SKIP [fdo#109271] -> PASS
> - fi-skl-6600u: SKIP [fdo#109271] -> PASS
> - fi-icl-y: SKIP [fdo#109294] -> PASS
> - fi-whl-u: SKIP [fdo#109271] -> PASS
Ship it! :)
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/prime_vgem/basic-fence-flip: Probe display resolution
2019-04-10 11:43 ` [Intel-gfx] " Tvrtko Ursulin
` (2 preceding siblings ...)
(?)
@ 2019-04-10 17:20 ` Patchwork
-1 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2019-04-10 17:20 UTC (permalink / raw
To: Tvrtko Ursulin; +Cc: igt-dev
== Series Details ==
Series: tests/prime_vgem/basic-fence-flip: Probe display resolution
URL : https://patchwork.freedesktop.org/series/59284/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5898_full -> IGTPW_2838_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59284/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2838_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +11
* igt@gem_pread@stolen-snoop:
- shard-iclb: NOTRUN -> SKIP [fdo#109277] +2
* igt@gem_pwrite@huge-gtt-fbr:
- shard-iclb: NOTRUN -> SKIP [fdo#109290]
* igt@gem_tiled_swapping@non-threaded:
- shard-iclb: PASS -> FAIL [fdo#108686]
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-iclb: NOTRUN -> SKIP [fdo#109308]
* igt@i915_pm_rps@min-max-config-loaded:
- shard-iclb: NOTRUN -> FAIL [fdo#108059]
* igt@i915_selftest@live_workarounds:
- shard-iclb: PASS -> DMESG-FAIL [fdo#108954]
* igt@kms_atomic_transition@3x-modeset-transitions:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +3
* igt@kms_atomic_transition@4x-modeset-transitions:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +16
* igt@kms_busy@extended-pageflip-hang-oldfb-render-d:
- shard-iclb: NOTRUN -> SKIP [fdo#109278] +6
* igt@kms_chamelium@hdmi-cmp-nv61:
- shard-iclb: NOTRUN -> SKIP [fdo#109284] +4
* igt@kms_color@pipe-a-ctm-max:
- shard-iclb: NOTRUN -> FAIL [fdo#108147]
* igt@kms_content_protection@legacy:
- shard-iclb: NOTRUN -> SKIP [fdo#109300]
- shard-apl: NOTRUN -> FAIL [fdo#110321] / [fdo#110336]
* igt@kms_cursor_crc@cursor-512x512-sliding:
- shard-iclb: NOTRUN -> SKIP [fdo#109279]
* igt@kms_cursor_crc@cursor-size-change:
- shard-apl: PASS -> FAIL [fdo#103232]
- shard-kbl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] +4
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: PASS -> FAIL [fdo#105767]
* igt@kms_fbcon_fbt@psr:
- shard-iclb: NOTRUN -> FAIL [fdo#103833]
* igt@kms_flip@modeset-vs-vblank-race:
- shard-glk: PASS -> FAIL [fdo#103060]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +23
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: PASS -> FAIL [fdo#103167] +5
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: PASS -> FAIL [fdo#109247] +10
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-iclb: PASS -> FAIL [fdo#105682] / [fdo#109247]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-move:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +90
* igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw:
- shard-iclb: NOTRUN -> FAIL [fdo#109247]
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-plflip-blt:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +14
* igt@kms_lease@cursor_implicit_plane:
- shard-apl: NOTRUN -> FAIL [fdo#110278]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-e:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +6
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-kbl: PASS -> DMESG-WARN [fdo#108566] +1
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-apl: PASS -> DMESG-WARN [fdo#108566] +6
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
- shard-apl: NOTRUN -> FAIL [fdo#108145] +1
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-glk: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: PASS -> FAIL [fdo#103166]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: NOTRUN -> SKIP [fdo#109642]
* igt@kms_psr@no_drrs:
- shard-iclb: PASS -> FAIL [fdo#107383] / [fdo#110215]
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: PASS -> SKIP [fdo#109441] +1
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: NOTRUN -> SKIP [fdo#109441]
* igt@kms_rotation_crc@bad-pixel-format:
- shard-iclb: NOTRUN -> SKIP [fdo#109289] +1
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: PASS -> DMESG-FAIL [fdo#105763]
* igt@kms_setmode@basic:
- shard-kbl: PASS -> FAIL [fdo#99912]
* igt@kms_sysfs_edid_timing:
- shard-apl: NOTRUN -> FAIL [fdo#100047]
* igt@kms_vblank@pipe-a-ts-continuation-dpms-rpm:
- shard-kbl: PASS -> FAIL [fdo#104894] +1
* igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm:
- shard-apl: PASS -> FAIL [fdo#104894] +2
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665] +1
* igt@perf_pmu@busy-check-all-vecs0:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +112
* igt@prime_busy@wait-after-bsd2:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +16
* igt@prime_nv_api@nv_i915_import_twice_check_flink_name:
- shard-iclb: NOTRUN -> SKIP [fdo#109291] +3
* igt@v3d_mmap@mmap-bad-handle:
- shard-iclb: NOTRUN -> SKIP [fdo#109315]
#### Possible fixes ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@gem_softpin@noreloc-s3:
- shard-apl: DMESG-WARN [fdo#108566] -> PASS +4
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-snb: SKIP [fdo#109271] -> PASS
* igt@i915_pm_rpm@i2c:
- shard-iclb: DMESG-WARN [fdo#109982] -> PASS
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-kbl: INCOMPLETE [fdo#103665] / [fdo#107807] -> PASS
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x64-random:
- shard-iclb: INCOMPLETE [fdo#109960] -> PASS
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: FAIL [fdo#104873] -> PASS
* igt@kms_cursor_legacy@cursor-vs-flip-legacy:
- shard-hsw: FAIL [fdo#103355] -> PASS
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#105363] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt:
- shard-iclb: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- shard-iclb: FAIL [fdo#103167] / [fdo#109960] -> PASS
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-pwrite:
- shard-iclb: FAIL [fdo#109247] -> PASS +11
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: SKIP [fdo#109441] -> PASS +3
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-iclb: SKIP [fdo#109441] / [fdo#109960] -> PASS
* igt@kms_psr@sprite_mmap_cpu:
- shard-iclb: FAIL [fdo#107383] / [fdo#110215] -> PASS +1
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
* igt@kms_sysfs_edid_timing:
- shard-iclb: FAIL [fdo#100047] -> PASS
* igt@perf_pmu@cpu-hotplug:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@prime_vgem@basic-fence-flip:
- shard-iclb: SKIP [fdo#109294] -> PASS
#### Warnings ####
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: SKIP [fdo#109349] -> FAIL [fdo#110270]
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103833]: https://bugs.freedesktop.org/show_bug.cgi?id=103833
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108059]: https://bugs.freedesktop.org/show_bug.cgi?id=108059
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#108954]: https://bugs.freedesktop.org/show_bug.cgi?id=108954
[fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109960]: https://bugs.freedesktop.org/show_bug.cgi?id=109960
[fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982
[fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
[fdo#110270]: https://bugs.freedesktop.org/show_bug.cgi?id=110270
[fdo#110278]: https://bugs.freedesktop.org/show_bug.cgi?id=110278
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* IGT: IGT_4937 -> IGTPW_2838
* Piglit: piglit_4509 -> None
CI_DRM_5898: b7ec63a9ba82930148c90769d04f957f10b6b6da @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2838: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2838/
IGT_4937: 256c6107ee127d2ff07d23dfeb3b8d828cb43b37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2838/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [igt-dev] [RFT i-g-t] tests/prime_vgem/basic-fence-flip: Probe display resolution
2019-04-10 12:11 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin
@ 2019-05-07 8:14 ` Tvrtko Ursulin
-1 siblings, 0 replies; 15+ messages in thread
From: Tvrtko Ursulin @ 2019-05-07 8:14 UTC (permalink / raw
To: Chris Wilson, igt-dev; +Cc: Intel-gfx
+Maarten - could you please have a quick look at this patch to see if it
makes sense to you? (https://patchwork.freedesktop.org/series/59284/ -
if you don't have the mailing list history.)
Thanks,
Tvrtko
On 10/04/2019 13:11, Tvrtko Ursulin wrote:
>
> On 10/04/2019 12:48, Chris Wilson wrote:
>> Quoting Tvrtko Ursulin (2019-04-10 12:43:22)
>>> @@ -754,8 +768,8 @@ static void test_flip(int i915, int vgem,
>>> unsigned hang)
>>> uint32_t offsets[4] = {};
>>> int fd;
>>> - bo[i].width = 1024;
>>> - bo[i].height = 768;
>>> + bo[i].width = mode->hdisplay;
>>> + bo[i].height = mode->vdisplay;
>>> bo[i].bpp = 32;
>>> vgem_create(vgem, &bo[i]);
>>
>> That may not result in a buffer that we are able to flip to. :|
>> width = ALIGN(hdisplay, 16); vdisplay should be ok.
>
> Oh.. well I don't know. Maarten helpfully described in the BZ that the
> skip is due BO being too small for the FB. Aligning width would then
> make it too large. Is that OK? Who assigned this display related IGT bug
> to me anyway? :))
>
>> I would query what happened to the scalers though :)
>
> Are they supposed to automagicaly apply any fb to any output? Or an
> explicit step is required? Regardless - it may be better to involve less
> of the driver and hardware stack in a simple test.
>
> Regards,
>
> Tvrtko
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [igt-dev] [Intel-gfx] [RFT i-g-t] tests/prime_vgem/basic-fence-flip: Probe display resolution
@ 2019-05-07 8:14 ` Tvrtko Ursulin
0 siblings, 0 replies; 15+ messages in thread
From: Tvrtko Ursulin @ 2019-05-07 8:14 UTC (permalink / raw
To: Chris Wilson, igt-dev; +Cc: Intel-gfx
+Maarten - could you please have a quick look at this patch to see if it
makes sense to you? (https://patchwork.freedesktop.org/series/59284/ -
if you don't have the mailing list history.)
Thanks,
Tvrtko
On 10/04/2019 13:11, Tvrtko Ursulin wrote:
>
> On 10/04/2019 12:48, Chris Wilson wrote:
>> Quoting Tvrtko Ursulin (2019-04-10 12:43:22)
>>> @@ -754,8 +768,8 @@ static void test_flip(int i915, int vgem,
>>> unsigned hang)
>>> uint32_t offsets[4] = {};
>>> int fd;
>>> - bo[i].width = 1024;
>>> - bo[i].height = 768;
>>> + bo[i].width = mode->hdisplay;
>>> + bo[i].height = mode->vdisplay;
>>> bo[i].bpp = 32;
>>> vgem_create(vgem, &bo[i]);
>>
>> That may not result in a buffer that we are able to flip to. :|
>> width = ALIGN(hdisplay, 16); vdisplay should be ok.
>
> Oh.. well I don't know. Maarten helpfully described in the BZ that the
> skip is due BO being too small for the FB. Aligning width would then
> make it too large. Is that OK? Who assigned this display related IGT bug
> to me anyway? :))
>
>> I would query what happened to the scalers though :)
>
> Are they supposed to automagicaly apply any fb to any output? Or an
> explicit step is required? Regardless - it may be better to involve less
> of the driver and hardware stack in a simple test.
>
> Regards,
>
> Tvrtko
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFT i-g-t] tests/prime_vgem/basic-fence-flip: Probe display resolution
2019-04-10 12:11 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin
@ 2019-05-09 10:51 ` Kahola, Mika
-1 siblings, 0 replies; 15+ messages in thread
From: Kahola, Mika @ 2019-05-09 10:51 UTC (permalink / raw
To: igt-dev@lists.freedesktop.org, chris@chris-wilson.co.uk,
tvrtko.ursulin@linux.intel.com
Cc: Intel-gfx@lists.freedesktop.org
On Wed, 2019-04-10 at 13:11 +0100, Tvrtko Ursulin wrote:
> On 10/04/2019 12:48, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2019-04-10 12:43:22)
> > > @@ -754,8 +768,8 @@ static void test_flip(int i915, int vgem,
> > > unsigned hang)
> > > uint32_t offsets[4] = {};
> > > int fd;
> > >
> > > - bo[i].width = 1024;
> > > - bo[i].height = 768;
> > > + bo[i].width = mode->hdisplay;
> > > + bo[i].height = mode->vdisplay;
> > > bo[i].bpp = 32;
> > > vgem_create(vgem, &bo[i]);
> >
> > That may not result in a buffer that we are able to flip to. :|
> > width = ALIGN(hdisplay, 16); vdisplay should be ok.
>
> Oh.. well I don't know. Maarten helpfully described in the BZ that
> the
> skip is due BO being too small for the FB. Aligning width would then
> make it too large. Is that OK? Who assigned this display related IGT
> bug
> to me anyway? :))
I don't know about that. I have a task to improve the test in my
backlog too :)
This patch definitely improves the test. However, I wasn't able to
apply the patch cleanly on my tree. Maybe it needs a rebase? Anyway, CI
seems to be happy with the change.
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
>
> > I would query what happened to the scalers though :)
>
> Are they supposed to automagicaly apply any fb to any output? Or an
> explicit step is required? Regardless - it may be better to involve
> less
> of the driver and hardware stack in a simple test.
>
> Regards,
>
> Tvrtko
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [igt-dev] [Intel-gfx] [RFT i-g-t] tests/prime_vgem/basic-fence-flip: Probe display resolution
@ 2019-05-09 10:51 ` Kahola, Mika
0 siblings, 0 replies; 15+ messages in thread
From: Kahola, Mika @ 2019-05-09 10:51 UTC (permalink / raw
To: igt-dev@lists.freedesktop.org, chris@chris-wilson.co.uk,
tvrtko.ursulin@linux.intel.com
Cc: Intel-gfx@lists.freedesktop.org
On Wed, 2019-04-10 at 13:11 +0100, Tvrtko Ursulin wrote:
> On 10/04/2019 12:48, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2019-04-10 12:43:22)
> > > @@ -754,8 +768,8 @@ static void test_flip(int i915, int vgem,
> > > unsigned hang)
> > > uint32_t offsets[4] = {};
> > > int fd;
> > >
> > > - bo[i].width = 1024;
> > > - bo[i].height = 768;
> > > + bo[i].width = mode->hdisplay;
> > > + bo[i].height = mode->vdisplay;
> > > bo[i].bpp = 32;
> > > vgem_create(vgem, &bo[i]);
> >
> > That may not result in a buffer that we are able to flip to. :|
> > width = ALIGN(hdisplay, 16); vdisplay should be ok.
>
> Oh.. well I don't know. Maarten helpfully described in the BZ that
> the
> skip is due BO being too small for the FB. Aligning width would then
> make it too large. Is that OK? Who assigned this display related IGT
> bug
> to me anyway? :))
I don't know about that. I have a task to improve the test in my
backlog too :)
This patch definitely improves the test. However, I wasn't able to
apply the patch cleanly on my tree. Maybe it needs a rebase? Anyway, CI
seems to be happy with the change.
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
>
> > I would query what happened to the scalers though :)
>
> Are they supposed to automagicaly apply any fb to any output? Or an
> explicit step is required? Regardless - it may be better to involve
> less
> of the driver and hardware stack in a simple test.
>
> Regards,
>
> Tvrtko
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFT i-g-t] tests/prime_vgem/basic-fence-flip: Probe display resolution
2019-05-09 10:51 ` [igt-dev] [Intel-gfx] " Kahola, Mika
@ 2019-05-09 12:14 ` Tvrtko Ursulin
-1 siblings, 0 replies; 15+ messages in thread
From: Tvrtko Ursulin @ 2019-05-09 12:14 UTC (permalink / raw
To: Kahola, Mika, igt-dev@lists.freedesktop.org,
chris@chris-wilson.co.uk
Cc: Intel-gfx@lists.freedesktop.org
On 09/05/2019 11:51, Kahola, Mika wrote:
> On Wed, 2019-04-10 at 13:11 +0100, Tvrtko Ursulin wrote:
>> On 10/04/2019 12:48, Chris Wilson wrote:
>>> Quoting Tvrtko Ursulin (2019-04-10 12:43:22)
>>>> @@ -754,8 +768,8 @@ static void test_flip(int i915, int vgem,
>>>> unsigned hang)
>>>> uint32_t offsets[4] = {};
>>>> int fd;
>>>>
>>>> - bo[i].width = 1024;
>>>> - bo[i].height = 768;
>>>> + bo[i].width = mode->hdisplay;
>>>> + bo[i].height = mode->vdisplay;
>>>> bo[i].bpp = 32;
>>>> vgem_create(vgem, &bo[i]);
>>>
>>> That may not result in a buffer that we are able to flip to. :|
>>> width = ALIGN(hdisplay, 16); vdisplay should be ok.
>>
>> Oh.. well I don't know. Maarten helpfully described in the BZ that
>> the
>> skip is due BO being too small for the FB. Aligning width would then
>> make it too large. Is that OK? Who assigned this display related IGT
>> bug
>> to me anyway? :))
> I don't know about that. I have a task to improve the test in my
> backlog too :)
>
> This patch definitely improves the test. However, I wasn't able to
> apply the patch cleanly on my tree. Maybe it needs a rebase? Anyway, CI
> seems to be happy with the change.
>
> Reviewed-by: Mika Kahola <mika.kahola@intel.com>
Thanks, pushed!
One less thing on your todo list now. :)
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [RFT i-g-t] tests/prime_vgem/basic-fence-flip: Probe display resolution
@ 2019-05-09 12:14 ` Tvrtko Ursulin
0 siblings, 0 replies; 15+ messages in thread
From: Tvrtko Ursulin @ 2019-05-09 12:14 UTC (permalink / raw
To: Kahola, Mika, igt-dev@lists.freedesktop.org,
chris@chris-wilson.co.uk
Cc: Intel-gfx@lists.freedesktop.org
On 09/05/2019 11:51, Kahola, Mika wrote:
> On Wed, 2019-04-10 at 13:11 +0100, Tvrtko Ursulin wrote:
>> On 10/04/2019 12:48, Chris Wilson wrote:
>>> Quoting Tvrtko Ursulin (2019-04-10 12:43:22)
>>>> @@ -754,8 +768,8 @@ static void test_flip(int i915, int vgem,
>>>> unsigned hang)
>>>> uint32_t offsets[4] = {};
>>>> int fd;
>>>>
>>>> - bo[i].width = 1024;
>>>> - bo[i].height = 768;
>>>> + bo[i].width = mode->hdisplay;
>>>> + bo[i].height = mode->vdisplay;
>>>> bo[i].bpp = 32;
>>>> vgem_create(vgem, &bo[i]);
>>>
>>> That may not result in a buffer that we are able to flip to. :|
>>> width = ALIGN(hdisplay, 16); vdisplay should be ok.
>>
>> Oh.. well I don't know. Maarten helpfully described in the BZ that
>> the
>> skip is due BO being too small for the FB. Aligning width would then
>> make it too large. Is that OK? Who assigned this display related IGT
>> bug
>> to me anyway? :))
> I don't know about that. I have a task to improve the test in my
> backlog too :)
>
> This patch definitely improves the test. However, I wasn't able to
> apply the patch cleanly on my tree. Maybe it needs a rebase? Anyway, CI
> seems to be happy with the change.
>
> Reviewed-by: Mika Kahola <mika.kahola@intel.com>
Thanks, pushed!
One less thing on your todo list now. :)
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-05-09 12:14 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-10 11:43 [RFT i-g-t] tests/prime_vgem/basic-fence-flip: Probe display resolution Tvrtko Ursulin
2019-04-10 11:43 ` [Intel-gfx] " Tvrtko Ursulin
2019-04-10 11:48 ` Chris Wilson
2019-04-10 11:48 ` [igt-dev] [Intel-gfx] " Chris Wilson
2019-04-10 12:11 ` Tvrtko Ursulin
2019-04-10 12:11 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin
2019-05-07 8:14 ` [igt-dev] " Tvrtko Ursulin
2019-05-07 8:14 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin
2019-05-09 10:51 ` Kahola, Mika
2019-05-09 10:51 ` [igt-dev] [Intel-gfx] " Kahola, Mika
2019-05-09 12:14 ` Tvrtko Ursulin
2019-05-09 12:14 ` [Intel-gfx] " Tvrtko Ursulin
2019-04-10 12:31 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-10 12:36 ` Tvrtko Ursulin
2019-04-10 17:20 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.