From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B02AFC433EF for ; Thu, 23 Jun 2022 18:30:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236744AbiFWS37 (ORCPT ); Thu, 23 Jun 2022 14:29:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235866AbiFWS3q (ORCPT ); Thu, 23 Jun 2022 14:29:46 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6E8B81719; Thu, 23 Jun 2022 10:31:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656005492; x=1687541492; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=zIaYVEomzwgXfaMMISVY2yLjmfGKJg5F3MdqvIB4X34=; b=MHuMkRKqW+3jHcD6lD9LxL+WKfIux1lm5y2ZjXeaFUPapi2fT1BmLDhc mOA51qnTY+FxGOXdXWZxIxMKJphXvIYVNt9BRy7X8SQDIsh8sk+lgKkJ1 6vola/oqS661RDKukGh4Y4vln5v2GjzfQxFF3Ye8p4FcZ+kylzSsGKwCh 2NED6twObYpFqDKZ9XStoSi1UQ8RpWts4iKDle6SZ1U9M8O9m4MYTLtfU 8AD2GezN7dKpYybLvwSFLiRYgTaqwkd57iixNOFrfMPsi1M/24S0h6A67 8rqbv2y4aPUOynMNKb296wNvv2HihiXdUxJUPANO4ty9Vh9nhFpTVd0KB A==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="269513665" X-IronPort-AV: E=Sophos;i="5.92,216,1650956400"; d="scan'208";a="269513665" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 10:31:32 -0700 X-IronPort-AV: E=Sophos;i="5.92,216,1650956400"; d="scan'208";a="563533778" Received: from ckeane-mobl1.amr.corp.intel.com (HELO [10.209.81.98]) ([10.209.81.98]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 10:31:31 -0700 Message-ID: <9b350e82-9fcf-b871-ed6c-92848dfa484e@intel.com> Date: Thu, 23 Jun 2022 10:31:05 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCHv7 13/14] x86/tdx: Refactor try_accept_one() Content-Language: en-US To: "Kirill A. Shutemov" , Borislav Petkov , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel Cc: Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Varad Gautam , Dario Faggioli , Mike Rapoport , David Hildenbrand , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220614120231.48165-1-kirill.shutemov@linux.intel.com> <20220614120231.48165-14-kirill.shutemov@linux.intel.com> From: Dave Hansen In-Reply-To: <20220614120231.48165-14-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/14/22 05:02, Kirill A. Shutemov wrote: > Rework try_accept_one() to return accepted size instead of modifying > 'start' inside the helper. It makes 'start' in-only argumaent and ^ argument > streamlines code on the caller side. > > Signed-off-by: Kirill A. Shutemov > Suggested-by: Borislav Petkov I'm not sure how much it actually streamlines things. The line count looks pretty similar. But, I do generally dislike implicit return values, so with that typo fixed: Reviewed-by: Dave Hansen