Re: [PATCH] drm/amd/display: remove "setting DIG_MODE twice" workaround

From: "Kazlauskas, Nicholas" <Nicholas.Kazlauskas-5C7GfCeVMHo@public.gmane.org>
To: "Liu, Zhan" <Zhan.Liu-5C7GfCeVMHo@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"Wu, Hersen" <hersenxs.wu-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] drm/amd/display: remove "setting DIG_MODE twice" workaround
Date: Mon, 4 Nov 2019 16:52:40 +0000	[thread overview]
Message-ID: <9d0a0e07-f68a-8e93-3003-f19ca056b2ff@amd.com> (raw)
In-Reply-To: <DM6PR12MB3466E5EF19CE8BBD78AC6BBE9E7F0-lmeGfMZKVrFD9+oK+SxdZAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>

On 2019-11-04 11:06 a.m., Liu, Zhan wrote:
> [Why]
> The root cause of Navi14 HDMI pink screen issue has been found.
> There is no need to set DIG_MODE twice anymore.
> 
> [How]
> Remove "setting DIG_MODE" twice workaround.
> 
> Signed-off-by: Zhan Liu <zhan.liu@amd.com>

Please use git to revert the commit instead:

eg.

git revert <SHA>

Then add the reasoning to the revert commit message.

Thanks,

Nicholas Kazlauskas

> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 9 ---------
>   1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index cc94c1a73daa..12ba6fdf89b7 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -3027,15 +3027,6 @@ void core_link_enable_stream(
>                                          CONTROLLER_DP_TEST_PATTERN_VIDEOMODE,
>                                          COLOR_DEPTH_UNDEFINED);
> 
> -               /* This second call is needed to reconfigure the DIG
> -                * as a workaround for the incorrect value being applied
> -                * from transmitter control.
> -                */
> -               if (!dc_is_virtual_signal(pipe_ctx->stream->signal))
> -                       stream->link->link_enc->funcs->setup(
> -                               stream->link->link_enc,
> -                               pipe_ctx->stream->signal);
> -
>   #ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT
>                  if (pipe_ctx->stream->timing.flags.DSC) {
>                          if (dc_is_dp_signal(pipe_ctx->stream->signal) ||
> --
> 2.21.0
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> 

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx