From: Gil Fruchter <gilf@ezchip.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Gilad Ben Yossef <giladb@ezchip.com>,
"Chris Metcalf" <cmetcalf@ezchip.com>,
Noam Camus <noamc@ezchip.com>
Subject: RE: [PATCH 1/2] tracing: Prefer kcalloc over kzalloc with multiply
Date: Wed, 3 Jun 2015 11:53:59 +0000 [thread overview]
Message-ID: <AM2PR02MB0626DBB0F190F1BF66EA638EBCB40@AM2PR02MB0626.eurprd02.prod.outlook.com> (raw)
In-Reply-To: <20150602101516.7dd2feb6@gandalf.local.home>
On Tue, Jun 2, 2015 at 5:15 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Tue, 2 Jun 2015 16:26:28 +0300
> Gil Fruchter <gilf@ezchip.com> wrote:
>
>> fix checkpatch warning for using kzalloc with multiply:
>> WARNING: Prefer kcalloc over kzalloc with multiply
>> + iter->buffer_iter = kzalloc(sizeof(*iter->buffer_iter)
>> * num_possible_cpus(),
>
> I'm not against applying this patch, but "fix checkpatch warning" is never rational for a change.
>
> This should say something like, "Use kcalloc for allocating an array instead of a simple multiplier with kzalloc, as that is what kcalloc is used for."
>
> In other words, if checkpatch found something that should be change, have the change log tell us why it should be changed. You can than add a "Found with checkpatch" to give checkpatch the credit.
>
> -- Steve
>
Thanks for the input Steve.
I will create a v2 with an appropriate explanation for this change.
Can I add a Reviewed-by tag by you?
Gil
next prev parent reply other threads:[~2015-06-03 11:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 13:26 [PATCH 0/2] Fix tracing with non-continuous cpu ids Gil Fruchter
2015-06-02 13:26 ` [PATCH 1/2] tracing: Prefer kcalloc over kzalloc with multiply Gil Fruchter
2015-06-02 14:15 ` Steven Rostedt
2015-06-03 11:53 ` Gil Fruchter [this message]
2015-06-08 15:21 ` Steven Rostedt
2015-06-02 13:26 ` [PATCH 2/2] tracing: Fix for non-continuous cpu ids Gil Fruchter
2015-06-02 14:26 ` Steven Rostedt
2015-06-02 15:47 ` Gilad Ben-Yossef
2015-06-09 7:32 ` [PATCH v2 0/2] Fix tracing with " Gil Fruchter
2015-06-09 7:32 ` [PATCH v2 1/2] tracing: Prefer kcalloc over kzalloc with multiply Gil Fruchter
2015-06-09 7:32 ` [PATCH v2 2/2] tracing: Fix for non-continuous cpu ids Gil Fruchter
2015-07-13 16:12 ` Steven Rostedt
2015-07-14 10:12 ` Gil Fruchter
2015-07-14 13:22 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM2PR02MB0626DBB0F190F1BF66EA638EBCB40@AM2PR02MB0626.eurprd02.prod.outlook.com \
--to=gilf@ezchip.com \
--cc=cmetcalf@ezchip.com \
--cc=giladb@ezchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=noamc@ezchip.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.